Query: Advanced Search

	Include stories about projects I am a member of.

Some questions inline. Definitely feel free to re-request review if there's something I'm missing.

JK, I shouldn't have just searched yarn build... should've considered that yarn scripts can be invoked via yarn workspace blah command.

Revert "[keyserver] Use `build:debug` instead of `build` in `postinstall`"

Ah, but we probably DO want yarn build on prod. As @varun said:

Did we make sure this passed keyserver Docker build before landing?

Left a note about the error-handling on the Swift side, definitely let me know if there's something I'm missing. I think we should just be able to match what we're doing on the Android/Kotlin side?

[keyserver] Use `build:debug` instead of `build` in `postinstall`

don't install ci-deps for non-debug

fix yarn build:debug to include install-ci-deps step

This is more related to this task: https://linear.app/comm/issue/ENG-2712/we-dont-run-tests-in-web-and-native-in-precommit-hook
So I'd rather do that when adding the hook

Thanks for fixing these tests. Now that they're working, can we update this diff to include them in CI?

For additional context, fd3 is used by direnv dump to "export the inner bash state at the end of execution." Here's the source from the direnv repo:

In D7009#208076, @tomek wrote:

Have you checked if Redis and MariaDB work correctly after this change? Are we sure that closing this descriptor doesn't cause any issue for a process that opened it?

[nix] Launch `redis-server` from `REDIS_CACHE_DIR`

[nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`

reposition comment in mariadb-up-mac for symmetry

Thanks for the explanation, make sense. I'll add a comment (and restart macOS build).

Revert "[native] Temporary changes for staff release"

[native] `codeVersion` -> 196

[native] Temporary changes for staff release

[native] `codeVersion` -> 195

Don't have a ton of context here.

Looks reasonable to me. Might be good to add someone with more context on notifications as blocking?

[lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector`

Revert "[native] Temporary changes for staff release"

[native] `codeVersion` -> 194

[native] Temporary changes for staff release

[native] `codeVersion` -> 193

[keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`

In D6952#206965, @ashoat wrote:

I'd probably include this with another diff tbh... I think it's easier to see stuff like this combined with the usage, and it's easier to put a concrete test plan too

[lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types

I'll sneak this in D6951

In D6954#206917, @varun wrote:

stat-padding smh

[lib] Introduce `identityKeysBlobValidator` and use in…

rebase after addressing merge conflict

In D6944#206752, @atul wrote:

In D6944#206737, @ashoat wrote:

but identity build seems to have failed CI

Looks like this was because of issues with Buildkite Agent API, restarted the workflows.

In D6944#206737, @ashoat wrote:

but identity build seems to have failed CI

[lib] Sanitize Redux `CryptoStore`

good catch finding this in the docs

[native][keyserver] Persist `signedIdentityKeysBlob` on `register` from `native`

[native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth`…

rebase before landing

Advanced Search
Use Results
Edit Query
Hide Query

Mar 9 2023

Mar 8 2023

Mar 6 2023

Mar 5 2023

Mar 3 2023

Mar 2 2023

Mar 1 2023

Advanced SearchUse ResultsEdit QueryHide Query