Page MenuHomePhabricator
Feed Advanced Search

Mar 21 2023

kamil published D7119: [web-db] add unit tests to function for parsing SQLite query for review.
Mar 21 2023, 4:12 AM
kamil published D7118: [web-db] add function for parsing SQLite query for review.
Mar 21 2023, 4:11 AM

Mar 20 2023

kamil published D7104: [web-db] add unit tests for worker crypto utils for review.
Mar 20 2023, 9:26 AM
kamil published D7103: [web-db] add unit tests for `sql.js` for review.
Mar 20 2023, 9:26 AM
kamil published D7102: [web-db] implement function to get database version for review.
Mar 20 2023, 9:25 AM
kamil published D7101: [web-db] add `sql.js` types for review.
Mar 20 2023, 9:25 AM
kamil added a comment to D6995: [web-db] implement crypto functions.

I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.

Mar 20 2023, 9:21 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase

Mar 20 2023, 9:05 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

update types

Mar 20 2023, 9:04 AM
kamil closed D6993: [web-db] initialize SQLite database.
Mar 20 2023, 3:40 AM
kamil committed rCOMM2b354c58f0f6: [web-db] initialize SQLite database (authored by kamil).
[web-db] initialize SQLite database
Mar 20 2023, 3:40 AM
kamil closed D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 20 2023, 3:40 AM
kamil committed rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset (authored by kamil).
[web-db] Use unique filename for each prod `sql-wasm.wasm` asset
Mar 20 2023, 3:40 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.
In D6993#209859, @tomek wrote:

Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?

Mar 20 2023, 3:38 AM
kamil closed D6992: [web-db] implement proxy for promise-based connection with worker.
Mar 20 2023, 2:51 AM
kamil closed D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:51 AM
kamil committed rCOMM3de89fd327d0: [web-db] implement proxy for promise-based connection with worker (authored by kamil).
[web-db] implement proxy for promise-based connection with worker
Mar 20 2023, 2:51 AM
kamil committed rCOMM661a2b6b9ccd: [web-db] implement basic app-worker connection types (authored by kamil).
[web-db] implement basic app-worker connection types
Mar 20 2023, 2:51 AM
kamil closed D6990: [web-db] add indexedDB config.
Mar 20 2023, 2:51 AM
kamil committed rCOMMe8645d4fe752: [web-db] add indexedDB config (authored by kamil).
[web-db] add indexedDB config
Mar 20 2023, 2:51 AM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:40 AM
kamil updated the test plan for D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:24 AM

Mar 17 2023

kamil added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:46 AM
kamil published D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset for review.
Mar 17 2023, 4:29 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.

Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.

Mar 17 2023, 4:23 AM
kamil updated the test plan for D6993: [web-db] initialize SQLite database.
Mar 17 2023, 4:19 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Reflect changes caused by D7092

Mar 17 2023, 4:18 AM
kamil closed D6988: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers.
Mar 17 2023, 3:47 AM
kamil committed rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers (authored by kamil).
[web-db] not include `crypto`, `fs`, and `path` polyfills for workers
Mar 17 2023, 3:47 AM
kamil closed D6987: [web-db] add Shared Worker config.
Mar 17 2023, 3:47 AM
kamil committed rCOMM5e8770bd0377: [web-db] add Shared Worker config (authored by kamil).
[web-db] add Shared Worker config
Mar 17 2023, 3:47 AM

Mar 15 2023

kamil added inline comments to D6987: [web-db] add Shared Worker config.
Mar 15 2023, 4:14 AM

Mar 13 2023

kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

reabase

Mar 13 2023, 8:48 AM
kamil added a reviewer for D6995: [web-db] implement crypto functions: bartek.
Mar 13 2023, 8:47 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

there is more crypto-relatud stuff, making names more exact to easily distinguish

Mar 13 2023, 8:47 AM
kamil added inline comments to D6993: [web-db] initialize SQLite database.
Mar 13 2023, 8:45 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Check if database result is not empty

Mar 13 2023, 8:43 AM
kamil added inline comments to D6992: [web-db] implement proxy for promise-based connection with worker.
Mar 13 2023, 8:42 AM
kamil updated the diff for D6992: [web-db] implement proxy for promise-based connection with worker.
  • update type
  • add message type to error message
Mar 13 2023, 8:40 AM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mar 13 2023, 8:39 AM
kamil added inline comments to D6990: [web-db] add indexedDB config.
Mar 13 2023, 8:38 AM
kamil added inline comments to D6987: [web-db] add Shared Worker config.
Mar 13 2023, 8:37 AM
kamil updated the diff for D6987: [web-db] add Shared Worker config.
  • update type
  • update worker path
  • add check
Mar 13 2023, 8:36 AM
kamil accepted D7032: [desktop] Handle autoUpdate errors.
Mar 13 2023, 7:23 AM
kamil added inline comments to D7032: [desktop] Handle autoUpdate errors.
Mar 13 2023, 5:54 AM
kamil accepted D6845: [web] Style navigation state info in the top bar.
Mar 13 2023, 2:37 AM
kamil closed D6994: [web-db] implement types for `SubtleCrypto` module.
Mar 13 2023, 1:13 AM
kamil committed rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module (authored by kamil).
[web-db] implement types for `SubtleCrypto` module
Mar 13 2023, 1:13 AM

Mar 10 2023

kamil added inline comments to D6996: [web-db] generate `CryptoKey` and persist.
Mar 10 2023, 7:19 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase, update const

Mar 10 2023, 7:18 AM
kamil added inline comments to D6995: [web-db] implement crypto functions.
Mar 10 2023, 7:15 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

rebase, make type read-only

Mar 10 2023, 7:14 AM
kamil added reviewers for D6994: [web-db] implement types for `SubtleCrypto` module: bartek, ashoat.

Previous types were too general (string instead of current algorithm names). I've updated this to be more precise (like D7023) but with specific types for the entire module - not only AES algorithms.

Mar 10 2023, 7:11 AM
kamil updated the diff for D6994: [web-db] implement types for `SubtleCrypto` module.

improve types and move to flow-typed

Mar 10 2023, 7:04 AM

Mar 9 2023

kamil closed D6986: [web-db] add `localForage` types.
Mar 9 2023, 3:19 AM
kamil committed rCOMM97124d198d47: [web-db] add `localForage` types (authored by kamil).
[web-db] add `localForage` types
Mar 9 2023, 3:19 AM
kamil closed D6985: [web-db] add `localForage` dependency.
Mar 9 2023, 3:19 AM
kamil committed rCOMM69d3fd3666aa: [web-db] add `localForage` dependency (authored by kamil).
[web-db] add `localForage` dependency
Mar 9 2023, 3:19 AM
kamil closed D6989: [web-db] copy `sql-wasm.wasm` from node modules to `dist`.
Mar 9 2023, 2:41 AM
kamil committed rCOMM814966ac416b: [web-db] copy `sql-wasm.wasm` from node modules to `dist` (authored by kamil).
[web-db] copy `sql-wasm.wasm` from node modules to `dist`
Mar 9 2023, 2:41 AM
kamil closed D6981: [web-db] add `sql.js` dependency.
Mar 9 2023, 2:41 AM
kamil committed rCOMM9d60536f0d8d: [web-db] add `sql.js` dependency (authored by kamil).
[web-db] add `sql.js` dependency
Mar 9 2023, 2:41 AM
kamil accepted D6972: [web] Make pressing Inbox button reset selected community.
Mar 9 2023, 2:02 AM
kamil accepted D6970: [web] Add a selector for fetching picked community in Chat tab.

I still prefer selecting by hand, but this approach is also correct

Mar 9 2023, 1:53 AM

Mar 8 2023

kamil accepted D6971: [web] Filter available chats based on the picked community.
Mar 8 2023, 3:28 AM
kamil added inline comments to D6970: [web] Add a selector for fetching picked community in Chat tab.
Mar 8 2023, 3:09 AM
kamil added inline comments to D6969: [web] Add to reducer logic handling community id picked in chat.
Mar 8 2023, 2:48 AM
kamil accepted D6968: [web] Add to redux state picked community in the Chat tab.
Mar 8 2023, 2:39 AM

Mar 7 2023

kamil published D6996: [web-db] generate `CryptoKey` and persist for review.
Mar 7 2023, 10:10 AM
kamil published D6995: [web-db] implement crypto functions for review.
Mar 7 2023, 10:10 AM
kamil published D6994: [web-db] implement types for `SubtleCrypto` module for review.
Mar 7 2023, 10:08 AM
kamil published D6993: [web-db] initialize SQLite database for review.
Mar 7 2023, 10:08 AM
kamil published D6992: [web-db] implement proxy for promise-based connection with worker for review.
Mar 7 2023, 10:07 AM
kamil published D6991: [web-db] implement basic app-worker connection types for review.
Mar 7 2023, 10:06 AM
kamil published D6990: [web-db] add indexedDB config for review.
Mar 7 2023, 10:06 AM
kamil published D6988: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers for review.
Mar 7 2023, 10:06 AM
kamil published D6987: [web-db] add Shared Worker config for review.
Mar 7 2023, 10:05 AM
kamil published D6986: [web-db] add `localForage` types for review.
Mar 7 2023, 10:05 AM
kamil published D6985: [web-db] add `localForage` dependency for review.
Mar 7 2023, 10:04 AM
kamil published D6989: [web-db] copy `sql-wasm.wasm` from node modules to `dist` for review.
Mar 7 2023, 10:04 AM
kamil published D6981: [web-db] add `sql.js` dependency for review.
Mar 7 2023, 10:04 AM

Feb 28 2023

kamil accepted D6891: [desktop/web] Expose callbacks needed for desktop notifications.
Feb 28 2023, 2:45 AM

Feb 27 2023

kamil closed D6713: [native] handle database operations errors in reducer.
Feb 27 2023, 5:42 AM
kamil committed rCOMMf55dc60eb786: [native] handle database operations errors in reducer (authored by kamil).
[native] handle database operations errors in reducer
Feb 27 2023, 5:42 AM
kamil closed D6712: [native] support operations failure in error handling.
Feb 27 2023, 5:42 AM
kamil committed rCOMM5dafd580bc70: [native] support operations failure in error handling (authored by kamil).
[native] support operations failure in error handling
Feb 27 2023, 5:42 AM
kamil added inline comments to D6712: [native] support operations failure in error handling.
Feb 27 2023, 2:19 AM
kamil updated the diff for D6713: [native] handle database operations errors in reducer.

reabase

Feb 27 2023, 2:15 AM
kamil updated the diff for D6712: [native] support operations failure in error handling.

improve code readability

Feb 27 2023, 2:14 AM

Feb 24 2023

kamil accepted D6781: Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.
Feb 24 2023, 5:30 AM
kamil added inline comments to D6816: [web] Change import path and fix errors showing up when the typing is correct.
Feb 24 2023, 2:29 AM
kamil accepted D6812: [web] Change apps tab to be a modal.
Feb 24 2023, 2:04 AM
kamil added inline comments to D6733: [web] Change the Apps tab to be a + button.
Feb 24 2023, 2:02 AM
kamil accepted D6849: [web] Style the AppSwitcher.
Feb 24 2023, 1:39 AM

Feb 22 2023

kamil added inline comments to D6713: [native] handle database operations errors in reducer.
Feb 22 2023, 5:50 AM
kamil accepted D6814: [web] Remove apps as a tab in code logic.
Feb 22 2023, 5:33 AM
kamil added a comment to D6812: [web] Change apps tab to be a modal.

Looks great, only one question:
Isn't the gap between the header Choose apps and actual content with apps bigger on design than on the screenshot you provide?

Feb 22 2023, 4:30 AM
kamil accepted D6741: [web] Move logic for fetching ThreadInfo for possibly pending chat out of ChatMessageListContainer component.
Feb 22 2023, 3:28 AM
kamil added inline comments to D6712: [native] support operations failure in error handling.
Feb 22 2023, 2:39 AM
kamil accepted D6773: Extend PlatformSpecificTools CommonCpp api with an API to retrieve notifications olm account storage path.
Feb 22 2023, 2:11 AM