Page MenuHomePhabricator
Feed All Stories

Jul 18 2024

tomek added inline comments to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 18 2024, 7:47 AM
tomek updated the diff for D12650: Update extractKeyserverIDFromID so that it returns null for DMs.

Update conditions

Jul 18 2024, 7:46 AM
varun accepted D12792: [terraform] Increase Identity memory to 2048.
Jul 18 2024, 7:41 AM
bartek added inline comments to D12770: [Tunnelbroker][lib] add FCM notif message type.
Jul 18 2024, 7:25 AM
bartek accepted D12771: [Tunnelbroker] implement sending FCM notifs by client.
Jul 18 2024, 7:21 AM
bartek accepted D12773: [Tunnelbroker] simplify retrieving device token.
Jul 18 2024, 7:21 AM
bartek accepted D12766: [Tunnelbroker] implement FCM Access Token lifetime.
Jul 18 2024, 7:19 AM
kamil accepted D12786: [lib] Track progress of message processing.

I think the usage of if and dmOpID can be improved and more descriptive, this might look confusing as we have plenty IDs all over the codebase - but I don't have idea about better ones

Jul 18 2024, 7:18 AM
bartek accepted D12765: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0.
Jul 18 2024, 7:16 AM
bartek accepted D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.
Jul 18 2024, 7:15 AM
bartek added a comment to D12792: [terraform] Increase Identity memory to 2048.

Assuming this draft is ready for review since @bartek linked in on Linear

Jul 18 2024, 7:11 AM
kamil accepted D12776: [lib] Generate P2P messages based on actions.
Jul 18 2024, 7:04 AM
tomek updated the test plan for D12786: [lib] Track progress of message processing.
Jul 18 2024, 6:57 AM
tomek updated the test plan for D12776: [lib] Generate P2P messages based on actions.
Jul 18 2024, 6:55 AM
tomek updated the diff for D12786: [lib] Track progress of message processing.

Allow processing DB ops with only p2p messages

Jul 18 2024, 6:53 AM
kamil accepted D12775: [lib] Fix an invalid condition.

🤦‍♂️🙄
Thanks for fixing

Jul 18 2024, 6:44 AM
kamil requested changes to D12749: [lib] Stop requiring sequential messages.

I think this should be done at different level:

  1. Use decrypt here: https://github.com/CommE2E/comm/blob/8b786f1788c01edce880256d4f5318ce54342f29/native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp#L1619
  2. Rename decryptSequentialAndPersist -> decryptAndPersist
Jul 18 2024, 6:41 AM
kamil accepted D12747: [lib] Enable automatic retries for some messages.
Jul 18 2024, 6:36 AM
kamil accepted D12746: [lib] Disable automatic retries of all messages and enable manual retries.
Jul 18 2024, 6:30 AM
kamil accepted D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.
Jul 18 2024, 6:23 AM
ashoat accepted D12792: [terraform] Increase Identity memory to 2048.
Jul 18 2024, 6:16 AM
ashoat published D12792: [terraform] Increase Identity memory to 2048 for review.

Assuming this draft is ready for review since @bartek linked in on Linear

Jul 18 2024, 6:16 AM
kamil accepted D12744: [native][web] Add a method fetching messages by ID.
Jul 18 2024, 6:04 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Update wasm

Jul 18 2024, 5:59 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Update .lock files

Jul 18 2024, 5:52 AM
Harbormaster failed remote builds in B30464: Diff 42463 for D12783: [web] Add bindings for inserting into the search table!
Jul 18 2024, 5:42 AM
tomek updated the diff for D12786: [lib] Track progress of message processing.

Update naming

Jul 18 2024, 5:35 AM
tomek added a comment to D12786: [lib] Track progress of message processing.

I wonder what the difference is between our terms "P2P messages" and "DM"s

I think "P2P messages" cover a superset of DMs – it's basically all client-to-client messages that are encrypted and passed via Tunnelbroker. Does that sound right? And is it consistent with our usage here?

Jul 18 2024, 5:26 AM
tomek added a comment to D12776: [lib] Generate P2P messages based on actions.

Would probably be a good idea to discuss this in my detail in our 1:1 tomorrow. One tradeoff neither of us has mentioned so far about using a single action for all business logic that generates DMOperations is that it might be debugging a little bit more painful.

Yes, definitelly.

Jul 18 2024, 5:22 AM
inka planned changes to D12693: [native][web] Add fts5 extension to SQLite.

I need to update podfile

Jul 18 2024, 5:19 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rename to updateMessageSearchIndex

Jul 18 2024, 5:07 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rename to updateMessageSearchIndex

Jul 18 2024, 5:06 AM
inka added a comment to D12694: [native](web) Add message_search fts5 table.

Heads-up that I landed a different migration 48 in D12759, so you'll have to rebase this one.

Jul 18 2024, 5:02 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Remove patch and update package.json

Jul 18 2024, 5:01 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Rebase

Jul 18 2024, 4:57 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Jul 18 2024, 4:56 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Jul 18 2024, 4:55 AM
inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Rebase

Jul 18 2024, 4:54 AM
bartek added inline comments to D12638: [lib] Send primary device logout message to secondary devices.
Jul 18 2024, 2:28 AM
marcin closed D12784: Make client notif generation code operate on thick threads only.
Jul 18 2024, 1:41 AM
marcin committed rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only (authored by marcin).
Make client notif generation code operate on thick threads only
Jul 18 2024, 1:41 AM
marcin updated the diff for D12784: Make client notif generation code operate on thick threads only.

Rebase before landing

Jul 18 2024, 1:39 AM

Jul 17 2024

ashoat accepted D12791: [terraform] change keyserver version tag.
Jul 17 2024, 8:53 PM
ashoat accepted D12731: [terraform] Migration script for for self-hosted keyserver.
Jul 17 2024, 7:34 PM
will published D12791: [terraform] change keyserver version tag for review.
Jul 17 2024, 7:21 PM
will closed D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
Jul 17 2024, 7:03 PM
will committed rCOMMc46b08343400: [terraform] Ensure that the primary service is running before deploying… (authored by will).
[terraform] Ensure that the primary service is running before deploying…
Jul 17 2024, 7:03 PM
will closed D12729: [terraform] Make number of secondary nodes configured by the user.
Jul 17 2024, 7:03 PM
will committed rCOMMfbd439f617c5: [terraform] Make number of secondary nodes configured by the user (authored by will).
[terraform] Make number of secondary nodes configured by the user
Jul 17 2024, 7:03 PM
will closed D12725: [terraform] add Tunnelbroker configuration variable to self-host.
Jul 17 2024, 7:03 PM
will committed rCOMM53ab9d933f19: [terraform] add Tunnelbroker configuration variable to self-host (authored by will).
[terraform] add Tunnelbroker configuration variable to self-host
Jul 17 2024, 7:03 PM
will closed D12724: [keyserver] add `aws` proxy type for self-hosted keyservers.
Jul 17 2024, 7:02 PM
will committed rCOMMc0e56f735029: [keyserver] add `aws` proxy type for self-hosted keyservers (authored by will).
[keyserver] add `aws` proxy type for self-hosted keyservers
Jul 17 2024, 7:02 PM
will closed D12711: [terraform] Introduce secondary keyserver service.
Jul 17 2024, 7:01 PM
will committed rCOMMbd10a05ecdaf: [terraform] Introduce secondary keyserver service (authored by will).
[terraform] Introduce secondary keyserver service
Jul 17 2024, 7:01 PM
will closed D12710: [terraform] add authoritative keyserver id as a user-specified variable.
Jul 17 2024, 7:01 PM
will closed D12708: [keyserver] configure separation of primary secondary logic.
Jul 17 2024, 7:01 PM
will closed D12709: [terraform] Ensure only one running ecs task for primary service.
Jul 17 2024, 7:01 PM
will committed rCOMMd08760937f81: [terraform] add authoritative keyserver id as a user-specified variable (authored by will).
[terraform] add authoritative keyserver id as a user-specified variable
Jul 17 2024, 7:01 PM
will committed rCOMMfb4a7e309462: [terraform] Ensure only one running ecs task for primary service (authored by will).
[terraform] Ensure only one running ecs task for primary service
Jul 17 2024, 7:01 PM
will committed rCOMM4163b6376fd6: [keyserver] configure separation of primary secondary logic (authored by will).
[keyserver] configure separation of primary secondary logic
Jul 17 2024, 7:01 PM
will closed D12691: [terraform] include REDIS_URL as part of keyserver terraform config.
Jul 17 2024, 7:01 PM
will closed D12690: [terraform] restrict redis access to ecs keyserver service only.
Jul 17 2024, 7:01 PM
will committed rCOMM5810061a8009: [terraform] include REDIS_URL as part of keyserver terraform config (authored by will).
[terraform] include REDIS_URL as part of keyserver terraform config
Jul 17 2024, 7:01 PM
will committed rCOMM5d1bab441ea1: [terraform] restrict redis access to ecs keyserver service only (authored by will).
[terraform] restrict redis access to ecs keyserver service only
Jul 17 2024, 7:01 PM
will closed D12689: [terraform] create comm database on aws rds startup.
Jul 17 2024, 7:01 PM
will committed rCOMMcda5310213fd: [terraform] create comm database on aws rds startup (authored by will).
[terraform] create comm database on aws rds startup
Jul 17 2024, 7:01 PM
will closed D12688: [terraform] make aws rds instance class configurable for self-hosting.
Jul 17 2024, 7:01 PM
will closed D12687: [keyserver] use yarn instead of npm for running prod.
Jul 17 2024, 7:01 PM
will closed D12560: [terraform] set up keyserver load balancer.
Jul 17 2024, 7:01 PM
will committed rCOMM58ebfd29d060: [terraform] make aws rds instance class configurable for self-hosting (authored by will).
[terraform] make aws rds instance class configurable for self-hosting
Jul 17 2024, 7:01 PM
will committed rCOMM9f06f728b442: [keyserver] use yarn instead of npm for running prod (authored by will).
[keyserver] use yarn instead of npm for running prod
Jul 17 2024, 7:01 PM
will committed rCOMM09879f5ea31b: [terraform] set up keyserver load balancer (authored by will).
[terraform] set up keyserver load balancer
Jul 17 2024, 7:01 PM
will closed D12559: [terraform] Increase keyserver primary ecs task resources.
Jul 17 2024, 7:01 PM
will closed D12558: [keyserver] add health check route to keyserver for use by load balancer.
Jul 17 2024, 7:01 PM
will committed rCOMM66409462524b: [keyserver] add health check route to keyserver for use by load balancer (authored by will).
[keyserver] add health check route to keyserver for use by load balancer
Jul 17 2024, 7:01 PM
will committed rCOMMd57e16069a74: [terraform] Increase keyserver primary ecs task resources (authored by will).
[terraform] Increase keyserver primary ecs task resources
Jul 17 2024, 7:01 PM
will closed D12531: [terraform] initial ecs setup for keyserver primary.
Jul 17 2024, 7:01 PM
will committed rCOMM5ecf79ec6e26: [terraform] initial ecs setup for keyserver primary (authored by will).
[terraform] initial ecs setup for keyserver primary
Jul 17 2024, 7:01 PM
will updated the summary of D12531: [terraform] initial ecs setup for keyserver primary.
Jul 17 2024, 6:57 PM
will updated the summary of D12531: [terraform] initial ecs setup for keyserver primary.
Jul 17 2024, 6:56 PM
will abandoned D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Jul 17 2024, 6:56 PM
will updated the diff for D12730: [terraform] Ensure that the primary service is running before deploying secondary service.

review feedback

Jul 17 2024, 5:20 PM
will updated the diff for D12729: [terraform] Make number of secondary nodes configured by the user.

feedback

Jul 17 2024, 5:17 PM
will updated the diff for D12731: [terraform] Migration script for for self-hosted keyserver.

review feedback with minimum requirements to land

Jul 17 2024, 5:14 PM
will added a comment to D12725: [terraform] add Tunnelbroker configuration variable to self-host.

Going to make turning tunnelbroker url and identity socket address into json objects into a follow up

Jul 17 2024, 4:47 PM
will updated the diff for D12724: [keyserver] add `aws` proxy type for self-hosted keyservers.

rebase for landing

Jul 17 2024, 4:43 PM
will retitled D12725: [terraform] add Tunnelbroker configuration variable to self-host from [terraform] add terraform configuration variable to self-host to [terraform] add Tunnelbroker configuration variable to self-host.
Jul 17 2024, 4:42 PM
atul requested review of D12790: [web] Introduce `web` migration to strip member permissions.
Jul 17 2024, 4:25 PM
will updated the diff for D12711: [terraform] Introduce secondary keyserver service.

rebase

Jul 17 2024, 4:23 PM
atul requested review of D12789: [native] Introduce `native` migration to strip member permissions.
Jul 17 2024, 4:19 PM
Harbormaster failed remote builds in B30448: Diff 42429 for D12711: [terraform] Introduce secondary keyserver service!
Jul 17 2024, 4:09 PM
will updated the diff for D12711: [terraform] Introduce secondary keyserver service.

rebase

Jul 17 2024, 4:05 PM
atul requested review of D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Jul 17 2024, 3:51 PM
will added a comment to D12688: [terraform] make aws rds instance class configurable for self-hosting.

If you could remind me to make sure I set db.m6g.large when we set up my keyserver, that would be great!

Jul 17 2024, 3:42 PM
will updated the diff for D12687: [keyserver] use yarn instead of npm for running prod.

feedback

Jul 17 2024, 3:41 PM
will closed D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.
Jul 17 2024, 3:29 PM
will committed rCOMM841f99f84dc2: [keyserver] upgrade redis to version 7 on docker based keyserver (authored by will).
[keyserver] upgrade redis to version 7 on docker based keyserver
Jul 17 2024, 3:29 PM
will closed D12458: [terraform] initial Redis terraform config.
Jul 17 2024, 3:29 PM
will closed D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.
Jul 17 2024, 3:29 PM