Delete sidebar only if it doesn't have a parent
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 29 2024
Jul 29 2024
kamil published D12908: [Tunnelbroker] add DDB column with information about invalid device token for review.
marcin committed rCOMM523348e13633: Prevent desktop devices from presenting themselves as web to identity (authored by marcin).
Prevent desktop devices from presenting themselves as web to identity
Bump identity staging version to 0.34
Add all the thread to the utils
Add all threads to utils
bartek committed rCOMM9d2b6b4ad0aa: [lib] Implement sending WebPush notifs using Tunnelbroker (authored by bartek).
[lib] Implement sending WebPush notifs using Tunnelbroker
bartek committed rCOMM7bb781975a47: [tunnelbroker] Implement sending WebPush notifs by clients (authored by bartek).
[tunnelbroker] Implement sending WebPush notifs by clients
bartek committed rCOMM61bfe5dd37da: [tunnelbroker][lib] Add WebPush notif message type (authored by bartek).
[tunnelbroker][lib] Add WebPush notif message type
bartek committed rCOMM60a01205a529: [tunnelbroker] Implement sending WebPush notifs (authored by bartek).
[tunnelbroker] Implement sending WebPush notifs
bartek committed rCOMMdfc5114afe7f: [tunnelbroker] Implement WebPush client adapter (authored by bartek).
[tunnelbroker] Implement WebPush client adapter
bartek committed rCOMMe33868cba63d: [util-macros] Improve TagAwareDeserialize to read serde attributes (authored by bartek).
[util-macros] Improve TagAwareDeserialize to read serde attributes
bartek committed rCOMMa1ec2400de91: [util-macros] Add tests for serde and TagAwareDeserialize behavior (authored by bartek).
[util-macros] Add tests for serde and TagAwareDeserialize behavior
bartek committed rCOMM9463274996c6: [shared][rust] Add proc-macro to deserialize tagged enum variants (authored by bartek).
[shared][rust] Add proc-macro to deserialize tagged enum variants
marcin updated the diff for D12900: Prevent desktop devices from presenting themselves as web to identity.
Use Object.freeze for constants mapping from platform types to identity platform types. Rebase before landing
Rebase before landing
marcin added a comment to D12900: Prevent desktop devices from presenting themselves as web to identity.
In D12900#365111, @bartek wrote:In D12900#365033, @varun wrote:now that we supply platform details as metadata, should we be sending the device type in the key upload at all? seems like we should just remove it? cc @bartek
Not entirely sure, but probably yes. Would be good to create a follow-up task to discuss this more.
Add a new member
Add new users
Create a new thread
Include new messages in thread creation join update
Update unread status
Create new thread
Create a validator
kamil committed rCOMM885338dacf3a: [CryptoModule] remove `decryptSequential` API (authored by kamil).
[CryptoModule] remove `decryptSequential` API
[lib] Stop requiring sequential messages
remove dead code
will committed rCOMMe667653179ea: [terraform] move dns_name output to outputs.tf (authored by will).
[terraform] move dns_name output to outputs.tf
will committed rCOMMea65d810a92e: [terraform] Remove unnecessary mariadb address output (authored by will).
[terraform] Remove unnecessary mariadb address output
update
Accepting with some comments, you can re-request review if needed.
Nice 👏
I'm lacking too much context here
In D12900#365033, @varun wrote:now that we supply platform details as metadata, should we be sending the device type in the key upload at all? seems like we should just remove it? cc @bartek
Looks ok to me, but we need to make sure @ashoat will take a look before landing
bartek committed rCOMM4c54b9c24d52: [identity] Forbid duplicated devices in device lists (authored by bartek).
[identity] Forbid duplicated devices in device lists
Neat! 😄 I'm not a React/UI expert so resigning, but I'm glad my gist helped.
Jul 28 2024
Jul 28 2024
Nice! The code structure looks neat!
In the future we can do a similar thing to our ECS services - modules can help avoid lots of duplication.
varun attached a referenced file: F2349070: Simulator Screenshot - iPhone 15 Pro Max - 2024-07-29 at 00.08.07.png.
will requested review of D12906: [terraform] Create module for webapp/landing and convert webapp to module.
now that we supply platform details as metadata, should we be sending the device type in the key upload at all? seems like we should just remove it? cc @bartek
bartek published D12903: [util-macros] Improve TagAwareDeserialize to read serde attributes for review.
bartek published D12902: [util-macros] Add tests for serde and TagAwareDeserialize behavior for review.
bartek published D12901: [shared][rust] Add proc-macro to deserialize tagged enum variants for review.
Rebase
Rebase
Add TagAwareDeserialize to the struct. This should fix CI
marcin requested review of D12900: Prevent desktop devices from presenting themselves as web to identity.
marcin updated the diff for D12838: Implement web notifs session createion with race condition handling.
Fix desktop notifications