address feedback

making ashoat blocking since we're discussing when to do this deployment on Comm

In D12619#357437, @ashoat wrote:

What is the URL that is printed? Wondering if it's https or some sort of deep link

https://linear.app/comm/issue/ENG-8813/remove-recursive-logic-from-tunnelbroker-websocket-code-in-keyserver

staging is fixed now -- all items in the identity-users table with a username attribute now also have a usernameLower attribute

1. Don't pass references to unique pointer between lambdas - a rookie mistake!. Pass shared pointers by copy.
2. Switch to multi process mode on MMKV on Android

Model after useThreadChatMentionCandidates

Great catch @inka. You're totally right... this did break non-GENESIS communities.

In D12695#360306, @ashoat wrote:

Hey @marcin, any reason this hasn't been landed yet?

Rebase before landing

Hey @marcin, any reason this hasn't been landed yet?

Just saw https://linear.app/comm/issue/ENG-8810/unable-to-login#comment-47abbe95. Unrelated to the actual code in this diff but we should probably make a fix a dependency for this one

Sorry about this!

Memozie

Address review

This diff caused https://linear.app/comm/issue/ENG-8810/unable-to-login - we're reading from the new index but we didn't create records in it for existing users.

The name getCommunityThreadIDForGenesisThreads seems to suggest that this function only returns values for GENESIS subchannels. Can you confirm this doesn't break for chats in other communities?

update

this solution is pretty neat

update

update

In D12704#360102, @will wrote:

Directly synced with Varun. Looks good. Before landing make sure to remove need for unnecessary partition key check and add a comment for changes starting from line 340 in services/identity/src/database.rs

some small fixes

address comments

Can't we factor out some shared state and have JoinHandler set the state after it tries once? We would check the state in both components

Hmm... what did you think of my suggestion earlier?

What do you think about making sure this effect is only run once per app startup?

run this command every time

Hmm... what did you think of my suggestion earlier?

update

Messed something up when stashing + rebasing

address comments

This diff and the parent diff are missing React.useMemos in critical places

Please wrap the previouslySelectedUserIDs declaration is a useMemo before landing! If you disagree or if the feedback doesn't make sense, please re-request review

Your general approach with rendering a separate JoinHandler for each community makes sense to me. Helps avoid the complexity of having to convert useJoinCommunity to useJoinCommunities

Thanks for finding this bug!! Really appreciate you trying to make sure your work is 100% before finishing off.