Page MenuHomePhabricator
Feed All Stories

Thu, Nov 14

will requested review of D13944: [terraform] create backup cloudwatch alarms.
Thu, Nov 14, 9:16 PM
will requested review of D13943: [terraform] break up alarms into separate terraform files.
Thu, Nov 14, 9:09 PM
will requested review of D13942: [backup] add errorType to error logs in backup.
Thu, Nov 14, 9:03 PM
will requested review of D13941: [backup/terraform] use json logs in backup if COMM_SERVICES_USE_JSON_LOGS variable set to true.
Thu, Nov 14, 9:01 PM
angelika requested review of D13939: [lib] Consider thread infos in useUsersSupportThickThreads().
Thu, Nov 14, 2:08 PM
angelika requested review of D13940: [lib] Don't swallow errors in getUserIdentities() call.
Thu, Nov 14, 2:08 PM
angelika requested review of D13938: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships().
Thu, Nov 14, 2:06 PM
ashoat added inline comments to D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Thu, Nov 14, 4:53 AM
ashoat retitled D13919: [lib] Don't bump thin thread timestamp for membership robotext from [lib] Don't bump thick thread timestamp for membership robotext to [lib] Don't bump thin thread timestamp for membership robotext.
Thu, Nov 14, 4:53 AM
ashoat added a comment to D13906: [native] Introduce a restore button.

To be honest, I think it looks okay without the underline. What do you think?

Thu, Nov 14, 4:52 AM
tomek added a comment to D13906: [native] Introduce a restore button.

I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible.

That's a fair concern. It might be possible to improve with color, italics, underline, etc... might be easier to think about if we had a screenshot.

Thu, Nov 14, 2:06 AM
tomek added inline comments to D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.
Thu, Nov 14, 1:08 AM
tomek added inline comments to D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Thu, Nov 14, 1:05 AM

Wed, Nov 13

ashoat accepted D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.
Wed, Nov 13, 12:50 PM
ashoat accepted D13927: [keyserver] Have @babel/preset-react use automatic runtime.
Wed, Nov 13, 12:50 PM
will requested review of D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.
Wed, Nov 13, 12:41 PM
will accepted D13925: [landing] Add Rahul to landing page.
Wed, Nov 13, 12:24 PM
ashoat requested review of D13925: [landing] Add Rahul to landing page.
Wed, Nov 13, 12:13 PM
will updated the diff for D13927: [keyserver] Have @babel/preset-react use automatic runtime.

rebase

Wed, Nov 13, 11:55 AM
will published D13927: [keyserver] Have @babel/preset-react use automatic runtime for review.
Wed, Nov 13, 11:45 AM
angelika closed D13924: [lib] Fix long line in olmSessionErrors.
Wed, Nov 13, 11:27 AM
angelika committed rCOMM3e5fbff299f3: [lib] Fix long line in olmSessionErrors (authored by angelika).
[lib] Fix long line in olmSessionErrors
Wed, Nov 13, 11:27 AM
angelika closed D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.
Wed, Nov 13, 11:25 AM
angelika committed rCOMMf7cf29b804d1: [lib] Fix capitalization in usePeerToPeerMessageHandler (authored by angelika).
[lib] Fix capitalization in usePeerToPeerMessageHandler
Wed, Nov 13, 11:24 AM
angelika closed D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.
Wed, Nov 13, 11:22 AM
angelika committed rCOMMadd745dbaf17: [sqlite] Add missing spaces in getInboundP2PMessagesByID query (authored by angelika).
[sqlite] Add missing spaces in getInboundP2PMessagesByID query
Wed, Nov 13, 11:22 AM
ashoat closed D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
Wed, Nov 13, 11:20 AM
ashoat closed D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
Wed, Nov 13, 11:20 AM
ashoat committed rCOMMed9e9cf2c268: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime (authored by ashoat).
[lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM4d3afd3231b5: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different (authored by ashoat).
[lib][web] Await lastUpdatedTime and update ChatThreadItems if different
Wed, Nov 13, 11:20 AM
ashoat closed D13914: [lib] Extract getSidebarItems.
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM481690308381: [lib] Extract getSidebarItems (authored by ashoat).
[lib] Extract getSidebarItems
Wed, Nov 13, 11:20 AM
ashoat closed D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.
Wed, Nov 13, 11:20 AM
ashoat closed D13912: [lib] Extract getLastUpdatedTime to a separate file.
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM642c7eb1e0a3: [lib] Introduce MessageSpec.getLastUpdatedTime (authored by ashoat).
[lib] Introduce MessageSpec.getLastUpdatedTime
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file (authored by ashoat).
[lib] Extract getLastUpdatedTime to a separate file
Wed, Nov 13, 11:20 AM
ashoat closed D13911: [lib] Convert sidebarInfoSelector to a hook.
Wed, Nov 13, 11:20 AM
ashoat closed D13921: [lib] Move sidebarInfoSelector to different folder.
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM0612ebfa0ff2: [lib] Convert sidebarInfoSelector to a hook (authored by ashoat).
[lib] Convert sidebarInfoSelector to a hook
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM1d7782667623: [lib] Move sidebarInfoSelector to different folder (authored by ashoat).
[lib] Move sidebarInfoSelector to different folder
Wed, Nov 13, 11:20 AM
ashoat closed D13910: [lib] Inline getMostRecentMessageInfo.
Wed, Nov 13, 11:20 AM
ashoat committed rCOMM4cfad4a5f144: [lib] Inline getMostRecentMessageInfo (authored by ashoat).
[lib] Inline getMostRecentMessageInfo
Wed, Nov 13, 11:20 AM
ashoat added inline comments to D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Wed, Nov 13, 11:15 AM
ashoat added inline comments to D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Wed, Nov 13, 11:13 AM
ashoat updated the diff for D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

Use Array.prototype.every()

Wed, Nov 13, 11:01 AM
ashoat added inline comments to D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
Wed, Nov 13, 11:01 AM
varun closed D13920: [native] remove exitingCallback.
Wed, Nov 13, 11:00 AM
varun committed rCOMM485956d0276d: [native] remove exitingCallback (authored by varun).
[native] remove exitingCallback
Wed, Nov 13, 11:00 AM
varun closed D13917: [native] make the list of NUX tips to be displayed configurable.
Wed, Nov 13, 11:00 AM
varun committed rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable (authored by varun).
[native] make the list of NUX tips to be displayed configurable
Wed, Nov 13, 11:00 AM
ashoat updated the diff for D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.

Code comments

Wed, Nov 13, 10:56 AM
ashoat added inline comments to D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.
Wed, Nov 13, 10:55 AM
ashoat added inline comments to D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
Wed, Nov 13, 10:34 AM
ashoat added a comment to D13906: [native] Introduce a restore button.

I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible.

Wed, Nov 13, 7:49 AM
tomek added a comment to D13906: [native] Introduce a restore button.

Hmm... the reason I'm thinking of a link is that our restore flow is comparable to a "Forgot password?" flow, and I usually see those accessed by a link.

I think a button would be too distracting, and might come across as part of the QR code flow when it's really a separate thing.

Yeah, that makes sense.

Wed, Nov 13, 7:40 AM
ashoat added a comment to D13906: [native] Introduce a restore button.

It sounds like you're proposing a solution where on the initial screen there are two buttons: Sign in and Register. Clicking Sign in opens the QR screen, where there is a No longer have access to your primary device? text. Clicking this link would open the restore screen. Is that correct?

Wed, Nov 13, 7:25 AM
ashoat accepted D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.
Wed, Nov 13, 7:23 AM
ashoat accepted D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.
Wed, Nov 13, 7:23 AM
ashoat accepted D13924: [lib] Fix long line in olmSessionErrors.
Wed, Nov 13, 7:23 AM
tomek updated the summary of D13907: [lib] Introduce a restore screen.
Wed, Nov 13, 7:09 AM
tomek updated the diff for D13907: [lib] Introduce a restore screen.

Update copy and remove "or" section

Wed, Nov 13, 7:08 AM
angelika requested review of D13924: [lib] Fix long line in olmSessionErrors.
Wed, Nov 13, 7:04 AM
tomek added a comment to D13906: [native] Introduce a restore button.

I think it would be best to tuck the restore button behind the login button.

Basically we would show the QR screen, and then there would be a link below it that says something like "No longer have access to your primary device?"

What do you think?

Wed, Nov 13, 7:02 AM
angelika requested review of D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.
Wed, Nov 13, 6:58 AM
angelika requested review of D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.
Wed, Nov 13, 6:55 AM
angelika closed D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().
Wed, Nov 13, 6:10 AM
angelika committed rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages() (authored by angelika).
[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()
Wed, Nov 13, 6:10 AM
angelika closed D13908: [sqlite] Read Outbound messages with status different than sent.
Wed, Nov 13, 6:10 AM
angelika committed rCOMM825e943afe0f: [sqlite] Read Outbound messages with status different than sent (authored by angelika).
[sqlite] Read Outbound messages with status different than sent
Wed, Nov 13, 6:10 AM
ashoat added inline comments to D13901: [lib] Do not reset a session when getting already decrypted message.
Wed, Nov 13, 5:59 AM
ashoat added inline comments to D13897: [sqlite] Add getInboundP2PMessagesByID query.
Wed, Nov 13, 5:49 AM
tomek accepted D13920: [native] remove exitingCallback.
Wed, Nov 13, 5:20 AM
angelika updated the diff for D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Fix line order

Wed, Nov 13, 5:18 AM
tomek accepted D13917: [native] make the list of NUX tips to be displayed configurable.
Wed, Nov 13, 5:18 AM
tomek accepted D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Wed, Nov 13, 4:57 AM
tomek accepted D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.
Wed, Nov 13, 4:53 AM
tomek accepted D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
Wed, Nov 13, 4:52 AM
tomek accepted D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
Wed, Nov 13, 4:38 AM
angelika updated the diff for D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Rebase

Wed, Nov 13, 4:25 AM
angelika updated the diff for D13908: [sqlite] Read Outbound messages with status different than sent.

Rebase

Wed, Nov 13, 4:24 AM
angelika closed D13901: [lib] Do not reset a session when getting already decrypted message.
Wed, Nov 13, 4:17 AM
angelika closed D13900: [lib] Implement getInboundP2PMessagesByID in SQLiteAPI.
Wed, Nov 13, 4:17 AM
angelika committed rCOMM34c732abe671: [lib] Implement getInboundP2PMessagesByID in SQLiteAPI (authored by angelika).
[lib] Implement getInboundP2PMessagesByID in SQLiteAPI
Wed, Nov 13, 4:17 AM
angelika committed rCOMM5759f0fb35b6: [lib] Do not reset a session when getting already decrypted message (authored by angelika).
[lib] Do not reset a session when getting already decrypted message
Wed, Nov 13, 4:17 AM
angelika closed D13899: [native] Implement getInboundP2PMessagesByID query in JSI.
Wed, Nov 13, 4:17 AM
angelika closed D13898: [web] Implement getInboundP2PMessagesByID query on worker.
Wed, Nov 13, 4:17 AM
angelika committed rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI (authored by angelika).
[native] Implement getInboundP2PMessagesByID query in JSI
Wed, Nov 13, 4:17 AM
angelika committed rCOMM56ed820efec3: [web] Implement getInboundP2PMessagesByID query on worker (authored by angelika).
[web] Implement getInboundP2PMessagesByID query on worker
Wed, Nov 13, 4:17 AM
angelika closed D13897: [sqlite] Add getInboundP2PMessagesByID query.
Wed, Nov 13, 4:17 AM
angelika committed rCOMM224d94fb7a6e: [sqlite] Add getInboundP2PMessagesByID query (authored by angelika).
[sqlite] Add getInboundP2PMessagesByID query
Wed, Nov 13, 4:17 AM
tomek accepted D13914: [lib] Extract getSidebarItems.
Wed, Nov 13, 4:13 AM
tomek accepted D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.

Overall, this logic makes sense, but I think we should try to make it easier to understand.

Wed, Nov 13, 4:11 AM
tomek accepted D13912: [lib] Extract getLastUpdatedTime to a separate file.
Wed, Nov 13, 3:38 AM
tomek accepted D13911: [lib] Convert sidebarInfoSelector to a hook.
Wed, Nov 13, 3:37 AM
tomek accepted D13921: [lib] Move sidebarInfoSelector to different folder.
Wed, Nov 13, 3:29 AM
tomek accepted D13910: [lib] Inline getMostRecentMessageInfo.
Wed, Nov 13, 3:28 AM
kamil accepted D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().
Wed, Nov 13, 2:59 AM
kamil accepted D13908: [sqlite] Read Outbound messages with status different than sent.
Wed, Nov 13, 2:57 AM
kamil accepted D13905: [lib] Introduce a restore flow flag.
Wed, Nov 13, 2:45 AM
kamil closed D13904: [terraform] deploy backup 0.5.0 to prod.
Wed, Nov 13, 2:33 AM