issue: https://linear.app/comm/issue/ENG-5813/refactor-report-store-ops
We send reports to the report store, not the keyservers. So I will remove them on identity login / logout, not on keyserver login / logout / setNewSession.
Identity will be handled in ENG-6424
Details
Details
- Reviewers
michal kamil ginsu - Commits
- rCOMM819dda539dc2: [lib] Refactor report store reducer
Tested that reports are stll removed on logout
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 98 ↗ | (On Diff #35572) | This is actually unnecessary, if logInActionTypes or siweAuthActionTypes are used we know that !usingCommServicesAccessToken |
Comment Actions
As mentioned in other diffs, not sure we need to change anything for logOutActionTypes.success
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 88 | Weird to see deleteKeyserverAccountActionTypes.success contemplated only in a case where !usingCommServicesAccessToken... I assume it's only relevant in the opposite case. But presumably logic will be added past line 102 later? | |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 88 | As noted in the task, we don't want to be deleting reports when user disconnects from a keyserver, because the reports will be sent to the report service. So this is not really connected to keyservers, but to being logged in with identity | |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 88 | So reports will be deleted on identity logout / delete account. | |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 88 | I don't understand why deleteKeyserverAccountActionTypes.success is here. What happens if we remove it? Is it even possible to dispatch deleteKeyserverAccountActionTypes.success when !usingCommServicesAccessToken? | |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 88 | Is the reason because deleteKeyserverAccountActionTypes is used for both whole-app account deletion (when !usingCommServicesAccessToken), and single-keyserver account deletion (when usingCommServicesAccessToken)? If so, I think this is really confusing, and should be simplified. I think we should keep the deleteAccountActionTypes from before for whole-app login (identity + keyserver) – this is the same principle that we discussed for the old log out action. Meanwhile, we should probably introduce a new action (presumably this deleteKeyserverAccountActionTypes) that is used only for deleting your account from a single keyserver. | |
| lib/reducers/report-store-reducer.js | ||
|---|---|---|
| 94 ↗ | (On Diff #35921) | This condition can be lifted into the above condition |