Paths

Table of Contentst

Differential D10636

[lib] Refactor draft reducer
ClosedPublic
Actions

Authored by inka on Jan 15 2024, 9:05 AM.

Tags

None

Referenced Files

	F3370405: D10636.diff
	Tue, Nov 26, 2:28 AM

	Unknown Object (File)
	Tue, Nov 12, 3:28 PM

	Unknown Object (File)
	Mon, Nov 11, 1:28 AM

	Unknown Object (File)
	Fri, Nov 8, 12:03 AM

	Unknown Object (File)
	Thu, Nov 7, 7:55 PM

	Unknown Object (File)
	Thu, Nov 7, 5:45 AM

	Unknown Object (File)
	Thu, Nov 7, 4:33 AM

	Unknown Object (File)
	Wed, Nov 6, 1:15 PM

View All 86 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM1382d11ea838: [lib] Refactor draft reducer

Summary

issue: ENG-5812
We want to remove drafts of threads related to the keyservers the action was dispatched for

Test Plan

Ran the provided test, tested that when a user logs out the drafts are deleted

Diff Detail

Repository

Branch

inka/login_reducers

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 15 2024, 9:05 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 15 2024, 9:05 AM

inka added a parent revision: D10635: [lib][web][native] Make it possible to remove a subset of drafts.Jan 15 2024, 9:05 AM

Harbormaster completed remote builds in B25775: Diff 35638.Jan 15 2024, 9:24 AM

inka requested review of this revision.Jan 15 2024, 9:24 AM

inka edited the test plan for this revision. (Show Details)Jan 16 2024, 12:35 AM

michal accepted this revision.Jan 16 2024, 7:17 AM

This revision is now accepted and ready to land.Jan 16 2024, 7:17 AM

ashoat added inline comments.Jan 16 2024, 6:55 PM

lib/reducers/draft-reducer.js
50	As mentioned in other diffs, not sure we need to change anything for `logOutActionTypes.success`

We decided to have a single action for logging out of keyservers and identity.

Undo changes to logout

This revision is now accepted and ready to land.Jan 18 2024, 1:50 AM

inka requested review of this revision.Jan 18 2024, 1:51 AM

Harbormaster completed remote builds in B25877: Diff 35772.Jan 18 2024, 2:09 AM

ashoat added inline comments.Jan 20 2024, 8:20 PM

lib/reducers/draft-reducer.js
59 ↗	(On Diff #35772)	Why do we remove drafts from store on keyserver auth?

inka added inline comments.Jan 22 2024, 2:08 AM

lib/reducers/draft-reducer.js
59 ↗	(On Diff #35772)	We remove most data on keyserver login and set new session. I was mirroring this by removing data related to the keyserver the user has logged in to using `keyserverAuthActionTypes`. I can see that we don't remove drafts on `logInActionTypes`, but I think this is by accident? I don't see why would want to treat drafts differently than other data

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B25992: Diff 35924.Jan 22 2024, 3:50 AM

ashoat added inline comments.Jan 22 2024, 6:53 PM

lib/reducers/draft-reducer.js
59 ↗	(On Diff #35772)	Because drafts are local-only and are not provided by the keyserver on login. Let's avoid removing drafts from the store on keyserver auth

Don't remove drafts on keyserver auth

Harbormaster completed remote builds in B26070: Diff 36024.Jan 23 2024, 2:01 AM

inka added a child revision: D10796: [lib] Refactor set new session in entry, invite links, thread activity reducers.Jan 23 2024, 6:34 AM

inka added a child revision: D10794: [lib] Refactor set new session in calendar query/filters reducers.

inka removed a child revision: D10796: [lib] Refactor set new session in entry, invite links, thread activity reducers.

inka removed a child revision: D10794: [lib] Refactor set new session in calendar query/filters reducers.

inka added a child revision: D10647: [lib] Remove threads from calendar filters on logout.Jan 24 2024, 1:43 AM

ginsu accepted this revision.Jan 24 2024, 11:31 AM

This revision is now accepted and ready to land.Jan 24 2024, 11:31 AM

Closed by commit rCOMM1382d11ea838: [lib] Refactor draft reducer (authored by inka). · Explain WhyJan 29 2024, 8:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM1382d11ea838: [lib] Refactor draft reducer.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

draft-reducer.js

48 lines

draft-reducer.test.js

40 lines

Diff 35638

lib/reducers/draft-reducer.js

Loading...

lib/reducers/draft-reducer.test.js

Loading...