Paths
| Differential D7915 Authored by ginsu on May 22 2023, 7:07 AM.
Details Summary As part of the Hero redesign for the landing page we need to redesign our SubscriptionForm component. The focus of this diff is to change the language and visuals (color and layout by separating the input field from the button) shown on SubscriptionForm. Here is a screenshot of the Figma doc (please note that a subsequent diff will handle displaying the feedback text shown in the Figma)   Depends on D7914 Test Plan Please see the screenshots below: Desktop Normal:  Hover: Success Case:  Error Case:  Mobile View:  Tablet View: 
Diff Detail
Event TimelineHerald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 22 2023, 7:07 AM2023-05-22 07:07:46 (UTC-7) ginsu edited the summary of this revision. (Show Details)May 22 2023, 7:16 AM2023-05-22 07:16:39 (UTC-7) ginsu attached a referenced file: F551451: Screen Recording 2023-05-22 at 5.13.15 PM.mov. (Show Details) Harbormaster completed remote builds in B19603: Diff 26792.May 22 2023, 7:25 AM2023-05-22 07:25:13 (UTC-7) Comment Actions Can we set a minimum width on the button so it can fit Request Access/Requested!/Invalid Email/etc? That way the size of the input field and button won't "shift around" during different states This revision now requires changes to proceed.May 22 2023, 9:13 AM2023-05-22 09:13:29 (UTC-7) ginsu edited the test plan for this revision. (Show Details)May 31 2023, 9:11 AM2023-05-31 09:11:34 (UTC-7) Harbormaster completed remote builds in B19927: Diff 27302.May 31 2023, 9:27 AM2023-05-31 09:27:47 (UTC-7) This revision is now accepted and ready to land.May 31 2023, 1:13 PM2023-05-31 13:13:10 (UTC-7) Harbormaster completed remote builds in B21630: Diff 29676.Aug 8 2023, 1:43 PM2023-08-08 13:43:18 (UTC-7) Closed by commit rCOMMcc4eeea6c47d: [landing] redesign the subscription form component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM2023-08-08 14:08:40 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26792 landing/subscription-form.css
landing/subscription-form.react.js
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.