Page MenuHomePhabricator
Differential D8054

[landing] remove deprecated info blocks
ClosedPublic
Actions

Authored by ginsu on Jun 1 2023, 10:05 AM.
Tags
None
Referenced Files
F3407502: D8054.diff
Wed, Dec 4, 6:26 AM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sat, Nov 16, 11:27 PM
Unknown Object (File)
Oct 18 2024, 11:41 PM
Unknown Object (File)
Oct 17 2024, 3:05 AM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM96e67f405291: [landing] remove deprecated info blocks
Summary

Removing old info blocks since we will be replacing them with new info blocks in subsequent diffs.

Depends on D8039

Test Plan

Please see the demo videos to see that the old info blocks are no longer rendered:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 1 2023, 10:05 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 1 2023, 10:05 AM
ginsu added inline comments.Jun 1 2023, 10:07 AM
landing/app-landing.react.js
7 ↗(On Diff #27358)

Even though, there are currently no uses of InfoBlock we don't want to completely remove the component since the plan is to repurpose the component in a subsequent diff

ginsu edited the summary of this revision. (Show Details)Jun 1 2023, 10:08 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8039: [landing] add feedback text to subscription form component.
ginsu attached a referenced file: F567810: Screen Recording 2023-06-01 at 1.03.26 PM.mov. (Show Details)
ginsu added a child revision: D8055: [landing] rename asset to imageAsset.Jun 1 2023, 10:15 AM
Harbormaster completed remote builds in B19959: Diff 27358.Jun 1 2023, 10:23 AM
ginsu requested review of this revision.Jun 1 2023, 10:23 AM
atul accepted this revision.Jun 1 2023, 11:09 AM
This revision is now accepted and ready to land.Jun 1 2023, 11:09 AM
atul retitled this revision from [landing] remove depricated info blocks to [landing] remove deprecated info blocks.Jun 1 2023, 11:10 AM
ginsu updated this revision to Diff 29679.Aug 8 2023, 12:29 PM

rebase before landing

Harbormaster completed remote builds in B21633: Diff 29679.Aug 8 2023, 1:51 PM
Closed by commit rCOMM96e67f405291: [landing] remove deprecated info blocks (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM96e67f405291: [landing] remove deprecated info blocks.

Revision Contents
Changeset List

PathSize
landing/
17 lines
56 lines
85 lines

Diff 29679

View Options

landing/app-landing.react.js

Loading...
View Options

landing/asset-meta-data.js

Loading...
View Options

landing/landing.css

Loading...