[landing] redesign hero section layout
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 8:49 AM.

Details

Reviewers

atul
kamil

Commits

rCOMMdc0742ae24b0: [landing] redesign hero section layout

Summary

This diff redesigns the hero section to match the new designs shown in the figma document. In this diff we replaced the hero image and arranged the elements to match the designs. For the hero image, I did remove the purple blur background effect to make positioning the image easier; however, a subsequent diff will add those blur effects back in. For context here are the designs:

Screenshot 2023-06-02 at 11.51.24 AM.png (1×3 px, 2 MB)

Screenshot 2023-06-02 at 11.51.55 AM.png (1×3 px, 2 MB)

Depends on D8055

Test Plan

Please watch the demo video and see the screenshots below:

Desktop/Responsive behavior:

Tablet:

Screenshot 2023-06-02 at 11.45.10 AM.png (2×3 px, 1 MB)

Mobile:

Screenshot 2023-06-02 at 11.44.46 AM.png (2×3 px, 985 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 8:49 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 8:49 AM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 8:58 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a parent revision: D8055: [landing] rename asset to imageAsset.

Harbormaster completed remote builds in B19988: Diff 27402.Jun 2 2023, 9:06 AM

ginsu requested review of this revision.Jun 2 2023, 9:06 AM

Saw a css class that could be moved to a different file to improve readability

update

ginsu edited the test plan for this revision. (Show Details)Jun 2 2023, 11:33 AM

ginsu added reviewers: atul, kamil.

ginsu attached a referenced file: F569624: Screen Recording 2023-06-02 at 2.31.31 PM.mov. (Show Details)

ginsu attached a referenced file: F569426: Screenshot 2023-06-02 at 11.44.46 AM.png. (Show Details)

ginsu attached a referenced file: F569425: Screenshot 2023-06-02 at 11.45.10 AM.png. (Show Details)

ginsu attached a referenced file: F569417: Screen Recording 2023-06-02 at 11.44.15 AM.mov. (Show Details)

ginsu attached a referenced file: F569415: Screenshot 2023-06-02 at 11.51.55 AM.png. (Show Details)

ginsu attached a referenced file: F569416: Screenshot 2023-06-02 at 11.51.24 AM.png. (Show Details)

ginsu added inline comments.Jun 2 2023, 11:37 AM

landing/asset-meta-data.js
8–11 ↗	(On Diff #27410)	We don't need these fields anymore since we are directly adding them in the react component
15 ↗	(On Diff #27410)	Decided to keep this an array so that it would be easy to just append new image assets in the future; however, if we don't like this I can update the diff accordingly
landing/landing.css
52–53 ↗	(On Diff #27410)	These values were taken from figma