Page MenuHomePhabricator
Differential D8081

[landing] add all section components to AppLanding
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 1:16 PM.
Tags
None
Referenced Files
F3406281: D8081.diff
Wed, Dec 4, 1:17 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Thu, Nov 7, 10:59 AM
Unknown Object (File)
Mon, Nov 4, 10:50 AM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM128f78530e47: [landing] add all section components to AppLanding
Summary

Now that we have built all the components for each section. This diff just simply adds them to the AppLanding component.

Depends on D8080

Test Plan

Please see the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 1:16 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 1:16 PM
ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 1:18 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8080: [landing] introduce request access compoonent.
ginsu attached a referenced file: F569926: Screen Recording 2023-06-02 at 4.17.17 PM.mov. (Show Details)
ginsu added a child revision: D8082: [landing] remove subscription form from footer.Jun 2 2023, 1:29 PM
Harbormaster completed remote builds in B20002: Diff 27419.Jun 2 2023, 1:35 PM
ginsu requested review of this revision.Jun 2 2023, 1:35 PM
kamil accepted this revision.Jun 6 2023, 3:19 AM

New landing page looks awesome 🚀

This revision is now accepted and ready to land.Jun 6 2023, 3:19 AM
ginsu updated this revision to Diff 29687.Aug 8 2023, 12:33 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM128f78530e47: [landing] add all section components to AppLanding (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM128f78530e47: [landing] add all section components to AppLanding.
Harbormaster completed remote builds in B21641: Diff 29687.Aug 8 2023, 2:15 PM

Revision Contents
Changeset List

PathSize
landing/
10 lines

Diff 29757

View Options

landing/app-landing.react.js

Loading...