Page MenuHomePhabricator
Differential D8092

[landing] introduce keyserver faq data
ClosedPublic
Actions

Authored by ginsu on Jun 5 2023, 6:40 AM.
Tags
None
Referenced Files
F3406297: D8092.diff
Wed, Dec 4, 1:18 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM254b141a1d55: [landing] introduce keyserver faq data
Summary

introduce keyserver faq data. This copy was copy and pasted from DES-76

Depends on D8083

Test Plan

Please watch the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 5 2023, 6:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 6:40 AM
ginsu edited the summary of this revision. (Show Details)Jun 5 2023, 6:42 AM
ginsu added a parent revision: D8083: [landing] redesign footer component.
Harbormaster completed remote builds in B20019: Diff 27439.Jun 5 2023, 6:57 AM
ginsu requested review of this revision.Jun 5 2023, 6:57 AM
ginsu added a child revision: D8093: [landing] introduce keyserver faq component.Jun 5 2023, 7:02 AM
ginsu updated this revision to Diff 29600.Aug 7 2023, 2:05 PM

update copy

ginsu edited the summary of this revision. (Show Details)Aug 7 2023, 2:07 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F678481: Screen Recording 2023-08-07 at 4.51.29 PM.mov. (Show Details)
ginsu added inline comments.
landing/keyserver-faq-data.js
13 ↗(On Diff #29600)

In this linear comment, @ashoat and I talked about making answer a piece of JSX instead of just a string (which was what we originally had) so that we can easily embed links into the content

ginsu retitled this revision from DRAFT [landing] introduce keyserver faq data to [landing] introduce keyserver faq data.Aug 7 2023, 2:09 PM
Harbormaster completed remote builds in B21576: Diff 29600.Aug 7 2023, 2:25 PM
atul accepted this revision.Aug 7 2023, 10:35 PM
atul added inline comments.
landing/keyserver-faq.css
12–14 ↗(On Diff #29600)

Let's add the transition property here as well so that it fades in and out.

This revision is now accepted and ready to land.Aug 7 2023, 10:35 PM
ginsu updated this revision to Diff 29690.Aug 8 2023, 12:36 PM

rebase before landing

ginsu updated this revision to Diff 29691.Aug 8 2023, 12:43 PM

address comment

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM254b141a1d55: [landing] introduce keyserver faq data (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM254b141a1d55: [landing] introduce keyserver faq data.
Harbormaster completed remote builds in B21644: Diff 29690.Aug 8 2023, 2:24 PM
Harbormaster completed remote builds in B21645: Diff 29691.

Revision Contents
Changeset List

PathSize
landing/
90 lines
15 lines

Diff 29760

View Options

landing/keyserver-faq-data.js

Loading...
View Options

landing/keyserver-faq.css

Loading...