Page MenuHomePhabricator
Differential D8093

[landing] introduce keyserver faq component
ClosedPublic
Actions

Authored by ginsu on Jun 5 2023, 6:51 AM.
Tags
None
Referenced Files
F3406299: D8093.diff
Wed, Dec 4, 1:19 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Wed, Nov 6, 3:45 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMaa01c0500382: [landing] introduce keyserver faq component
Summary

This diff is the first part to introduce the keyserver faq component. The focus of this diff is to get the general structure/behavior of the keyserver faq. Subsequent diffs will handle other things like the animation and implementation of this component

Depends on D8092

Test Plan

Please see the demo video/screenshots below

Desktop/Responsive:

Tablet:

Screenshot 2023-06-05 at 10.00.18 AM.png (2×3 px, 903 KB)

Mobile:

Screenshot 2023-06-05 at 10.00.01 AM.png (2×3 px, 930 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 5 2023, 6:51 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 6:51 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 5 2023, 6:59 AM
Harbormaster failed remote builds in B20020: Diff 27440!
ginsu edited the summary of this revision. (Show Details)Jun 5 2023, 7:02 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8092: [landing] introduce keyserver faq data.
ginsu attached a referenced file: F572223: Screenshot 2023-06-05 at 10.00.01 AM.png. (Show Details)
ginsu attached a referenced file: F572222: Screenshot 2023-06-05 at 10.00.18 AM.png. (Show Details)
ginsu attached a referenced file: F572215: Screen Recording 2023-06-05 at 9.58.13 AM.mov. (Show Details)
ginsu requested review of this revision.Jun 5 2023, 8:06 AM
ginsu added a child revision: D8095: [landing] animate the keyserver faq section.Jun 5 2023, 1:04 PM
Harbormaster completed remote builds in B20020: Diff 27440.Jun 5 2023, 1:41 PM
atul accepted this revision.Jun 6 2023, 8:08 AM

Looks good, think we can skip classNames altogether for headingClassName though.

landing/keyserver-faq.react.js
13 ↗(On Diff #27440)

Do we need to be using classNames at all here?

This revision is now accepted and ready to land.Jun 6 2023, 8:08 AM
ginsu updated this revision to Diff 27591.Jun 9 2023, 12:03 PM

address feedback

Harbormaster completed remote builds in B20141: Diff 27591.Jun 9 2023, 12:20 PM
ginsu updated this revision to Diff 29692.Aug 8 2023, 12:44 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMMaa01c0500382: [landing] introduce keyserver faq component (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMaa01c0500382: [landing] introduce keyserver faq component.
Harbormaster completed remote builds in B21646: Diff 29692.Aug 8 2023, 2:28 PM

Revision Contents
Changeset List

PathSize
landing/
47 lines
66 lines

Diff 29692

View Options

landing/keyserver-faq.css

Loading...
View Options

landing/keyserver-faq.react.js

Loading...