Page MenuHomePhabricator
Differential D8170

[landing] reskin the team page
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 1:56 PM.
Tags
None
Referenced Files
F5110141: D8170.id27609.diff
Tue, Apr 1, 10:19 PM
F5109763: D8170.id.diff
Tue, Apr 1, 8:40 PM
F5104313: D8170.diff
Tue, Apr 1, 2:22 AM
Unknown Object (File)
Sat, Mar 29, 9:30 PM
Unknown Object (File)
Mar 2 2025, 12:34 AM
Unknown Object (File)
Feb 26 2025, 8:23 AM
Unknown Object (File)
Feb 26 2025, 4:24 AM
Unknown Object (File)
Feb 25 2025, 4:31 AM
View All 94 Files
Subscribers
ashoat
• ted
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM9799bbb4bd0f: [landing] reskin the team page
Summary

This diff updates the UI (typography/colors) for the team page. I worked closely with @ted on this, and made sure I got his stamp of approval.

Depends on D8169

Test Plan

Please see the demo videos below:

Desktop/Responsive:

Tablet:

Screenshot 2023-06-09 at 4.57.19 PM.png (2×3 px, 1 MB)

Mobile:

Screenshot 2023-06-09 at 4.57.12 PM.png (2×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 1:56 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 1:56 PM
ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 1:58 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8169: [landing] polish up hover effects.
ginsu attached a referenced file: F580878: Screenshot 2023-06-09 at 4.57.12 PM.png. (Show Details)
ginsu attached a referenced file: F580875: Screenshot 2023-06-09 at 4.57.19 PM.png. (Show Details)
ginsu attached a referenced file: F580866: Screen Recording 2023-06-09 at 4.56.47 PM.mov. (Show Details)
ginsu added a child revision: D8171: [landing] reskin investors page.Jun 9 2023, 2:17 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2023, 2:22 PM
Harbormaster failed remote builds in B20159: Diff 27609!
Harbormaster completed remote builds in B20159: Diff 27609.Jun 9 2023, 2:38 PM
ginsu requested review of this revision.Jun 9 2023, 2:38 PM
kamil accepted this revision.Jun 12 2023, 2:59 AM
This revision is now accepted and ready to land.Jun 12 2023, 2:59 AM
ginsu updated this revision to Diff 29701.Aug 8 2023, 12:52 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM9799bbb4bd0f: [landing] reskin the team page (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9799bbb4bd0f: [landing] reskin the team page.
Harbormaster completed remote builds in B21655: Diff 29701.Aug 8 2023, 2:55 PM

Revision Contents
Changeset List

PathSize
landing/
10 lines
5 lines
27 lines
11 lines

Diff 27609

View Options

landing/team-profile.css

#pragma once #pragma once
#include "BlobGetClientReactor.h" #include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include <blob.grpc.pb.h>
#include "../_generated/blob.pb.h" #include <blob.pb.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
Show All 36 Lines
View Options

landing/team-profile.react.js

#pragma once #pragma once
#include "BlobGetClientReactor.h" #include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include <blob.grpc.pb.h>
#include "../_generated/blob.pb.h" #include <blob.pb.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
Show All 36 Lines
View Options

landing/team.css

#pragma once #pragma once
#include "BlobGetClientReactor.h" #include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include <blob.grpc.pb.h>
#include "../_generated/blob.pb.h" #include <blob.pb.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
Show All 36 Lines
View Options

landing/team.react.js

#pragma once #pragma once
#include "BlobGetClientReactor.h" #include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include <blob.grpc.pb.h>
#include "../_generated/blob.pb.h" #include <blob.pb.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
Show All 36 Lines