Page MenuHomePhabricator
Differential D8172

[landing] make all external links open in a new tab
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 2:21 PM.
Tags
None
Referenced Files
F3407141: D8172.id27699.diff
Wed, Dec 4, 4:12 AM
Unknown Object (File)
Mon, Dec 2, 3:52 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sun, Nov 17, 1:39 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM39447e4b8e94: [landing] make all external links open in a new tab
Summary

Based on some feedback I got in D8083, we should have the external links in the landing page open up a new tab

Depends on D8171

Test Plan

Verified that every link opens up in a new tab like this:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 2:21 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 2:21 PM
ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 2:22 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8171: [landing] reskin investors page.
ginsu attached a referenced file: F581231: Screen Recording 2023-06-09 at 5.21.21 PM.mov. (Show Details)
ginsu mentioned this in D8083: [landing] redesign footer component.Jun 9 2023, 2:24 PM
Harbormaster completed remote builds in B20162: Diff 27612.Jun 9 2023, 2:40 PM
ginsu requested review of this revision.Jun 9 2023, 2:40 PM
ginsu added a child revision: D8173: [landing] make typography responsive.Jun 9 2023, 3:08 PM
kamil accepted this revision.Jun 12 2023, 3:35 AM
kamil added inline comments.
landing/footer.react.js
71 ↗(On Diff #27612)

As far as I know, this usually goes with rel="noreferrer" for safety reasons to protect against tabnabbing.

I recently heard that most browsers add this automatically, but I'm not sure how trusted this is.

This revision is now accepted and ready to land.Jun 12 2023, 3:35 AM
ginsu updated this revision to Diff 27699.Jun 13 2023, 11:57 AM

address comments

Harbormaster completed remote builds in B20221: Diff 27699.Jun 13 2023, 12:17 PM
ginsu updated this revision to Diff 29703.Aug 8 2023, 12:52 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM39447e4b8e94: [landing] make all external links open in a new tab (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM39447e4b8e94: [landing] make all external links open in a new tab.
Harbormaster completed remote builds in B21657: Diff 29703.Aug 8 2023, 3:00 PM

Revision Contents
Changeset List

Diff 29703

View Options

landing/feature-modal.react.js

Loading...
View Options

landing/footer.react.js

Loading...
View Options

landing/header.react.js

Loading...
View Options

landing/mobile-nav.react.js

Loading...