Page MenuHomePhabricator
Differential D8176

[landing] fix size prop for icons in mobile nav
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 3:37 PM.
Tags
None
Referenced Files
F3406616: D8176.id27627.diff
Wed, Dec 4, 2:32 AM
F3406615: D8176.id.diff
Wed, Dec 4, 2:32 AM
F3406614: D8176.diff
Wed, Dec 4, 2:31 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMd568c898c615: [landing] fix size prop for icons in mobile nav
Summary

As I was debugging D8175, I noticed in the console that I was getting error logs because I accidentally passed the wrong size prop into the icons in the mobile nav component. This diff fixes that issue

Depends on D8175

Test Plan

The error message is now gone, and the icons are still the same size

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 3:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 3:37 PM
ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 3:38 PM
ginsu added a parent revision: D8175: [landing] fix the scroll to top behavior and animation on keyserver page.
ginsu added reviewers: atul, kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2023, 3:45 PM
Harbormaster failed remote builds in B20168: Diff 27627!
Harbormaster completed remote builds in B20168: Diff 27627.Jun 9 2023, 3:56 PM
ginsu requested review of this revision.Jun 9 2023, 3:56 PM
atul accepted this revision.Jun 12 2023, 7:38 AM
This revision is now accepted and ready to land.Jun 12 2023, 7:38 AM
ginsu added a child revision: D8477: [landing] clean up competitor comparison UI.Jul 11 2023, 1:37 PM
ginsu updated this revision to Diff 29709.Aug 8 2023, 12:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMMd568c898c615: [landing] fix size prop for icons in mobile nav (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd568c898c615: [landing] fix size prop for icons in mobile nav.
Harbormaster completed remote builds in B21663: Diff 29709.Aug 8 2023, 3:19 PM

Revision Contents
Changeset List

PathSize
landing/
4 lines

Diff 27627

View Options

landing/mobile-nav.react.js

Loading...