Custom storage for redux-persist
This diff does not add transition from old to new engine - this is more complicated problem
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/redux/comm-redux-storage-engine.js | ||
|---|---|---|
| 7 ↗ | (On Diff #24210) | Would this be cleaner as an async function? getItem: async (key: string): Promise<string> => { const res = await databaseModule.schedule({ type: workerRequestMessageTypes.GET_PERSIST_STORAGE_ITEM, key, }); if (typeof res?.item !== 'string') { throw new Error('Wrong type returned for storage item'); } return res.item; }, |
| 26–55 ↗ | (On Diff #24210) | Seems like these too can be async functions |
Comment Actions
use implicit promises
| web/redux/comm-redux-storage-engine.js | ||
|---|---|---|
| 7 ↗ | (On Diff #24210) | I tried to explicitly return a promise and match the current web storage interface, but I agree it's cleaner as you suggested |