Differential D7787

[web-db] stop supporting Safari
ClosedPublic
Actions

Authored by kamil on May 11 2023, 12:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 16, 5:51 AM

	Unknown Object (File)
	Sat, Mar 8, 5:54 PM

	Unknown Object (File)
	Fri, Mar 7, 9:49 PM

	Unknown Object (File)
	Fri, Mar 7, 9:49 PM

	Unknown Object (File)
	Fri, Mar 7, 9:49 PM

	Unknown Object (File)
	Fri, Mar 7, 9:48 PM

	Unknown Object (File)
	Fri, Mar 7, 9:44 PM

	Unknown Object (File)
	Feb 25 2025, 4:15 AM

Subscribers

Tokens

"Heartbreak" token, awarded by atul.

Details

Reviewers

tomek
michal

Commits

rCOMMa0f5b4115446: [web-db] stop supporting Safari

Summary

Context in ENG-3872. Stop supportig Safari until we will fix the issue.

Test Plan

Check is persistence on Safari works in the old way

Diff Detail

Repository

Branch

web-db-3

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 11 2023, 12:03 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 11 2023, 12:03 AM

Harbormaster completed remote builds in B19259: Diff 26361.May 11 2023, 12:22 AM

remove wrongly commited code

kamil added a child revision: D7191: [web-db] implement clearing sensitive data.May 11 2023, 1:55 AM

kamil published this revision for review.May 11 2023, 1:57 AM

atul awarded a token.May 11 2023, 2:03 AM

Harbormaster completed remote builds in B19260: Diff 26362.May 11 2023, 2:06 AM

michal accepted this revision.May 11 2023, 2:14 AM

This revision is now accepted and ready to land.May 11 2023, 2:14 AM

Closed by commit rCOMMa0f5b4115446: [web-db] stop supporting Safari (authored by kamil). · Explain WhyMay 11 2023, 4:02 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa0f5b4115446: [web-db] stop supporting Safari.

Revision Contents
Changeset List

Path

Size

web/

database/

utils/

1 line

Diff 26362

web/database/utils/constants.js

	Show First 20 Lines • Show All 237 Lines • ▼ Show 20 Lines		if (rescindErrorMessage.size()) {
	addObject:[NSString			addObject:[NSString
	stringWithUTF8String:persistErrorMessage.c_str()]];			stringWithUTF8String:persistErrorMessage.c_str()]];
	}			}

	publicUserContent = [[UNNotificationContent alloc] init];			publicUserContent = [[UNNotificationContent alloc] init];
	}			}

	// Step 5: (optional) execute notification coalescing			// Step 5: (optional) execute notification coalescing
	if ([self isCollapsible:content.userInfo]) {			if ([self isCollapsible:content.userInfo] &&
				!content.userInfo[needsSilentBadgeUpdateKey]) {
	std::string coalescingErrorMessage;			std::string coalescingErrorMessage;
	try {			try {
	@try {			@try {
	[self displayLocalNotificationFromContent:content			[self displayLocalNotificationFromContent:content
	forCollapseKey:content			forCollapseKey:content
	.userInfo[collapseIDKey]];			.userInfo[collapseIDKey]];
	} @catch (NSException *e) {			} @catch (NSException *e) {
	coalescingErrorMessage =			coalescingErrorMessage =
	▲ Show 20 Lines • Show All 700 Lines • Show Last 20 Lines