Paths

Table of Contentst

Differential D7915

[landing] redesign the subscription form component
ClosedPublic
Actions

Authored by ginsu on May 22 2023, 7:07 AM.

Tags

None

Referenced Files

	F3449266: D7915.id29676.diff
	Thu, Dec 12, 11:07 AM

	Unknown Object (File)
	Wed, Dec 4, 3:12 PM

	Unknown Object (File)
	Wed, Dec 4, 6:03 AM

	Unknown Object (File)
	Sun, Nov 17, 2:19 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 1:38 AM

View All 97 Files

Subscribers

Details

Reviewers

atul
kamil

Commits

rCOMMcc4eeea6c47d: [landing] redesign the subscription form component

Summary

As part of the Hero redesign for the landing page we need to redesign our SubscriptionForm component. The focus of this diff is to change the language and visuals (color and layout by separating the input field from the button) shown on SubscriptionForm. Here is a screenshot of the Figma doc (please note that a subsequent diff will handle displaying the feedback text shown in the Figma)

Screenshot 2023-05-22 at 5.10.49 PM.png (2×3 px, 2 MB)

Screenshot 2023-05-22 at 5.10.53 PM.png (2×3 px, 2 MB)

Depends on D7914

Test Plan

Please see the screenshots below:

Desktop Normal:

Screenshot 2023-05-22 at 5.12.39 PM.png (2×3 px, 1 MB)

Hover:

Success Case:

Screenshot 2023-05-22 at 5.13.49 PM.png (2×3 px, 1 MB)

Error Case:

Screenshot 2023-05-22 at 5.13.59 PM.png (2×3 px, 1 MB)

Mobile View:

Screenshot 2023-05-31 at 12.10.45 PM.png (2×3 px, 904 KB)

Tablet View:

Screenshot 2023-05-31 at 12.10.37 PM.png (2×3 px, 943 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 22 2023, 7:07 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 22 2023, 7:07 AM

ginsu edited the summary of this revision. (Show Details)May 22 2023, 7:16 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D7914: [landing] remove react-text-loop dependency.

ginsu attached a referenced file: F551458: Screenshot 2023-05-22 at 5.15.40 PM.png. (Show Details)

ginsu attached a referenced file: F551457: Screenshot 2023-05-22 at 5.15.23 PM.png. (Show Details)

ginsu attached a referenced file: F551454: Screenshot 2023-05-22 at 5.13.59 PM.png. (Show Details)

ginsu attached a referenced file: F551453: Screenshot 2023-05-22 at 5.13.49 PM.png. (Show Details)

ginsu attached a referenced file: F551451: Screen Recording 2023-05-22 at 5.13.15 PM.mov. (Show Details)

ginsu attached a referenced file: F551450: Screenshot 2023-05-22 at 5.12.39 PM.png. (Show Details)

ginsu attached a referenced file: F551449: Screenshot 2023-05-22 at 5.10.53 PM.png. (Show Details)

ginsu attached a referenced file: F551448: Screenshot 2023-05-22 at 5.10.49 PM.png. (Show Details)

ginsu added a child revision: D7917: [landing] fix css class names for subscription form component.May 22 2023, 7:21 AM

Harbormaster completed remote builds in B19603: Diff 26792.May 22 2023, 7:25 AM

ginsu requested review of this revision.May 22 2023, 7:25 AM

Can we set a minimum width on the button so it can fit Request Access/Requested!/Invalid Email/etc?

That way the size of the input field and button won't "shift around" during different states

This revision now requires changes to proceed.May 22 2023, 9:13 AM

address comments

ginsu edited the test plan for this revision. (Show Details)May 31 2023, 9:11 AM

ginsu attached a referenced file: F566247: Screenshot 2023-05-31 at 12.10.37 PM.png. (Show Details)

ginsu attached a referenced file: F566246: Screenshot 2023-05-31 at 12.10.45 PM.png. (Show Details)

Harbormaster completed remote builds in B19927: Diff 27302.May 31 2023, 9:27 AM

ginsu added a child revision: D8039: [landing] add feedback text to subscription form component.May 31 2023, 9:28 AM

atul accepted this revision.May 31 2023, 1:13 PM

This revision is now accepted and ready to land.May 31 2023, 1:13 PM

ginsu removed a child revision: D8039: [landing] add feedback text to subscription form component.Jun 1 2023, 10:10 AM

rebase before landing

Harbormaster completed remote builds in B21630: Diff 29676.Aug 8 2023, 1:43 PM

Closed by commit rCOMMcc4eeea6c47d: [landing] redesign the subscription form component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMcc4eeea6c47d: [landing] redesign the subscription form component.

Revision Contents
Changeset List

Path

Size

landing/

subscription-form.css

66 lines

subscription-form.react.js

14 lines

Diff 26792

landing/subscription-form.css

Loading...

landing/subscription-form.react.js

Loading...