Page MenuHomePhabricator

[landing] introduce keyserver faq data
ClosedPublic

Authored by ginsu on Jun 5 2023, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 2:28 PM
Unknown Object (File)
Wed, Apr 2, 4:22 AM
Unknown Object (File)
Tue, Apr 1, 5:09 PM
Unknown Object (File)
Tue, Apr 1, 2:12 PM
Unknown Object (File)
Tue, Apr 1, 12:39 PM
Unknown Object (File)
Tue, Apr 1, 10:02 AM
Unknown Object (File)
Mon, Mar 31, 11:37 PM
Unknown Object (File)
Mon, Mar 31, 10:19 PM
Subscribers

Details

Summary

introduce keyserver faq data. This copy was copy and pasted from DES-76

Depends on D8083

Test Plan

Please watch the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Jun 5 2023, 6:57 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added inline comments.
landing/keyserver-faq-data.js
13 ↗(On Diff #29600)

In this linear comment, @ashoat and I talked about making answer a piece of JSX instead of just a string (which was what we originally had) so that we can easily embed links into the content

ginsu retitled this revision from DRAFT [landing] introduce keyserver faq data to [landing] introduce keyserver faq data.Aug 7 2023, 2:09 PM
atul added inline comments.
landing/keyserver-faq.css
12–14 ↗(On Diff #29600)

Let's add the transition property here as well so that it fades in and out.

This revision is now accepted and ready to land.Aug 7 2023, 10:35 PM
This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
This revision was automatically updated to reflect the committed changes.