Page MenuHomePhabricator

[services-lib] Introduce Blob Client
ClosedPublic

Authored by bartek on Aug 10 2023, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 11:29 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Oct 13 2024, 8:20 AM
Unknown Object (File)
Oct 2 2024, 6:57 PM
Unknown Object (File)
Oct 2 2024, 5:30 PM
Unknown Object (File)
Oct 2 2024, 5:01 PM
Unknown Object (File)
Oct 2 2024, 12:47 AM
Unknown Object (File)
Sep 28 2024, 7:33 PM
Subscribers

Details

Summary

Part of ENG-4597.

This diff introduces a foundation for blob client in comm-services-lib. The client is hidden behind a crate feature so services that do not need it do not have to depend on it (e.g. feature-flags).

Test Plan

Cargo build in comm-services-lib, blob and feature-flags.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.

Fix Cargo.lock dependencies in services

services/backup/Cargo.lock
592

These files changed because I added the dependency to the lib

services/comm-services-lib/src/blob/client.rs
1

Will be removed in the next diff

47–50

This is the place where the authorization token will be stored and managed.

services/comm-services-lib/src/blob/mod.rs
1–2

This is the first submodule, but there will be more added later

bartek published this revision for review.Aug 11 2023, 2:19 AM

This will be very useful! I would prefer to have multiple packages in comm-services-lib/ (comm-services-lib/database-utils/, comm-services-lib/blob-client), but I don't really have strong argument against using features for this.

This revision is now accepted and ready to land.Aug 11 2023, 4:11 AM
This revision was automatically updated to reflect the committed changes.