services/comm-services-lib/src/auth.rs
26–29	Nit: maybe let's import `Engine` and `BASE64_STANDARD` at the top
28	I wonder if we should `expect` here and simplify the return type because I don't think if error happens here we could recover in any way that makes sense? `UserIdentity` should be serializable in all cases.

michal added inline comments.Aug 16 2023, 3:19 AM

services/comm-services-lib/src/auth.rs
5–10	Fields need to be public so other users can create this

Rebase, make with_user_identity() clone the client

Harbormaster completed remote builds in B22071: Diff 30296.Aug 25 2023, 1:19 AM

bartek added a child revision: D8951: [reports-service] Add authenticated service.Aug 25 2023, 8:33 AM

Rebase on latest changes

Harbormaster completed remote builds in B22119: Diff 30353.Aug 26 2023, 8:14 AM

bartek published this revision for review.Aug 28 2023, 2:32 AM

bartek added a child revision: D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 28 2023, 4:06 AM

michal accepted this revision.Aug 29 2023, 5:35 AM

This revision is now accepted and ready to land.Aug 29 2023, 5:35 AM

Closed by commit rCOMM9f320c1860a2: [services-lib] Add HTTP client auth support (authored by bartek). · Explain WhyAug 29 2023, 8:04 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9f320c1860a2: [services-lib] Add HTTP client auth support.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob/

comm-services-lib/

13 lines

src/

auth.rs

32 lines

blob/

client.rs

68 lines

lib.rs

1 line

feature-flags/

Cargo.lock

Diff 29829

View Options

services/backup/Cargo.lock

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

View Options

services/blob/Cargo.lock

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

View Options

services/comm-services-lib/Cargo.lock

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

View Options

services/comm-services-lib/Cargo.toml

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines