Page MenuHomePhabricator
Differential D8779

[services-lib] Add method to upload blobs
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 7:42 PM
Unknown Object (File)
Sat, Dec 14, 7:42 PM
Unknown Object (File)
Sat, Dec 14, 7:42 PM
Unknown Object (File)
Sat, Dec 14, 7:41 PM
Unknown Object (File)
Sat, Dec 14, 7:30 PM
Unknown Object (File)
Sat, Dec 14, 12:23 AM
Unknown Object (File)
Mon, Nov 25, 7:01 PM
Unknown Object (File)
Mon, Nov 25, 11:28 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs
Summary

Part of ENG-4597.

Added a function that takes a stream as an argument and uploads the data to blob service.

Depends on D8778

Test Plan

Tested together with next diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 10 2023, 10:20 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 10:20 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
bartek added a child revision: D8780: [services-lib] Add methods to manage blob holders.Aug 10 2023, 10:27 AM
Harbormaster completed remote builds in B21695: Diff 29819.Aug 10 2023, 10:37 AM
bartek added inline comments.Aug 10 2023, 3:49 PM
services/comm-services-lib/src/blob/client.rs
140–142 ↗(On Diff #29819)

Requirements of the reqwest body stream:
A stream of Result<impl Into<Vec<u8>>, impl Into<Box<dyn Error>>>

bartek published this revision for review.Aug 11 2023, 2:20 AM
michal accepted this revision.Aug 11 2023, 4:35 AM
michal added inline comments.
services/comm-services-lib/src/blob/client.rs
144 ↗(On Diff #29819)

Wrong message?

This revision is now accepted and ready to land.Aug 11 2023, 4:35 AM
bartek updated this revision to Diff 29947.Aug 16 2023, 6:46 AM

Fix wrong log message

Harbormaster completed remote builds in B21792: Diff 29947.Aug 16 2023, 7:05 AM
Closed by commit rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs (authored by bartek). · Explain WhyAug 16 2023, 7:25 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs.

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
src/
blob/
59 lines

Diff 29947

View Options

services/comm-services-lib/src/blob/client.rs

Loading...