[services-lib] Add BlobInfo utility type
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 3:47 PM.

Details

Reviewers

michal
• jon

Commits

rCOMM57ec708cd366: [services-lib] Add BlobInfo utility type

Summary

Adds a type that represents the information of an owned blob. This is useful for storing the blob reference in DDB

Depends on D8777, D8790

Test Plan

Tested later with real usage.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 10 2023, 3:47 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 3:47 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B21709: Diff 29834.Aug 10 2023, 4:04 PM

bartek published this revision for review.Aug 11 2023, 2:27 AM

michal accepted this revision.Aug 11 2023, 4:14 AM

michal added inline comments.

services/comm-services-lib/src/blob/types.rs
17–18 ↗	(On Diff #29834)	Nit: maybe add constants for these two values?

This revision is now accepted and ready to land.Aug 11 2023, 4:14 AM

Extract constants

Harbormaster completed remote builds in B21797: Diff 29952.Aug 16 2023, 7:19 AM

Closed by commit rCOMM57ec708cd366: [services-lib] Add BlobInfo utility type (authored by bartek). · Explain WhyAug 16 2023, 7:26 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM57ec708cd366: [services-lib] Add BlobInfo utility type.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

blob/

mod.rs

1 line

types.rs

54 lines

Diff 29952

View Options

services/comm-services-lib/src/blob/mod.rs