Page MenuHomePhabricator
Differential D8786

[services-lib] Add HTTP client auth support
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 3:29 PM.
Tags
None
Referenced Files
F3188386: D8786.diff
Fri, Nov 8, 6:42 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Wed, Oct 16, 3:10 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMM9f320c1860a2: [services-lib] Add HTTP client auth support
Summary

A proof of concept on how "User Identity" a.k.a commServicesAccessToken can be used with blob client

Depends on D8780.

Test Plan

TBD

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 10 2023, 3:29 PM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 3:29 PM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
bartek edited the summary of this revision. (Show Details)Aug 10 2023, 3:33 PM
bartek added a parent revision: D8780: [services-lib] Add methods to manage blob holders.
bartek removed a parent revision: D8777: [services-lib] Introduce Blob Client.
Harbormaster completed remote builds in B21704: Diff 29829.Aug 10 2023, 3:46 PM
bartek added inline comments.Aug 10 2023, 3:48 PM
services/comm-services-lib/src/blob/client.rs
327 ↗(On Diff #29829)

I'll change this expect to real error type later

michal added inline comments.Aug 11 2023, 4:58 AM
services/comm-services-lib/src/auth.rs
26–29 ↗(On Diff #29829)

Nit: maybe let's import Engine and BASE64_STANDARD at the top

28 ↗(On Diff #29829)

I wonder if we should expect here and simplify the return type because I don't think if error happens here we could recover in any way that makes sense? UserIdentity should be serializable in all cases.

michal added inline comments.Aug 16 2023, 3:19 AM
services/comm-services-lib/src/auth.rs
5–10 ↗(On Diff #29829)

Fields need to be public so other users can create this

bartek updated this revision to Diff 30296.Aug 25 2023, 1:01 AM

Rebase, make with_user_identity() clone the client

Harbormaster completed remote builds in B22071: Diff 30296.Aug 25 2023, 1:19 AM
bartek added a child revision: D8951: [reports-service] Add authenticated service.Aug 25 2023, 8:33 AM
bartek updated this revision to Diff 30353.Aug 26 2023, 7:56 AM

Rebase on latest changes

Harbormaster completed remote builds in B22119: Diff 30353.Aug 26 2023, 8:14 AM
bartek published this revision for review.Aug 28 2023, 2:32 AM
bartek added a child revision: D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 28 2023, 4:06 AM
michal accepted this revision.Aug 29 2023, 5:35 AM
This revision is now accepted and ready to land.Aug 29 2023, 5:35 AM
Closed by commit rCOMM9f320c1860a2: [services-lib] Add HTTP client auth support (authored by bartek). · Explain WhyAug 29 2023, 8:04 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9f320c1860a2: [services-lib] Add HTTP client auth support.

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
src/
blob/
84 lines

Diff 30353

View Options

services/comm-services-lib/src/blob/client.rs

Loading...