[reports-service] Introduce e-mail template
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 11:02 PM.

Details

Reviewers

michal
• patryk
• jon
tomek

Commits

rCOMM8a4cb8ffa67b: [reports-service] Introduce e-mail template

Summary

This diff introduces HTML templates using Maud library, which allows to rendering HTML using Rust macros.
The templates will be used to render HTML e-mails for reports.
Also included some base HTML page layout (the <html>, <head>, <body> tags) along with some basic CSS styling.

Depends on D8980

Test Plan

Created a temporary HTTP endpoint that renders HTML and opened it in the browser.
Screenshots of the final result in D8988

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 28 2023, 11:02 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 11:02 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8984: [reports-service] E-mail subject and summary text.Aug 28 2023, 11:03 PM

Harbormaster completed remote builds in B22184: Diff 30460.Aug 28 2023, 11:21 PM

bartek edited the summary of this revision. (Show Details)Aug 29 2023, 12:17 AM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Aug 29 2023, 12:21 AM

Adding @tomek because of new dependency

services/reports/src/email/template/mod.rs
43–49	Should we also add `stateVersion`?

This revision is now accepted and ready to land.Aug 29 2023, 9:19 AM

michal added 1 blocking reviewer(s): tomek.Aug 30 2023, 1:53 AM

This revision now requires review to proceed.Aug 30 2023, 1:53 AM

The dependency looks ok - has an appropriate license, is maintained, and doesn't have serious issues open. It also seems convenient to use, so it's probably not worth it to search for possible alternatives.

This revision is now accepted and ready to land.Aug 30 2023, 2:17 AM

Closed by commit rCOMM8a4cb8ffa67b: [reports-service] Introduce e-mail template (authored by bartek). · Explain WhySep 3 2023, 11:41 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8a4cb8ffa67b: [reports-service] Introduce e-mail template.