If we're fully deprecating non-Nix workflow we can probably add cmake-lint to Nix and bring back this diff?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 12 2023
Mar 12 2023
atul updated the test plan for D7048: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`.
atul updated the test plan for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
update after fix + rebase
atul updated the diff for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
fix signedIdentityKeysBlobSelector after testing
atul updated the test plan for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
atul published D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm` for review.
ashoat added inline comments to D7046: [lib] Add test of ENS avatar set to NFT which is an SVG data URI.
with the data URI I don't think it really matters
Thanks for including unit tests
Some questions inline
ashoat requested review of D7039: [lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress.
Mar 11 2023
Mar 11 2023
atul updated the diff for D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
rebase and land
atul updated the test plan for D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
atul added a comment to D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is correctly constructed and received by keyserver.
land
See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is properly constructed and received by keyserver.
atul added inline comments to D7035: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`.
include call to commCoreModule.initializeCryptoAccount(...)
rebase and land
Haven't done this yet, will test before landing.
Update to 3.2.14; respond to review
Mar 10 2023
Mar 10 2023
atul requested changes to D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Are we still waiting on D6924 before the rest of the stack is ready for review? Back to your queue for now, feel free to re-request review as-is if I should be reviewing it.
Are we still waiting on D6924 before the rest of the stack is ready for review? Back to your queue for now, feel free to re-request review as-is if I should be reviewing it.
atul requested changes to D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
I'm going to wait until the architecture of pinned_messages is decided in D6924 before requesting review, I just put this up so I could continue working locally.
Unit tests will be added in next diff.
Accepting since a lot of the feedback was captured in the iOS diffs.
rebase and land
ashoat requested review of D7033: [keyserver] Give all members permissions to add users to a community.
I agree with @varun
In D7020#208568, @varun wrote:i frankly don't think this adds much clutter at all... also it's more tedious for me to switch between diffs to see how these dependencies are being used. just looking at this diff, i have no idea what any of these dependencies are for besides the one that @jon annotated, and even then i still have to look at another diff to see what handle_pake_to_grpc_err looks like. the lack of context in this diff makes it difficult to determine if a given dependency is appropriate or propose an alternative.