Page MenuHomePhorge
Feed Search

Jun 6 2023

atul accepted D8068: [native] Refactor the members list to support any variety of role labels.

Code change looks fine

Jun 6 2023, 3:20 PM
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.

I could alternatively define roleName outside the scope of this memo and then put it in the dependency array

Jun 6 2023, 3:15 PM
atul accepted D8093: [landing] introduce keyserver faq component.

Looks good, think we can skip classNames altogether for headingClassName though.

Jun 6 2023, 3:08 PM
atul accepted D8087: [native] Fix userInfo calculation in UserAvatar.
Jun 6 2023, 2:53 PM

Jun 5 2023

atul accepted D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.
Jun 5 2023, 2:36 PM
atul accepted D8089: [native] Rename accountSelections to accountSelection.
Jun 5 2023, 2:36 PM

Jun 2 2023

atul accepted D8079: [landing] repurpose InfoBlock component.
Jun 2 2023, 10:09 PM
atul accepted D8077: [landing] move hero section code into own component.

Looks like a straightforward move

Jun 2 2023, 7:22 PM
atul accepted D8076: [landing] introduce glow effect for hero image.

Looks good overall, might be worth trying box-shadow instead of blur if it's easy... but feel free to land as-is if it takes too long to investigate + achieve the same effect

Jun 2 2023, 7:21 PM
atul attached a referenced file: F569756: a3351f.png.
Jun 2 2023, 7:19 PM
atul added inline comments to D8076: [landing] introduce glow effect for hero image.
Jun 2 2023, 7:19 PM
atul added a comment to D8076: [landing] introduce glow effect for hero image.

Maybe glow instead of blur? Kind of associate blur with being some sort of "filter" "above" some other content

Jun 2 2023, 7:17 PM
atul accepted D8075: [landing] redesign hero section layout.

Looks good

Jun 2 2023, 7:14 PM
atul closed D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers`.
Jun 2 2023, 5:42 PM
atul committed rCOMM414dbe4650a0: [native] Pass whether created community is `ANNOUNCEMENT` to….
Jun 2 2023, 5:42 PM
atul closed D8057: [native] Introduce `CommunityCreationContentContainer` component.
Jun 2 2023, 4:20 PM
atul committed rCOMM3f6313aefb49: [native] Introduce `CommunityCreationContentContainer` component.
Jun 2 2023, 4:20 PM
atul added inline comments to D8057: [native] Introduce `CommunityCreationContentContainer` component.
Jun 2 2023, 4:16 PM
atul updated the diff for D8057: [native] Introduce `CommunityCreationContentContainer` component.

addressed feedback

Jun 2 2023, 4:15 PM
atul updated the diff for D8057: [native] Introduce `CommunityCreationContentContainer` component.

rebase before addressing feedback

Jun 2 2023, 4:09 PM
atul closed D8056: [native] Barebones user selection in `CommunityCreationMembers`.
Jun 2 2023, 4:03 PM
atul committed rCOMM9a3b372c57b2: [native] Barebones user selection in `CommunityCreationMembers`.
Jun 2 2023, 4:03 PM
atul updated the diff for D8056: [native] Barebones user selection in `CommunityCreationMembers`.

rebase and land

Jun 2 2023, 3:54 PM
atul added a comment to D8056: [native] Barebones user selection in `CommunityCreationMembers`.
In D8056#239034, @atul wrote:

I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.

That would be great

Jun 2 2023, 3:53 PM

Jun 1 2023

atul published D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers` for review.
Jun 1 2023, 8:44 PM
atul added a comment to D8056: [native] Barebones user selection in `CommunityCreationMembers`.

Do we really need another low-level component for this? Don't we have something we can reuse? If not, can't we refactor something / make it generic, rather than implementing a new one of these?

Jun 1 2023, 8:43 PM
atul requested review of D8057: [native] Introduce `CommunityCreationContentContainer` component.
Jun 1 2023, 8:35 PM
atul requested review of D8056: [native] Barebones user selection in `CommunityCreationMembers`.
Jun 1 2023, 8:33 PM
atul accepted D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
Jun 1 2023, 6:35 PM
atul accepted D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Jun 1 2023, 6:35 PM
atul accepted D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Jun 1 2023, 6:23 PM
atul accepted D8049: [native] Default to ENS avatar for users that have one.
Jun 1 2023, 6:23 PM
atul accepted D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.
Jun 1 2023, 6:22 PM
atul accepted D8043: [native] Introduce new EmojiAvatarSelection screen for registration flow.
Jun 1 2023, 6:21 PM
atul accepted D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
Jun 1 2023, 6:21 PM
atul accepted D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
Jun 1 2023, 6:15 PM
atul accepted D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
Jun 1 2023, 6:13 PM
atul accepted D8055: [landing] rename asset to imageAsset.
Jun 1 2023, 6:11 PM
atul retitled D8054: [landing] remove deprecated info blocks from [landing] remove depricated info blocks
Jun 1 2023, 6:10 PM
atul accepted D8054: [landing] remove deprecated info blocks.
Jun 1 2023, 6:09 PM
atul accepted D8039: [landing] add feedback text to subscription form component.
Jun 1 2023, 6:09 PM
atul accepted D8038: [landing] add feature cards to competitor comparison.
Jun 1 2023, 6:07 PM
atul accepted D8034: [landing] introduce competitor comparison.
Jun 1 2023, 6:06 PM

May 31 2023

atul accepted D7915: [landing] redesign the subscription form component.
May 31 2023, 8:13 PM
atul updated subscribers of D8034: [landing] introduce competitor comparison.

EDIT: see below, "elected" should be "selected"

May 31 2023, 8:01 PM

May 30 2023

atul added a comment to D8028: [landing] key competitor data.

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

May 30 2023, 6:30 PM
atul accepted D7993: [web] Add multimediaClassName prop to encrypted media components.
May 30 2023, 4:35 PM
atul accepted D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 4:35 PM
atul accepted D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 4:34 PM
atul accepted D7994: [web] Add MediaGalleryItem component.

Re-requesting because I see no way of creating a dynamic style with classnames

May 30 2023, 4:31 PM
atul accepted D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 4:29 PM
atul accepted D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 4:27 PM
atul added inline comments to D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 4:15 PM
atul accepted D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 4:13 PM
atul accepted D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 4:13 PM
atul accepted D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
May 30 2023, 4:12 PM
atul accepted D8025: [landing] introduce feature modal component.

Thanks for updating, looks good

May 30 2023, 4:01 PM
atul accepted D8028: [landing] key competitor data.

If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?

May 30 2023, 3:58 PM
atul requested changes to D8025: [landing] introduce feature modal component.

Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?

May 30 2023, 2:27 PM
atul accepted D8024: [landing] introduce competitor feature base component.
May 30 2023, 2:23 PM
atul accepted D8016: [landing] introduce competitors type.
May 30 2023, 2:17 PM
atul accepted D8015: [landing] introduce competitor logo component.
May 30 2023, 2:16 PM

May 26 2023

atul added a reverting change for rCOMM910fab748b67: [native] Temporary changes for staff release: rCOMM0b94c84fc87f: Revert "[native] Temporary changes for staff release".
May 26 2023, 8:57 PM
atul committed rCOMM0b94c84fc87f: Revert "[native] Temporary changes for staff release".
May 26 2023, 8:57 PM
atul committed rCOMM4815d7cc920d: [native] `codeVersion` -> 222.
May 26 2023, 8:57 PM
atul committed rCOMM910fab748b67: [native] Temporary changes for staff release.
May 26 2023, 8:57 PM
atul committed rCOMM02d51161d723: [native] `codeVersion` -> 221.
May 26 2023, 8:57 PM
atul closed D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221.
May 26 2023, 8:50 PM
atul committed rCOMM615e4e2804f9: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`….
May 26 2023, 8:50 PM
atul accepted D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission.
May 26 2023, 8:49 PM
atul published D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221 for review.
May 26 2023, 8:48 PM
atul committed rCOMMde06493115db: Revert "[native] Temporary changes for staff release".
May 26 2023, 8:31 PM
atul added a reverting change for rCOMM7a1c6e8ceaf6: [native] Temporary changes for staff release: rCOMMde06493115db: Revert "[native] Temporary changes for staff release".
May 26 2023, 8:31 PM
atul committed rCOMMfe4e7f872ef6: [native] `codeVersion` -> 220.
May 26 2023, 8:31 PM
atul committed rCOMM7a1c6e8ceaf6: [native] Temporary changes for staff release.
May 26 2023, 8:31 PM
atul committed rCOMM62fd5d6d49f9: [native] `codeVersion` -> 219.
May 26 2023, 8:31 PM
atul accepted D8005: [native] Launch message editing on mobile.
May 26 2023, 8:24 PM
atul accepted D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 7:54 PM
atul accepted D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.

Huh that's weird

May 26 2023, 7:53 PM
atul accepted D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 7:52 PM
atul accepted D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 5:48 PM
atul accepted D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 5:48 PM
atul accepted D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 5:36 PM
atul closed D7991: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.
May 26 2023, 5:34 PM
atul committed rCOMM5510d4a0d2b7: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.
May 26 2023, 5:34 PM
atul closed D7988: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`.
May 26 2023, 5:34 PM
atul closed D7987: [native] Introduce placeholder `CommunityCreationMembers` component.
May 26 2023, 5:34 PM
atul closed D7980: [native] Display error message when community creation fails.
May 26 2023, 5:34 PM
atul committed rCOMM9e4a8a3c8ca0: [native] Introduce placeholder `CommunityCreationMembers` component.
May 26 2023, 5:34 PM
atul committed rCOMMf902a92c8c9f: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`.
May 26 2023, 5:34 PM
atul committed rCOMMc395aab3ca94: [native] Display error message when community creation fails.
May 26 2023, 5:34 PM
atul closed D7979: [native] Show spinner when community creation request is in progress.
May 26 2023, 5:34 PM
atul closed D7978: [native] Hit `new_thread` endpoint in `CommunityConfiguration`.
May 26 2023, 5:34 PM
atul committed rCOMM8833d0289256: [native] Show spinner when community creation request is in progress.
May 26 2023, 5:34 PM
atul committed rCOMMe5c3f8a5e8f8: [native] Hit `new_thread` endpoint in `CommunityConfiguration`.
May 26 2023, 5:34 PM
atul accepted D7996: [web] Simplify media gallery hooks.
May 26 2023, 5:18 PM
atul accepted D7995: [web] Fix thread gallery for encrypted media.
May 26 2023, 4:00 PM
atul attached a referenced file: F560004: 6b1ca2.png.
May 26 2023, 3:45 PM
atul attached a referenced file: F560005: a3d6c8.png.
May 26 2023, 3:45 PM
atul requested changes to D7994: [web] Add MediaGalleryItem component.

We should use the classnames component to conditionally apply styles on web. Added some examples of usage inline.

May 26 2023, 3:44 PM