Page MenuHomePhorge
Feed Search

Jun 21 2023

atul updated the diff for D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.

address @rohan's feedback

Jun 21 2023, 9:12 PM
atul added inline comments to D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.
Jun 21 2023, 9:09 PM
atul published D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress` for review.
Jun 21 2023, 7:57 PM
atul added reviewers for D8278: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`: inka, rohan, kamil, michal.
Jun 21 2023, 7:54 PM
atul requested review of D8278: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`.
Jun 21 2023, 7:46 PM
atul committed rCOMMef939ec40710: Revert "[native] Temporary changes for staff release".
Jun 21 2023, 6:42 PM
atul added a reverting change for rCOMM606b7ac86861: [native] Temporary changes for staff release: rCOMMef939ec40710: Revert "[native] Temporary changes for staff release".
Jun 21 2023, 6:42 PM
atul committed rCOMM94c8c4833688: [native] `codeVersion` -> 228.
Jun 21 2023, 6:42 PM
atul committed rCOMM606b7ac86861: [native] Temporary changes for staff release.
Jun 21 2023, 6:42 PM
atul committed rCOMM294267b49593: [native] `codeVersion` -> 227.
Jun 21 2023, 6:42 PM
atul closed D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.
Jun 21 2023, 6:30 PM
atul committed rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.
Jun 21 2023, 6:30 PM
atul updated the diff for D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.

rebase before landing

Jun 21 2023, 6:24 PM
atul updated the diff for D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.

rebase before addressing feedback

Jun 21 2023, 6:23 PM
atul added inline comments to D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.
Jun 21 2023, 6:21 PM
atul accepted D8277: [native] Add missing punctuation to discard changes alert.
Jun 21 2023, 4:47 PM
atul added reviewers for D8269: [web] Wrap modals with `WebEditUserAvatarProvider`: michal, kamil, inka, rohan.
Jun 21 2023, 4:47 PM
atul added reviewers for D8268: [web] Add emoji `Picker` to `EmojiAvatarSelectionModal`: rohan, kamil, inka, michal.
Jun 21 2023, 4:46 PM
atul added reviewers for D8267: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`: michal, kamil, inka, rohan.
Jun 21 2023, 4:46 PM
atul added reviewers for D8266: [web] Add `Avatar` preview to `EmojiAvatarSelectionModal`: rohan, inka, michal, kamil.
Jun 21 2023, 4:46 PM
atul added reviewers for D8265: [web] Introduce placeholder `EmojiAvatarSelectionModal`: kamil, michal, inka, rohan.
Jun 21 2023, 4:46 PM
atul added reviewers for D8264: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`: rohan, inka, michal, kamil.
Jun 21 2023, 4:45 PM
atul added reviewers for D8263: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu`: rohan, inka, michal, kamil.
Jun 21 2023, 4:45 PM
atul added reviewers for D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress: rohan, inka, kamil, michal.
Jun 21 2023, 4:45 PM
atul added reviewers for D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`: rohan, kamil, inka, michal.
Jun 21 2023, 4:45 PM
atul accepted D8254: [native] Update native to match new landing SIWE behavior.
Jun 21 2023, 1:50 PM
atul accepted D8253: [landing] Fix detection of RainbowKit modal dismissal.
Jun 21 2023, 1:49 PM
atul accepted D8252: [landing] Monitor WalletConnect modal height.
Jun 21 2023, 1:49 PM
atul accepted D8251: [landing] Factor out logic for monitoring WalletConnect modal.
Jun 21 2023, 1:46 PM
atul requested review of D8269: [web] Wrap modals with `WebEditUserAvatarProvider`.
Jun 21 2023, 1:20 AM

Jun 20 2023

atul published D8268: [web] Add emoji `Picker` to `EmojiAvatarSelectionModal` for review.
Jun 20 2023, 10:18 PM
atul updated the test plan for D8267: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`.
Jun 20 2023, 9:11 PM
atul published D8267: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal` for review.
Jun 20 2023, 9:11 PM
atul added a comment to D8265: [web] Introduce placeholder `EmojiAvatarSelectionModal`.

(This really should have been named something like EmojiUserAvatarSelectionModal since it's UserAvatar-specific. Common parts will be factored out when I get to ThreadAvatars, but for now it's pretty user avatar-specific)

Jun 20 2023, 9:10 PM
atul updated the diff for D8266: [web] Add `Avatar` preview to `EmojiAvatarSelectionModal`.

refactor a touch

Jun 20 2023, 8:55 PM
atul published D8266: [web] Add `Avatar` preview to `EmojiAvatarSelectionModal` for review.
Jun 20 2023, 8:42 PM
atul requested review of D8265: [web] Introduce placeholder `EmojiAvatarSelectionModal`.
Jun 20 2023, 8:14 PM
atul requested review of D8264: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`.
Jun 20 2023, 7:20 PM
atul requested review of D8263: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu`.
Jun 20 2023, 7:12 PM
atul updated the diff for D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.

pull out loadingSpinner from component

Jun 20 2023, 5:57 PM
atul added inline comments to D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.
Jun 20 2023, 5:49 PM
atul published D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress for review.
Jun 20 2023, 5:49 PM
atul requested review of D8260: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.
Jun 20 2023, 5:42 PM
atul closed D8249: [web] Introduce placeholder `WebEditUserAvatarProvider`.
Jun 20 2023, 4:53 PM
atul committed rCOMM9de7b450c008: [web] Introduce placeholder `WebEditUserAvatarProvider`.
Jun 20 2023, 4:53 PM
atul accepted D8250: [lib][web][landing] Update to RainbowKit 0.12.
Jun 20 2023, 4:50 PM
atul updated the diff for D8249: [web] Introduce placeholder `WebEditUserAvatarProvider`.

rebase after addressing feedback

Jun 20 2023, 4:50 PM
atul updated the diff for D8249: [web] Introduce placeholder `WebEditUserAvatarProvider`.

rebase before addressing feedback

Jun 20 2023, 4:48 PM
atul added a comment to D8200: [keyserver] Prevent the only admin role from being changed on the keyserver.

I vaguely recall chatting with @atul recently about some other reason that it would be good to have this parameter, but I don't recall the exact details (I think it was related to permissions?)

Jun 20 2023, 4:45 PM
atul added inline comments to D8249: [web] Introduce placeholder `WebEditUserAvatarProvider`.
Jun 20 2023, 3:00 PM
atul committed rCOMMad4ac9027798: [native] `codeVersion` -> 226.
Jun 20 2023, 12:58 AM
atul committed rCOMMc0b250b1cbf5: Revert "[native] Temporary changes for staff release".
Jun 20 2023, 12:58 AM
atul added a reverting change for rCOMM0163b5271859: [native] Temporary changes for staff release: rCOMMc0b250b1cbf5: Revert "[native] Temporary changes for staff release".
Jun 20 2023, 12:58 AM
atul committed rCOMM0163b5271859: [native] Temporary changes for staff release.
Jun 20 2023, 12:58 AM
atul committed rCOMMdeb59f81b440: [native] `codeVersion` -> 225.
Jun 20 2023, 12:58 AM

Jun 19 2023

atul published D8249: [web] Introduce placeholder `WebEditUserAvatarProvider` for review.
Jun 19 2023, 10:36 PM
atul awarded D8125: [web-db] restore database Safari support a Party Time token.
Jun 19 2023, 10:23 PM
atul accepted D8248: [lib] Fix useThreadSearchIndex performance issue.

Looks good!

Jun 19 2023, 8:02 PM
atul closed D8243: [web] Introduce `EditUserAvatarMenu`.
Jun 19 2023, 4:58 PM
atul committed rCOMM5586b22448b8: [web] Introduce `EditUserAvatarMenu`.
Jun 19 2023, 4:58 PM
atul updated the diff for D8243: [web] Introduce `EditUserAvatarMenu`.

address feedback

Jun 19 2023, 4:57 PM
atul updated the diff for D8243: [web] Introduce `EditUserAvatarMenu`.

rebase before addressing feedback

Jun 19 2023, 4:53 PM
atul added inline comments to D8243: [web] Introduce `EditUserAvatarMenu`.
Jun 19 2023, 4:51 PM
atul closed D8242: [web] Add placeholder edit icon to `EditUserAvatar`.
Jun 19 2023, 4:51 PM
atul committed rCOMMe1c7d50c875b: [web] Add placeholder edit icon to `EditUserAvatar`.
Jun 19 2023, 4:51 PM

Jun 16 2023

atul added inline comments to D8243: [web] Introduce `EditUserAvatarMenu`.
Jun 16 2023, 7:39 PM
atul published D8243: [web] Introduce `EditUserAvatarMenu` for review.
Jun 16 2023, 7:38 PM
atul updated the diff for D8242: [web] Add placeholder edit icon to `EditUserAvatar`.

make EditUserAvatar button more button-like

Jun 16 2023, 6:46 PM
atul committed rCOMM399c57366186: [lib] Rename `EditThreadAvatarProvider` to `BaseEditThreadAvatarProvider` and….
Jun 16 2023, 6:41 PM
atul committed rCOMMe170477f8ee1: [web] Introduce placeholder `EditUserAvatar` component.
Jun 16 2023, 6:41 PM
atul committed rCOMMa6718f88cc97: [native] Introduce `NativeEditThreadAvatarProvider`.
Jun 16 2023, 6:41 PM
atul committed rCOMM0318bb6e09fe: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from….
Jun 16 2023, 6:41 PM
atul committed rCOMMb1dc05e767fb: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`.
Jun 16 2023, 6:41 PM
atul closed D8222: [web] Introduce placeholder `EditUserAvatar` component.
Jun 16 2023, 6:33 PM
atul closed D8221: [lib] Rename `EditThreadAvatarProvider` to `BaseEditThreadAvatarProvider` and move to `lib`.
Jun 16 2023, 6:33 PM
atul closed D8220: [native] Introduce `NativeEditThreadAvatarProvider`.
Jun 16 2023, 6:33 PM
atul closed D8219: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditThreadAvatarProvider`.
Jun 16 2023, 6:33 PM
atul closed D8218: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`.
Jun 16 2023, 6:33 PM
atul published D8242: [web] Add placeholder edit icon to `EditUserAvatar` for review.
Jun 16 2023, 6:29 PM
atul accepted D8228: [native] add recently used category to emoji picker.
Jun 16 2023, 1:41 AM
atul accepted D8227: [native] introduce EmojiSelection type.
Jun 16 2023, 1:40 AM

Jun 14 2023

atul published D8222: [web] Introduce placeholder `EditUserAvatar` component for review.
Jun 14 2023, 10:06 PM
atul closed D8217: [native] Introduce `NativeEditUserAvatarProvider`.
Jun 14 2023, 9:22 PM
atul closed D8216: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`.
Jun 14 2023, 9:22 PM
atul committed rCOMM9a1d07449411: [native] Introduce `NativeEditUserAvatarProvider`.
Jun 14 2023, 9:22 PM
atul committed rCOMMafc1464ca5ed: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`.
Jun 14 2023, 9:22 PM
atul closed D8215: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditUserAvatarProvider`.
Jun 14 2023, 9:22 PM
atul committed rCOMM87fb641250c7: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from….
Jun 14 2023, 9:22 PM
atul closed D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
Jun 14 2023, 9:22 PM
atul committed rCOMMa5767512279d: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
Jun 14 2023, 9:22 PM
atul published D8221: [lib] Rename `EditThreadAvatarProvider` to `BaseEditThreadAvatarProvider` and move to `lib` for review.
Jun 14 2023, 9:03 PM
atul published D8220: [native] Introduce `NativeEditThreadAvatarProvider` for review.
Jun 14 2023, 8:43 PM
atul published D8219: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditThreadAvatarProvider` for review.
Jun 14 2023, 8:10 PM
atul published D8218: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider` for review.
Jun 14 2023, 7:49 PM
atul published D8217: [native] Introduce `NativeEditUserAvatarProvider` for review.
Jun 14 2023, 7:31 PM
atul attached a referenced file: F587802: a2d58d.png.
Jun 14 2023, 7:17 PM
atul added inline comments to D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
Jun 14 2023, 7:17 PM
atul added inline comments to D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
Jun 14 2023, 7:16 PM
atul published D8216: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib` for review.
Jun 14 2023, 7:11 PM
atul published D8215: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditUserAvatarProvider` for review.
Jun 14 2023, 6:55 PM