Page MenuHomePhorge
Feed Search

Jul 5 2023

tomek updated the diff for D8416: [lib] Extract invite links actions.

Rename

Jul 5 2023, 11:19 AM
tomek attached a referenced file: F621583: web-edit-link-new-copy.png.
Jul 5 2023, 11:01 AM
tomek added inline comments to D8415: [web] Introduce edit link modal.
Jul 5 2023, 11:01 AM
tomek updated the diff for D8415: [web] Introduce edit link modal.

Update copy

Jul 5 2023, 11:01 AM
tomek attached a referenced file: F621469: native-invite-new-line.png.
Jul 5 2023, 10:27 AM
tomek added inline comments to D8413: [web] Create manage links modal.
Jul 5 2023, 10:27 AM
tomek added inline comments to D8414: [web] Split modal into multiple components.
Jul 5 2023, 10:23 AM
tomek requested review of D8413: [web] Create manage links modal.
Jul 5 2023, 10:19 AM
tomek attached a referenced file: F621411: native-manage-newline.png.
Jul 5 2023, 9:46 AM
tomek attached a referenced file: F621415: native-view-link.png.
Jul 5 2023, 9:46 AM
tomek attached a referenced file: F621417: native-invalid.png.
Jul 5 2023, 9:46 AM
tomek attached a referenced file: F621420: web-invalid.png.
Jul 5 2023, 9:46 AM
tomek attached a referenced file: F621422: web-view-link.png.
Jul 5 2023, 9:45 AM
tomek added inline comments to D8423: [web][native] Update invite link copy.
Jul 5 2023, 9:45 AM
tomek updated the diff for D8423: [web][native] Update invite link copy.

Address comments

Jul 5 2023, 9:44 AM
tomek accepted D8394: [web] add database module to worker.

Looks ok, but please address the comments.

Jul 5 2023, 9:17 AM
tomek accepted D8393: [web] copy `.wasm` files using webpack.
Jul 5 2023, 9:13 AM
tomek accepted D8392: [web] add managing WASM to yarn.
Jul 5 2023, 8:50 AM
tomek accepted D8389: [web] implement test c++ class.
Jul 5 2023, 8:38 AM
tomek accepted D8355: [lib] Generate converters from validators.

The diffs looks really interesting!

Jul 5 2023, 8:36 AM
tomek added a comment to D8027: [web] Scrolling to the edited message when it overflows.

The biggest feedback is to fix Fast Refresh by moving the non-React exports to a separate file from the React exports. Two candidate files might be web/chat/chat-constants.js or web/chat/message-list-types.js, or you can create a new one if you'd like.

Jul 5 2023, 8:12 AM

Jul 4 2023

tomek requested review of D8423: [web][native] Update invite link copy.
Jul 4 2023, 2:43 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 4 2023, 1:09 PM
tomek requested changes to D8377: Encrypt rescinds.
Jul 4 2023, 12:39 PM

Jul 3 2023

tomek added inline comments to D8418: [native] Fix infinite image loader.
Jul 3 2023, 4:02 PM
tomek added inline comments to D8377: Encrypt rescinds.
Jul 3 2023, 3:56 PM
tomek accepted D8376: Introduce additional type for Android rescinds to avoid adding undefined notification id and undefined badgeOnly after encryption..
Jul 3 2023, 3:47 PM
tomek requested review of D8419: [web] Introduce disable link modal.
Jul 3 2023, 2:30 PM
tomek requested review of D8417: [web] Call update or create invite link endpoint.
Jul 3 2023, 1:49 PM
tomek requested review of D8416: [lib] Extract invite links actions.
Jul 3 2023, 1:47 PM
tomek requested review of D8415: [web] Introduce edit link modal.
Jul 3 2023, 12:29 PM
tomek requested review of D8414: [web] Split modal into multiple components.
Jul 3 2023, 12:25 PM
tomek requested review of D8413: [web] Create manage links modal.
Jul 3 2023, 12:22 PM
tomek requested review of D8412: [web] Extract copy link button.
Jul 3 2023, 12:12 PM
tomek updated the summary of D8307: [web] Add manage invite links menu item.
Jul 3 2023, 11:38 AM
tomek updated the diff for D8307: [web] Add manage invite links menu item.

Update menu text

Jul 3 2023, 11:37 AM
tomek closed D8368: [lib][web] Rename resetting state hook file.
Jul 3 2023, 11:26 AM
tomek committed rCOMMa351056296b5: [lib][web] Rename resetting state hook file.
Jul 3 2023, 11:26 AM

Jun 29 2023

tomek requested changes to D8271: [native] Unblock scrolling when continuing editing.
Jun 29 2023, 1:55 PM
tomek requested changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 29 2023, 1:35 PM
tomek added inline comments to D8307: [web] Add manage invite links menu item.
Jun 29 2023, 1:01 PM
tomek added a reviewer for D8307: [web] Add manage invite links menu item: ashoat.
Jun 29 2023, 1:00 PM
tomek requested review of D8368: [lib][web] Rename resetting state hook file.
Jun 29 2023, 12:54 PM
tomek added inline comments to D8333: [native] Show Roles option in community action sheet.
Jun 29 2023, 12:48 PM
tomek added inline comments to D8294: [web] Update button label after successful copy.
Jun 29 2023, 12:37 PM
tomek closed D8357: [keyserver] Serve .well-known from landing endpoint.
Jun 29 2023, 12:19 PM
tomek committed rCOMM0e0c9c4db213: [keyserver] Serve .well-known from landing endpoint.
Jun 29 2023, 12:19 PM

Jun 28 2023

tomek added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 28 2023, 3:56 PM
tomek edited reviewers for D8357: [keyserver] Serve .well-known from landing endpoint, added: bartek; removed: michal.
Jun 28 2023, 3:39 PM
tomek requested review of D8357: [keyserver] Serve .well-known from landing endpoint.
Jun 28 2023, 12:06 PM

Jun 27 2023

tomek added a comment to D8331: [keyserver] cron job to sync reserved usernames.

Instead of syncing it using chron, can't we call the API as a part of user registration / account deletion?

Jun 27 2023, 3:25 PM
tomek closed D8294: [web] Update button label after successful copy.
Jun 27 2023, 3:20 PM
tomek committed rCOMM9bfaa6dc2a89: [web] Update button label after successful copy.
Jun 27 2023, 3:20 PM
tomek added inline comments to D8294: [web] Update button label after successful copy.
Jun 27 2023, 3:13 PM
tomek closed D8329: [keyserver] Fetch primary links only when a user is logged in.
Jun 27 2023, 2:27 PM
tomek committed rCOMMc9e4b84ef13c: [keyserver] Fetch primary links only when a user is logged in.
Jun 27 2023, 2:27 PM
tomek requested review of D8329: [keyserver] Fetch primary links only when a user is logged in.
Jun 27 2023, 2:26 PM
tomek added inline comments to D8294: [web] Update button label after successful copy.
Jun 27 2023, 10:53 AM
tomek requested review of D8294: [web] Update button label after successful copy.
Jun 27 2023, 10:53 AM
tomek updated the diff for D8294: [web] Update button label after successful copy.

Create and use resetting state hook

Jun 27 2023, 10:52 AM
tomek accepted D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 27 2023, 10:32 AM
tomek accepted D8272: [web] Add message search context.
Jun 27 2023, 10:24 AM

Jun 26 2023

tomek added a comment to D8306: [web] Allow other types of icons in menu item.
In D8306#245283, @inka wrote:

Why are the strokes necessary?

Jun 26 2023, 2:57 PM
tomek closed D8255: [keyserver][native] Fix invite links setup.
Jun 26 2023, 1:04 PM
tomek closed D8246: [web] Refresh invite links.
Jun 26 2023, 1:04 PM
tomek committed rCOMMb062e658340c: [keyserver][native] Fix invite links setup.
Jun 26 2023, 1:04 PM
tomek committed rCOMMbd5f5b2f701e: [web] Refresh invite links.
Jun 26 2023, 1:04 PM
tomek closed D8238: [web] Create link view modal.
Jun 26 2023, 1:04 PM
tomek closed D8239: [web] Allow copying the link.
Jun 26 2023, 1:04 PM
tomek committed rCOMMa28409f77f27: [web] Allow copying the link.
Jun 26 2023, 1:04 PM
tomek committed rCOMMc1e60b201e86: [web] Create link view modal.
Jun 26 2023, 1:04 PM
tomek closed D8237: [web] Display invite links button conditionally.
Jun 26 2023, 1:04 PM
tomek closed D8292: [lib][native] Extract invite link url.
Jun 26 2023, 1:04 PM
tomek committed rCOMM8f6f5f900738: [lib][native] Extract invite link url.
Jun 26 2023, 1:04 PM
tomek committed rCOMM93563ab25e43: [web] Display invite links button conditionally.
Jun 26 2023, 1:04 PM
tomek closed D8236: [keyserver] Return invite links in initial web state.
Jun 26 2023, 1:04 PM
tomek committed rCOMM79342e60cd2b: [keyserver] Return invite links in initial web state.
Jun 26 2023, 1:04 PM
tomek accepted D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 26 2023, 11:14 AM
tomek requested review of D8306: [web] Allow other types of icons in menu item.
Jun 26 2023, 11:13 AM
tomek requested review of D8307: [web] Add manage invite links menu item.
Jun 26 2023, 11:13 AM

Jun 23 2023

tomek requested changes to D8297: [native] Bump `react-native-ffmpeg` to `5.2.0`.

Bumping the version looks ok, but it seems to break iOS build

Jun 23 2023, 2:20 PM
tomek accepted D8271: [native] Unblock scrolling when continuing editing.
Jun 23 2023, 1:51 PM
tomek added inline comments to D8270: [native] Blocking navigation in edit mode in OverlayRouter.
Jun 23 2023, 1:49 PM
tomek requested changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.

Overall, looks ok, but I have a couple of questions.

Jun 23 2023, 12:39 PM
tomek requested review of D8292: [lib][native] Extract invite link url.
Jun 23 2023, 8:38 AM
tomek requested review of D8294: [web] Update button label after successful copy.
Jun 23 2023, 8:38 AM

Jun 22 2023

tomek updated the diff for D8246: [web] Refresh invite links.

Fetch links only when user is logged in and clear the store after logout

Jun 22 2023, 3:11 PM
tomek added inline comments to D8246: [web] Refresh invite links.
Jun 22 2023, 2:28 PM
tomek updated the diff for D8239: [web] Allow copying the link.

Rebase - use extracted function

Jun 22 2023, 2:26 PM
tomek updated the diff for D8238: [web] Create link view modal.

Use link url function

Jun 22 2023, 2:24 PM
tomek requested changes to D8272: [web] Add message search context.
Jun 22 2023, 9:26 AM
tomek added inline comments to D8245: Manually serialize notification data to avoid passing encrypted notification to JavaScript.
Jun 22 2023, 8:33 AM

Jun 21 2023

tomek requested changes to D8272: [web] Add message search context.
Jun 21 2023, 12:43 PM
tomek added inline comments to D8239: [web] Allow copying the link.
Jun 21 2023, 12:28 PM
tomek closed D8204: [native] Fix invite link button positioning.
Jun 21 2023, 12:14 PM
tomek committed rCOMM3dd3b9b9d78a: [native] Fix invite link button positioning.
Jun 21 2023, 12:14 PM
tomek added inline comments to D8255: [keyserver][native] Fix invite links setup.
Jun 21 2023, 12:03 PM

Jun 20 2023

tomek updated the summary of D8255: [keyserver][native] Fix invite links setup.
Jun 20 2023, 12:53 PM
tomek requested review of D8255: [keyserver][native] Fix invite links setup.
Jun 20 2023, 11:46 AM
tomek accepted D8245: Manually serialize notification data to avoid passing encrypted notification to JavaScript.
Jun 20 2023, 8:19 AM