Perfect!

It might be good to update these three existing sites where we use CSSStyleDeclaration to now use CSSStyle:

Rebase

Fix indentation

Thanks for the helpful visuals! That made it very clear what the problem is.

Thanks for this diff! In the future we should probably move away from you putting me as a reviewer on all of your diffs, but I'm happy to help review this one :)

I'm open to it if it improves consistency, but I'd want to see side-by-side examples of what we're talking about here (changes roles screen, what we're currently doing here, and what you're proposing we do here). I'd also like to hear from Ted about it

I agree, navigating away from the screen seems to be the default behavior of using displayActionResultModal.

Please remove the async declaration from saveIdentityInfo

I need a lot more context. Please try to explain in detail the decisions behind each of these

Let's actually capitalize the first letter. We should probably do the same in log-in form, but to be fair it's a little different visually... the errors there are shorter, and are not given their own full-width container (if I recall correctly)

Will this solve the problem for older clients? Or are older clients unaffected due to hasMinStateVersion checks?

I tested this locally and it solves the issue! Great work @pklatka. Going to pass back to you with just some questions / minor suggestions inline

I guess this makes sense. We should make sure that the boundaries of the any are well-enforced... any types can sometimes "infect" a codebase and travel to unexpected places.

Wouldn't commenting this code out result in the thumbhash having the wrong dimensions? Doesn't the thumbhash need the exact dimensions passed to it?

See inline comment... I think we can probably just go with prevScenesRef.current. @kuba, if you could make that update and test this one final time before landing, that would be deeply appreciated!

Close!

Looks good, just some nits!

Talked about this offline with @jon and we're going to make some changes here. @jon will summarize

Apologies for the continued churn, but I'm pretty sure this will be the last revision :)

I think we should actually use prevSceneDataRef.current instead of sceneList, and I agree that resetScrollBlockingModalStatus needs to be defined via React.useCallback

Please, please try harder to proofread your English. It's really frustrating to have to do basic English editing. I am confident you can do better if you put more effort into it.

Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that

Looks great!!

Great work testing!

Great work! Mostly nits inline

I suspect that query-by-username will be a common flow. Here are the situations in which it will happen:

Does this fix a bug that is live in production? If so, can you please coordinate with @atul to get a new release out?

Thanks!!

In addition to the inline comments, three notes:

Thanks for explaining all of the thinking around colors @ginsu. I think your suggestions make sense. Feel free to re-add me if you want my perspective again

Concerned that you're still not understanding the feedback, even after I spent a lot of time in my last review typing it out thoughtfully. Please try to make sure you grok the feedback being updating this diff again. If you're not sure that you understand the feedback, I would much rather you message me about it then to update this diff again without addressing the feedback

I got added back to the review it looks like? Anyways, passing back to you

In D8404#248608, @jon wrote:

After this lands, I can remove identity_auth_token from my production keyserver config, yeah?

After we deploy a new version of identity service, yes.