Page MenuHomePhorge
Feed Search

Aug 28 2023

ginsu committed rCOMM2747a10bcae8: [native/web] change title of MessageReactionsModal to All reactions.
Aug 28 2023, 5:04 AM
ginsu committed rCOMMe2a2434b7642: [web] introduce getTooltipScreenOverflowRightCorrection function.
Aug 28 2023, 5:04 AM
ginsu closed D8857: [web] introduce calculateReactionTooltipSize function.
Aug 28 2023, 5:04 AM
ginsu closed D8859: [web] introduce useReactionTooltip hook.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM7c47bc1c71ab: [web] introduce useReactionTooltip hook.
Aug 28 2023, 5:04 AM
ginsu committed rCOMMa1f7c72f4e9e: [web] introduce calculateReactionTooltipSize function.
Aug 28 2023, 5:04 AM
ginsu closed D8823: [web] introduce ReactionTooltip component.
Aug 28 2023, 5:04 AM
ginsu closed D8858: [web] rename calculateToolTipSize to calculateMessageTooltipSize.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM372ca174ee7e: [web] introduce ReactionTooltip component.
Aug 28 2023, 5:04 AM
ginsu closed D8831: [web] update calculateMaxTextWidth to consider different font sizes.
Aug 28 2023, 5:04 AM
ginsu closed D8829: [web] introduce useTooltip hook.
Aug 28 2023, 5:04 AM
ginsu committed rCOMMe88bb4c1762d: [web] update calculateMaxTextWidth to consider different font sizes.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM037b2664951a: [web] introduce useTooltip hook.
Aug 28 2023, 5:04 AM
ginsu closed D8828: [web] move getTooltipPositionStyle into tooltip-utils.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM6c13fc182944: [web] move getTooltipPositionStyle into tooltip-utils.
Aug 28 2023, 5:04 AM
ginsu closed D8827: [web] convert createTooltip to getTooltipPositionStyle.
Aug 28 2023, 5:04 AM
ginsu closed D8826: [web] rename getMessageActionTooltipStyle to getTooltipStyle.
Aug 28 2023, 5:04 AM
ginsu committed rCOMMb4efda7028af: [web] convert createTooltip to getTooltipPositionStyle.
Aug 28 2023, 5:04 AM
ginsu committed rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle.
Aug 28 2023, 5:04 AM
ginsu closed D8819: [web] introduce ReactionPill component.
Aug 28 2023, 5:04 AM
ginsu committed rCOMM7661ac1baf29: [web] introduce ReactionPill component.
Aug 28 2023, 5:04 AM
ginsu updated the diff for D8862: [web] make MessageReactionsModal scrollable.

rebase before landing

Aug 28 2023, 4:46 AM
ginsu updated the diff for D8861: [native/web] change title of MessageReactionsModal to All reactions.

rebase before landing

Aug 28 2023, 4:44 AM
ginsu updated the diff for D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.

rebase before landing

Aug 28 2023, 4:40 AM
ginsu retitled D8860: [web] introduce getTooltipScreenOverflowRightCorrection function from [web] introduce getTooltipScreenOverflowXCorrection function
Aug 28 2023, 4:36 AM
ginsu updated the diff for D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.

address comments / rebase before landing

Aug 28 2023, 4:36 AM
ginsu updated the diff for D8859: [web] introduce useReactionTooltip hook.

address comments / rebase before landing

Aug 28 2023, 4:17 AM
ginsu updated the diff for D8857: [web] introduce calculateReactionTooltipSize function.

address comments and rebase before landing

Aug 28 2023, 4:09 AM
ginsu updated the diff for D8858: [web] rename calculateToolTipSize to calculateMessageTooltipSize.

rebase before landing

Aug 28 2023, 4:03 AM
ginsu updated the diff for D8823: [web] introduce ReactionTooltip component.

address comments

Aug 28 2023, 3:59 AM
ginsu updated the diff for D8823: [web] introduce ReactionTooltip component.

rebase before landing

Aug 28 2023, 3:57 AM
ginsu updated the diff for D8831: [web] update calculateMaxTextWidth to consider different font sizes.

rebase before landing

Aug 28 2023, 3:57 AM
ginsu updated the diff for D8829: [web] introduce useTooltip hook.

rebase before landing

Aug 28 2023, 3:56 AM
ginsu updated the diff for D8828: [web] move getTooltipPositionStyle into tooltip-utils.

rebase before landing

Aug 28 2023, 3:56 AM
ginsu updated the diff for D8827: [web] convert createTooltip to getTooltipPositionStyle.

rebase before landing

Aug 28 2023, 3:56 AM
ginsu updated the diff for D8826: [web] rename getMessageActionTooltipStyle to getTooltipStyle.

rebase before landing

Aug 28 2023, 3:55 AM
ginsu updated the diff for D8819: [web] introduce ReactionPill component.

address feedback and rebase before landing

Aug 28 2023, 3:50 AM
ginsu closed D8810: [web] show which reactions the viewer has already selected in the inline engagement.
Aug 28 2023, 3:34 AM
ginsu closed D8808: [web] introduce functionality to send a reaction by clicking on the reaction pill.
Aug 28 2023, 3:34 AM
ginsu closed D8807: [lib/native/web] factor out localID logic into helper hook.
Aug 28 2023, 3:34 AM
ginsu committed rCOMMc327e4a6e712: [web] show which reactions the viewer has already selected in the inline….
Aug 28 2023, 3:34 AM
ginsu closed D8711: [web] move reaction message action type logic into useSendReaction.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM439c4798c8d9: [web] introduce functionality to send a reaction by clicking on the reaction….
Aug 28 2023, 3:34 AM
ginsu committed rCOMMdd35f6aeead5: [lib/native/web] factor out localID logic into helper hook.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM1ad3e712612d: [web] move reaction message action type logic into useSendReaction.
Aug 28 2023, 3:34 AM
ginsu closed D8710: [web] make reactions prop for InlineEngagement requried.
Aug 28 2023, 3:34 AM
ginsu closed D8709: [web] deprecate stringForReactionList.
Aug 28 2023, 3:34 AM
ginsu closed D8708: [web] seperate out each reaction into their own pill.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM569644b864be: [web] deprecate stringForReactionList.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill.
Aug 28 2023, 3:34 AM
ginsu closed D8707: [web] add space between inline engagement container and edges of chat window.
Aug 28 2023, 3:34 AM
ginsu closed D8684: [web] clean up edited label.
Aug 28 2023, 3:34 AM
ginsu committed rCOMMf05d80e8fb31: [web] add space between inline engagement container and edges of chat window.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM1e7c476d9438: [web] clean up edited label.
Aug 28 2023, 3:34 AM
ginsu closed D8678: [web] split the inline engagement pill into two.
Aug 28 2023, 3:34 AM
ginsu committed rCOMM51232ff99e7a: [web] split the inline engagement pill into two.
Aug 28 2023, 3:34 AM
ginsu updated the diff for D8810: [web] show which reactions the viewer has already selected in the inline engagement.

rebase before landing

Aug 28 2023, 2:53 AM
ginsu updated the diff for D8808: [web] introduce functionality to send a reaction by clicking on the reaction pill.

rebase before landing

Aug 28 2023, 2:52 AM
ginsu updated the diff for D8807: [lib/native/web] factor out localID logic into helper hook.

rebase before landing

Aug 28 2023, 2:52 AM
ginsu updated the diff for D8711: [web] move reaction message action type logic into useSendReaction.

rebase before landing

Aug 28 2023, 2:51 AM
ginsu updated the diff for D8710: [web] make reactions prop for InlineEngagement requried.

rebase before landing

Aug 28 2023, 2:50 AM
ginsu updated the diff for D8709: [web] deprecate stringForReactionList.

rebase before landing

Aug 28 2023, 2:49 AM
ginsu updated the diff for D8708: [web] seperate out each reaction into their own pill.

rebase before landing

Aug 28 2023, 2:49 AM
ginsu updated the diff for D8707: [web] add space between inline engagement container and edges of chat window.

rebase before landing

Aug 28 2023, 2:48 AM
ginsu updated the diff for D8684: [web] clean up edited label.

rebase before landing

Aug 28 2023, 2:47 AM
ginsu updated the diff for D8678: [web] split the inline engagement pill into two.

rebase before landing

Aug 28 2023, 2:45 AM

Aug 25 2023

ginsu updated the summary of D8958: [native] introduce custom bottom sheet handle component.
Aug 25 2023, 9:12 PM
ginsu attached a referenced file: F717071: Screen Recording 2023-08-25 at 5.05.20 PM.mov.
Aug 25 2023, 9:07 PM
ginsu attached a referenced file: F717070: Screen Recording 2023-08-25 at 5.05.43 PM.mov.
Aug 25 2023, 9:07 PM
ginsu added inline comments to D8958: [native] introduce custom bottom sheet handle component.
Aug 25 2023, 9:06 PM
ginsu requested review of D8958: [native] introduce custom bottom sheet handle component.
Aug 25 2023, 8:49 PM
ginsu requested review of D8955: [native] introduce barebones bottom sheet component.
Aug 25 2023, 6:33 PM

Aug 24 2023

ginsu attached a referenced file: F712729: Screenshot 2023-08-24 at 5.43.13 PM.png.
Aug 24 2023, 9:45 PM
ginsu attached a referenced file: F712730: Screenshot 2023-08-24 at 5.43.06 PM.png.
Aug 24 2023, 9:45 PM
ginsu updated subscribers of D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.

Are you sure that overlapping thread list a bit is okay?

Aug 24 2023, 9:45 PM
ginsu requested review of D8935: [native] add BottomSheetModalProvider to the root component.
Aug 24 2023, 8:22 PM
ginsu abandoned D8893: DRAFT: [native] fix forcing message height breaking message timestamp.

D8921 makes this diff obsolete

Aug 24 2023, 5:55 PM
ginsu accepted D8912: [native] Add a new screen to display a QR code as part of a new native login flow.

accepting, but please address inline comments before landing

Aug 24 2023, 4:36 PM
ginsu accepted D8870: [native] Add a temporary sign in via QR code button on native.
Aug 24 2023, 4:21 PM
ginsu added a comment to D8870: [native] Add a temporary sign in via QR code button on native.

One inline comment, but LGTM!

Aug 24 2023, 4:21 PM

Aug 23 2023

ginsu closed D8921: [native] fix broken messaging experience from forcing incorrect message height measurements.
Aug 23 2023, 4:10 PM
ginsu committed rCOMM23b508c56197: [native] fix broken messaging experience from forcing incorrect message height….
Aug 23 2023, 4:10 PM
ginsu closed D8920: Revert "[native] fix RetrySend not visible when message fails".
Aug 23 2023, 4:10 PM
ginsu added a reverting change for D8839: [native] fix RetrySend not visible when message fails: rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails".
Aug 23 2023, 4:10 PM
ginsu committed rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails".
Aug 23 2023, 4:10 PM
ginsu added a reverting change for rCOMMdf101e5f740a: [native] fix RetrySend not visible when message fails: rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails".
Aug 23 2023, 4:10 PM

Aug 22 2023

ginsu attached a referenced file: F704487: Screen Recording 2023-08-22 at 5.17.21 PM.mov.
Aug 22 2023, 9:20 PM
ginsu updated the test plan for D8921: [native] fix broken messaging experience from forcing incorrect message height measurements.
Aug 22 2023, 9:19 PM
ginsu attached a referenced file: F704435: Screen Recording 2023-08-22 at 5.05.02 PM.mov.
Aug 22 2023, 9:13 PM
ginsu updated the test plan for D8921: [native] fix broken messaging experience from forcing incorrect message height measurements.
Aug 22 2023, 9:13 PM
ginsu requested review of D8921: [native] fix broken messaging experience from forcing incorrect message height measurements.
Aug 22 2023, 7:38 PM
ginsu requested review of D8920: Revert "[native] fix RetrySend not visible when message fails".
Aug 22 2023, 7:34 PM
ginsu accepted D8919: [web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar`.
Aug 22 2023, 7:15 PM
ginsu added a reverting change for D8839: [native] fix RetrySend not visible when message fails: D8920: Revert "[native] fix RetrySend not visible when message fails".
Aug 22 2023, 7:15 PM
ginsu added a reverting change for rCOMMdf101e5f740a: [native] fix RetrySend not visible when message fails: D8920: Revert "[native] fix RetrySend not visible when message fails".
Aug 22 2023, 7:15 PM
ginsu requested review of D8915: [native] introduce copy username functionality to user profiles.
Aug 22 2023, 4:51 PM
ginsu requested review of D8914: [native] introduce user profile component.
Aug 22 2023, 4:37 PM
ginsu requested review of D8913: [native] introduce profileLarge avatar size.
Aug 22 2023, 4:17 PM