Rebase before landing

The download_logs() and log_download_stream() logic is unobvious at first glance but after offline discussions, I think they work as expected.

• Used hook abstraction as proposed
• Used direct commCoreModule call in crash component

Simplified approach - moved identity context into useBlobServiceUpload hook

Add hook for fetchAndDecryptMedia

Add hook for fetchAndDecryptMedia

In D10929#315352, @ashoat wrote:

Makes sense. I suppose we could use native implementations in some places (eg. Node.js), but not sure it matters too much for performance.

Update comment

Address feedback

In D10837#315635, @ashoat wrote:

I'm asking if the uri field might contain something for old-style uploads, that we want to skip.

Rebase on fix

Fix flow

Rebase on fix

Renamed the RPC; added request field for the nonce/timestamp challenge

Fix payload

Rebase

Rebase on review feedback from parent diffs

Rebase on review feedback from parent diffs

Updated RPC to accept full SignedDeviceList JSON as request payload, removed unused response object

Thank You!

Apply requested quickfixes

Adding @ashoat because of dependency changes.
This dep was already in native, I copy-pasted it to lib, so no yarn.lock changes

Replace convenient hook with imperative calls

Replace convenient hook with imperative calls

Extracted lib function to D10929

In D10902#314783, @varun wrote:

Looks good to me. How about removing the social_proof from DeviceKeyUpload?

I assume you meant the DeviceKeyUploadActions trait. I agree we can remove social_proof() from that trait and the implementation. Will make this change before landing

Looks good to me. How about removing the social_proof from DeviceKeyUpload?

Nice!

Business logic looks good to me.
Generally, there are lots of serde_json::from_str and serde_json::to_string, map_err everywhere which can be simplified and generalized using some traits and generics but it's not worth spending much time on this.

Okay, these comments make sense, thank you! I was indeed confused that we're "adding signing later" so I did this differently, but I agree it's good to have correct RPC format from the beginning. I'll update this accordingly