Page MenuHomePhorge
Feed Search

Apr 3 2024

will closed D11421: [lib] introduce sync metadata add and remove action types.
Apr 3 2024, 6:22 AM
will committed rCOMM9ce16932b467: [lib/native/web] introduce synced metadata reducer.
Apr 3 2024, 6:22 AM
will closed D11420: [sqlite] implement processing synced metadata store ops on worker.
Apr 3 2024, 6:22 AM
will committed rCOMMebc836f84cf9: [lib] introduce sync metadata add and remove action types.
Apr 3 2024, 6:22 AM
will committed rCOMMea325d9df057: [sqlite] implement processing synced metadata store ops on worker.
Apr 3 2024, 6:22 AM
will closed D11419: [sqlite] implement C++ code to get synced metadata.
Apr 3 2024, 6:21 AM
will closed D11418: [sqlite] implement C++ synced metadata store ops.
Apr 3 2024, 6:21 AM
will closed D11417: [sqlite] add methods to operate on synced metadata table.
Apr 3 2024, 6:21 AM
will committed rCOMMb0cdf069f964: [sqlite] implement C++ code to get synced metadata.
Apr 3 2024, 6:21 AM
will committed rCOMM585c20c0a367: [sqlite] implement C++ synced metadata store ops.
Apr 3 2024, 6:21 AM
will committed rCOMMf947cab385e0: [sqlite] add methods to operate on synced metadata table.
Apr 3 2024, 6:21 AM
will closed D11416: [sqlite] add sync metadata table to sqlite.
Apr 3 2024, 6:21 AM
will closed D11415: [lib] introduce SyncedMetadata store spec.
Apr 3 2024, 6:21 AM
will committed rCOMM46c53c6b69dd: [sqlite] add sync metadata table to sqlite.
Apr 3 2024, 6:21 AM
will committed rCOMM205d98818c41: [lib] introduce SyncedMetadata store spec.
Apr 3 2024, 6:21 AM
will closed D11414: [lib] introduce synced metadata types.
Apr 3 2024, 6:21 AM
will committed rCOMM01cb4f0b5da1: [lib] introduce synced metadata types.
Apr 3 2024, 6:21 AM
will updated the diff for D11424: [native][web] read synced metadata on app startup.

rebase

Apr 3 2024, 5:47 AM
will requested review of D11529: [native][web] read aux user store on app startup.
Apr 3 2024, 4:19 AM
will requested review of D11528: [lib] Introduce aux user store reducer and action types.
Apr 3 2024, 2:16 AM

Apr 2 2024

will added inline comments to D11415: [lib] introduce SyncedMetadata store spec.
Apr 2 2024, 8:41 PM
will accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Apr 2 2024, 4:14 AM

Apr 1 2024

will requested review of D11511: [sqlite] implement processing aux user store ops on worker.
Apr 1 2024, 6:52 AM
will requested review of D11510: [sqlite] Implement C++ for native to get all aux user infos.
Apr 1 2024, 6:20 AM
will requested review of D11509: [sqlite] implement C++ aux user store ops.
Apr 1 2024, 5:54 AM
will requested review of D11508: [sqlite] introduce aux user store C++ methods.
Apr 1 2024, 5:30 AM
will requested review of D11507: [sqlite] add aux users table for aux user store data.
Apr 1 2024, 5:26 AM
will requested review of D11506: [lib] introduce the aux user store ops.
Apr 1 2024, 4:56 AM
will requested review of D11505: [lib] introduce aux user types.
Apr 1 2024, 4:50 AM

Mar 29 2024

will added inline comments to D11472: [native] Blocklist for backed up tables.
Mar 29 2024, 7:15 PM
will added inline comments to D11422: [lib/native/web] introduce synced metadata reducer.
Mar 29 2024, 12:03 AM

Mar 28 2024

will updated the diff for D11422: [lib/native/web] introduce synced metadata reducer.

review feedback

Mar 28 2024, 11:55 PM
will added inline comments to D11417: [sqlite] add methods to operate on synced metadata table.
Mar 28 2024, 11:23 PM
will accepted D11444: [native] Fix up project.pbxproj after yarn cleaninstall.

Just as a note, planning on removing this file from project.pbxproj. Context: https://phab.comm.dev/D11417?id=38396#inline-69092

Mar 28 2024, 11:16 PM
will abandoned D11454: [sqlite] downgrade migration version on native from '65' to '64'.

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Mar 28 2024, 8:54 PM
will added a comment to D11454: [sqlite] downgrade migration version on native from '65' to '64'.

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved.

Mar 28 2024, 8:48 PM
will abandoned D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Mar 28 2024, 8:48 PM
will abandoned D11456: Revert "[lib] integrity reducer tests".

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved.

Mar 28 2024, 8:48 PM
will requested review of D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 6:42 PM
will requested review of D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 6:40 PM
will added a reverting change for D11359: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 6:25 PM
will added a reverting change for rCOMM2c577fabda21: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 6:25 PM
will requested review of D11454: [sqlite] downgrade migration version on native from '65' to '64'.
Mar 28 2024, 6:24 PM
will added a reverting change for D11358: [native][web] Read integrity thread hashes from SQLite on app start: D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 6:08 PM
will added a reverting change for rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start: D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 6:08 PM
will updated the diff for D11421: [lib] introduce sync metadata add and remove action types.

review feedback

Mar 28 2024, 5:13 PM
will updated the diff for D11418: [sqlite] implement C++ synced metadata store ops.

review feedback

Mar 28 2024, 5:04 PM
will updated the diff for D11417: [sqlite] add methods to operate on synced metadata table.

review feedback

Mar 28 2024, 4:40 PM
will added inline comments to D11417: [sqlite] add methods to operate on synced metadata table.
Mar 28 2024, 4:00 PM
will updated the diff for D11415: [lib] introduce SyncedMetadata store spec.

review feedback

Mar 28 2024, 2:41 PM
will added inline comments to D11415: [lib] introduce SyncedMetadata store spec.
Mar 28 2024, 2:35 PM
will added inline comments to D11415: [lib] introduce SyncedMetadata store spec.
Mar 28 2024, 2:33 PM
will added inline comments to D11415: [lib] introduce SyncedMetadata store spec.
Mar 28 2024, 1:56 PM
will added inline comments to D11415: [lib] introduce SyncedMetadata store spec.
Mar 28 2024, 1:53 PM
will added a comment to D11425: [lib][native] FIDProvider.

Here's the linear issue for replacing usages of the FIDProvider and reverting once it's no longer needed:
https://linear.app/comm/issue/ENG-7590/replace-all-fidprovider-usages-with-synced-metadata-store

Mar 28 2024, 1:56 AM
will accepted D11425: [lib][native] FIDProvider.
Mar 28 2024, 1:51 AM
will requested review of D11424: [native][web] read synced metadata on app startup.
Mar 28 2024, 12:44 AM
will updated the summary of D11422: [lib/native/web] introduce synced metadata reducer.
Mar 28 2024, 12:15 AM
will updated the diff for D11422: [lib/native/web] introduce synced metadata reducer.

add support for the remove synced metadata action type

Mar 28 2024, 12:14 AM
will updated the test plan for D11422: [lib/native/web] introduce synced metadata reducer.
Mar 28 2024, 12:10 AM
will planned changes to D11422: [lib/native/web] introduce synced metadata reducer.
Mar 28 2024, 12:05 AM

Mar 27 2024

will requested review of D11422: [lib/native/web] introduce synced metadata reducer.
Mar 27 2024, 11:33 PM
will requested review of D11421: [lib] introduce sync metadata add and remove action types.
Mar 27 2024, 11:29 PM
will requested review of D11420: [sqlite] implement processing synced metadata store ops on worker.
Mar 27 2024, 11:25 PM
will updated the summary of D11419: [sqlite] implement C++ code to get synced metadata.
Mar 27 2024, 11:10 PM
will requested review of D11419: [sqlite] implement C++ code to get synced metadata.
Mar 27 2024, 10:46 PM
will requested review of D11418: [sqlite] implement C++ synced metadata store ops.
Mar 27 2024, 10:41 PM
will requested review of D11417: [sqlite] add methods to operate on synced metadata table.
Mar 27 2024, 9:11 PM
will requested review of D11416: [sqlite] add sync metadata table to sqlite.
Mar 27 2024, 9:04 PM
will requested review of D11415: [lib] introduce SyncedMetadata store spec.
Mar 27 2024, 8:59 PM
will requested review of D11414: [lib] introduce synced metadata types.
Mar 27 2024, 8:57 PM

Mar 26 2024

will added a comment to D11349: [native] migrate integrityStore to SQLite.

Here's the linear issue tracking putting integrityStore on redux persist black list and switching to using sqlite integrityStore:

Mar 26 2024, 9:08 PM
will added a comment to D11349: [native] migrate integrityStore to SQLite.

At some point we should also blacklist integrityStore on native so that it isn't persisted using redux-persist

Was this ever done? It looks like this stack was landed and integrityStore is not in persistBlacklist on native...

Mar 26 2024, 8:39 PM

Mar 25 2024

will accepted D11382: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`.
Mar 25 2024, 9:15 PM
will closed D11359: [lib] integrity reducer tests.
Mar 25 2024, 9:11 PM
will committed rCOMM2c577fabda21: [lib] integrity reducer tests.
Mar 25 2024, 9:11 PM
will closed D11358: [native][web] Read integrity thread hashes from SQLite on app start.
Mar 25 2024, 9:11 PM
will closed D11357: [native][web] Start processing integrity store with sqlite operations.
Mar 25 2024, 9:11 PM
will committed rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start.
Mar 25 2024, 9:11 PM
will committed rCOMM51b91fcbab53: [native][web] Start processing integrity store with sqlite operations.
Mar 25 2024, 9:11 PM
will closed D11349: [native] migrate integrityStore to SQLite.
Mar 25 2024, 9:11 PM
will closed D11309: [sqlite] implement processing integrity store ops on worker.
Mar 25 2024, 9:11 PM
will committed rCOMMd93872ce1f66: [native] migrate integrityStore to SQLite.
Mar 25 2024, 9:11 PM
will committed rCOMMd27ead6e8d4c: [sqlite] implement processing integrity store ops on worker.
Mar 25 2024, 9:11 PM
will closed D11307: [sqlite] Implement C++ code to get integrity store thread hashes.
Mar 25 2024, 9:11 PM
will committed rCOMMbbf8d5c0c50c: [sqlite] Implement C++ code to get integrity store thread hashes.
Mar 25 2024, 9:11 PM
will closed D11300: [sqlite] add methods to operate on integrity store table.
Mar 25 2024, 9:11 PM
will closed D11306: [sqlite] implement C++ integrity store ops.
Mar 25 2024, 9:11 PM
will committed rCOMMc12a268115b2: [sqlite] add methods to operate on integrity store table.
Mar 25 2024, 9:11 PM
will committed rCOMM03b900a71b56: [sqlite] implement C++ integrity store ops.
Mar 25 2024, 9:11 PM
will closed D11323: [lib] return ops from integrity store reducer.
Mar 25 2024, 9:11 PM
will committed rCOMMdc183ddde9e0: [lib] return ops from integrity store reducer.
Mar 25 2024, 9:11 PM
will closed D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.
Mar 25 2024, 9:11 PM
will closed D11322: refactor integrity reducer starting state to use processStoreOps.
Mar 25 2024, 9:11 PM
will closed D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 25 2024, 9:11 PM
will committed rCOMMcf451d8230a7: [sqlite] [lib] refactor integrity reducer full state sync action type to use….
Mar 25 2024, 9:11 PM
will committed rCOMM2107c0a14ea4: refactor integrity reducer starting state to use processStoreOps.
Mar 25 2024, 9:11 PM
will committed rCOMM54a83315aa19: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 25 2024, 9:11 PM
will closed D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
Mar 25 2024, 9:10 PM
will closed D11249: [sqlite] Adds integrity store table.
Mar 25 2024, 9:10 PM