update createCreateOrUpdateActionPromise to return the response
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Apr 26 2024
Apr 26 2024
ginsu requested review of D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.
ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
In D11808, we gate the entire endpoint and this should address the concerns regarding exposing the endpoint w/o permissions +ensuring that nobody will ever have a blob holder on their client
ginsu updated the summary of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Apr 25 2024
Apr 25 2024
Adding @ashoat as a blocking reviewer since there are copy changes in this diff
alert code looks good, pls make sure to respond + address @ashoat's comments before landing
ginsu requested review of D11784: [native] update selectedChannel state to be a FarcasterChannel type.
ginsu updated the diff for D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
rebase before landing
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu requested review of D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
Apr 22 2024
Apr 22 2024
address comments (also confirmed that changing from to panel color family from modal color family caused no regressions with the UI:
Apr 19 2024
Apr 19 2024
let's goooo
Apr 18 2024
Apr 18 2024
rebase before landing
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
rebase before landing
ginsu updated the diff for D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
rebase before landing
rebase before landing
ginsu requested review of D11682: [native] introduce screen options to tag farcaster channel stack navigator.
ginsu added inline comments to D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
rebase
ginsu updated the diff for D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
address comments
address comments
Apr 17 2024
Apr 17 2024
ginsu updated subscribers of D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
address comments + update gating logic for showing tag farcaster channel to check fid is present as well
ginsu requested review of D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
Apr 16 2024
Apr 16 2024
rebase before landing
rebase before landing
Code changes look good, would be good to make sure all other notes left by other reviewers are addressed/responded to before landing.
ginsu added inline comments to D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
Apr 15 2024
Apr 15 2024
Apr 12 2024
Apr 12 2024
would be good to get a screenshot to see the colors visually as a sanity check for the colors but the color variables follow our conventions
ginsu retitled D11613: [lib/native] introduce connect farcaster alert handler from [lib/native] introduce farcaster handler
address comments
Apr 11 2024
Apr 11 2024
thanks for catching this @will. I thought I addressed this but looking at connect-farcaster.react.js now I can see I accidentally only toString() the farcaster auth url. Would you mind updating this diff to remove the toString() for the auth url? It's typed as a string already so doesn't make sense to toString() a string
Apr 10 2024
Apr 10 2024
update
ginsu updated the diff for D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.
rebase before landing
ginsu updated the diff for D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
rebase