Page MenuHomePhabricator
Feed Advanced Search

May 14 2024

atul updated the test plan for D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.
May 14 2024, 1:16 PM
atul closed D11915: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.
May 14 2024, 1:10 PM
atul committed rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider` (authored by atul).
[lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
May 14 2024, 1:10 PM
atul updated the test plan for D11915: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.
May 14 2024, 11:17 AM
atul updated the diff for D11915: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.

address feedback (remove memoization of boolean value)

May 14 2024, 11:15 AM
atul closed D11914: [native] Consume `useAvailableThreadMemberActions` in `native/ThreadSettingsMember`.
May 14 2024, 10:54 AM
atul committed rCOMMdf13d56f8fc9: [native] Consume `useAvailableThreadMemberActions` in… (authored by atul).
[native] Consume `useAvailableThreadMemberActions` in…
May 14 2024, 10:54 AM
atul updated the diff for D11914: [native] Consume `useAvailableThreadMemberActions` in `native/ThreadSettingsMember`.

land

May 14 2024, 10:47 AM
atul added a comment to D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.

Will getAvailableThreadMemberActions be deprecated at the end of this stack? If not, I think it would be good to factor out the logic instead of copy-pasting

May 14 2024, 10:46 AM
atul updated the test plan for D11914: [native] Consume `useAvailableThreadMemberActions` in `native/ThreadSettingsMember`.
May 14 2024, 10:34 AM
atul closed D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.
May 14 2024, 10:33 AM
atul committed rCOMM50421aba1c22: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member` (authored by atul).
[lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`
May 14 2024, 10:33 AM
atul updated the test plan for D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.
May 14 2024, 10:32 AM
atul updated the test plan for D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.
May 14 2024, 10:32 AM
atul updated the diff for D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.

address feedback

May 14 2024, 9:18 AM
atul updated the diff for D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.

rebase before addressing feedback

May 14 2024, 9:13 AM

May 9 2024

atul published D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread` for review.
May 9 2024, 6:01 PM
atul requested review of D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
May 9 2024, 2:25 PM

May 8 2024

atul added inline comments to D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
May 8 2024, 6:43 PM
atul published D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads` for review.
May 8 2024, 6:42 PM

May 7 2024

atul added a comment to D11925: [lib] Introduce `useOnScreenEntryEditableThreadInfos`.

As an aside, it might be nice to separate hooks from thread-utils and put them in eg thread-hooks file? Maybe even move permission-related utilities to something like thread-permission-utils?

May 7 2024, 10:47 AM
atul requested review of D11925: [lib] Introduce `useOnScreenEntryEditableThreadInfos`.
May 7 2024, 10:38 AM
atul published D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s for review.
May 7 2024, 9:24 AM

May 6 2024

atul published D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings` for review.
May 6 2024, 2:16 PM
atul added inline comments to D11915: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.
May 6 2024, 2:15 PM
atul published D11915: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider` for review.
May 6 2024, 1:51 PM
atul published D11914: [native] Consume `useAvailableThreadMemberActions` in `native/ThreadSettingsMember` for review.
May 6 2024, 1:14 PM
atul requested review of D11913: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.
May 6 2024, 12:52 PM

May 3 2024

atul closed D11822: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.
May 3 2024, 1:01 PM
atul closed D11820: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in `useMessageTogglePinAction`.
May 3 2024, 1:01 PM
atul committed rCOMMca7ba3e7bb9b: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in… (authored by atul).
[web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in…
May 3 2024, 1:01 PM
atul committed rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types (authored by atul).
[lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types
May 3 2024, 1:01 PM
atul closed D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.
May 3 2024, 1:01 PM
atul committed rCOMM30dbaeafde23: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message` (authored by atul).
[lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`
May 3 2024, 1:01 PM
atul updated the diff for D11822: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.

land

May 3 2024, 12:50 PM
atul updated the diff for D11820: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in `useMessageTogglePinAction`.

land

May 3 2024, 12:49 PM
atul updated the diff for D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.

land

May 3 2024, 12:49 PM
atul closed D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.
May 3 2024, 12:47 PM
atul committed rCOMM4d4d115cf91c: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
May 3 2024, 12:47 PM
atul updated the diff for D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.

addresss feedback

May 3 2024, 11:59 AM

May 2 2024

atul closed D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
May 2 2024, 11:03 AM
atul committed rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
May 2 2024, 11:03 AM
atul updated the diff for D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.

land

May 2 2024, 10:52 AM
atul closed D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
May 2 2024, 9:59 AM
atul committed rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
May 2 2024, 9:59 AM
atul updated the diff for D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.

address feedback

May 2 2024, 9:47 AM

May 1 2024

atul closed D11712: [lib] Shim unsupported messages for `web`/`desktop`.
May 1 2024, 4:54 PM
atul committed rCOMM4c5a86dbda62: [lib] Shim unsupported messages for `web`/`desktop` (authored by atul).
[lib] Shim unsupported messages for `web`/`desktop`
May 1 2024, 4:54 PM
atul updated the diff for D11712: [lib] Shim unsupported messages for `web`/`desktop`.

rebase and land

May 1 2024, 4:35 PM
atul added a comment to D11712: [lib] Shim unsupported messages for `web`/`desktop`.

Did testing to ensure UNSUPPORTED messages appear as expected on web client:

May 1 2024, 4:30 PM

Apr 26 2024

atul requested review of D11822: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.
Apr 26 2024, 1:36 PM
atul requested review of D11820: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in `useMessageTogglePinAction`.
Apr 26 2024, 1:26 PM
atul requested review of D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.
Apr 26 2024, 1:22 PM
atul requested review of D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.
Apr 26 2024, 1:16 PM
atul requested review of D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
Apr 26 2024, 1:10 PM
atul requested review of D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
Apr 26 2024, 1:07 PM
atul closed D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Apr 26 2024, 12:13 PM
atul committed rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook (authored by atul).
[lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
Apr 26 2024, 12:12 PM
atul updated the diff for D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.

consolidate conditional

Apr 26 2024, 12:08 PM
atul added inline comments to D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Apr 26 2024, 11:47 AM
atul closed D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Apr 26 2024, 11:46 AM
atul closed D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Apr 26 2024, 11:46 AM
atul committed rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:46 AM
atul committed rCOMMee863bd9130e: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:46 AM
atul closed D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Apr 26 2024, 11:46 AM
atul closed D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Apr 26 2024, 11:46 AM
atul committed rCOMM44f0eb5b7bb2: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:46 AM
atul committed rCOMM35ac66da12dd: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`
Apr 26 2024, 11:46 AM
atul closed D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Apr 26 2024, 11:46 AM
atul closed D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Apr 26 2024, 11:46 AM
atul committed rCOMMbdb7d7e4f575: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:46 AM
atul committed rCOMM70c6da8e1aab: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:46 AM
atul closed D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Apr 26 2024, 11:46 AM
atul committed rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 26 2024, 11:45 AM
atul updated the diff for D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Apr 26 2024, 11:43 AM
atul updated the diff for D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.

land

Apr 26 2024, 11:43 AM
atul updated the diff for D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

land

Apr 26 2024, 11:43 AM
atul updated the diff for D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

land

Apr 26 2024, 11:07 AM
atul updated the diff for D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.

land

Apr 26 2024, 11:06 AM
atul updated the diff for D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.

land

Apr 26 2024, 11:06 AM
atul updated the diff for D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Apr 26 2024, 10:55 AM

Apr 25 2024

atul requested review of D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Apr 25 2024, 2:30 PM
atul requested review of D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Apr 25 2024, 2:26 PM
atul requested review of D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Apr 25 2024, 2:21 PM
atul requested review of D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Apr 25 2024, 2:15 PM
atul requested review of D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Apr 25 2024, 2:12 PM
atul requested review of D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Apr 25 2024, 2:11 PM
atul requested review of D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Apr 25 2024, 2:10 PM
atul added a comment to D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

Apr 25 2024, 10:13 AM

Apr 24 2024

atul closed D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.
Apr 24 2024, 6:58 PM
atul closed D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.
Apr 24 2024, 6:58 PM
atul committed rCOMMb6c3358bdf37: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 24 2024, 6:58 PM
atul closed D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.
Apr 24 2024, 6:58 PM
atul committed rCOMM26e18f854825: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 24 2024, 6:58 PM
atul committed rCOMM9c19d63b2e5b: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 24 2024, 6:58 PM
atul closed D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Apr 24 2024, 6:58 PM
atul closed D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Apr 24 2024, 6:58 PM
atul committed rCOMM9b9964fa6b48: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Apr 24 2024, 6:58 PM
atul committed rCOMM572a486f5101: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`
Apr 24 2024, 6:58 PM
atul closed D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Apr 24 2024, 6:58 PM