What happens if a user attempts to tag a community to a Farcaster channel that already has a community tagged to it?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
May 16 2024
May 16 2024
ginsu updated the summary of D12060: [keyserver/lib/web] include communityStore in the initialReduxState.
ginsu added inline comments to D12061: [lib] introduce new updateRolesAndPermissions migration util.
ginsu updated the test plan for D12061: [lib] introduce new updateRolesAndPermissions migration util.
ginsu added a comment to D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
ginsu requested review of D12060: [keyserver/lib/web] include communityStore in the initialReduxState.
We got rid of the mechanism to fetch the farcaster channel info since we are using the /CHANNEL_ID over the channel name, so this diff is no longer relevant
ginsu updated the test plan for D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
ginsu added a comment to D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
@ginsu do we have a way to know if the Farcaster channel is already associated with a Comm community? (I recall that it's 1-to-1)
ginsu updated the diff for D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
address comments
May 15 2024
May 15 2024
ginsu updated the test plan for D11894: [native] introduce tag channel by name option in action sheet.
address comments
ginsu added inline comments to D11894: [native] introduce tag channel by name option in action sheet.
rebase before landing
rebase before landing
address comments + rebase before landing
address comments + rebase before landing
ginsu added inline comments to D11873: [native] introduce getFarcasterAccountAlreadyLinkedAlertDetails.
ginsu requested review of D12042: [native] extend loading logic to include fetching farcaster channel info.
ginsu updated the summary of D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
ginsu added a comment to D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.
Making @ashoat a blocking reviewer to review copy
May 14 2024
May 14 2024
ginsu requested review of D12027: [lib] update community reducer to handle new community action types.
ginsu requested review of D12025: [native] display loading spinner in TagChannelButton during loading state.
ginsu updated the test plan for D11894: [native] introduce tag channel by name option in action sheet.
ginsu retitled D11894: [native] introduce tag channel by name option in action sheet from [native] introduce tag channel by name link
address comments
forgot to hit save
address comments
update
address comments
May 10 2024
May 10 2024
May 9 2024
May 9 2024
address comments
ginsu accepted D11973: [native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow.
Accepting since code looks good + don't want to block, but might be worth to update test plan to better explain how this diff was tested
ginsu requested review of D11978: [keyserver/lib] update deleteFarcasterChannelTag to use communites table.
ginsu added inline comments to D11904: [keyserver] modify thread creator + deleter endpoints to update communities table.
ginsu updated the diff for D11904: [keyserver] modify thread creator + deleter endpoints to update communities table.
address comments
May 8 2024
May 8 2024
May 7 2024
May 7 2024
address comments
ginsu updated the summary of D11904: [keyserver] modify thread creator + deleter endpoints to update communities table.
ginsu updated the diff for D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
address comments
May 6 2024
May 6 2024
What happens if a name is chosen on the TagFarcasterChannelByName screen?
ginsu added a comment to D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
padding around error message looks different than in invite links, can we make it more consistent?
ginsu added inline comments to D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
ginsu updated the diff for D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
address comments
ginsu updated the diff for D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.
rebase before landing
ginsu added inline comments to D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.
ginsu added reviewers for D11904: [keyserver] modify thread creator + deleter endpoints to update communities table: tomek, kamil.