Page MenuHomePhabricator
Feed Advanced Search

Jul 8 2024

ginsu requested review of D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app.
Jul 8 2024, 12:31 AM

Jul 7 2024

ginsu requested review of D12683: [native] update connect farcaster prompt to be less annyoying.
Jul 7 2024, 10:53 PM
ginsu closed D12675: [native] update copy for thread notification settings.
Jul 7 2024, 10:31 PM
ginsu committed rCOMM335064c59cf1: [native] update copy for thread notification settings (authored by ginsu).
[native] update copy for thread notification settings
Jul 7 2024, 10:31 PM
ginsu updated the diff for D12675: [native] update copy for thread notification settings.

rebase before landing

Jul 7 2024, 10:28 PM
ginsu added inline comments to D12675: [native] update copy for thread notification settings.
Jul 7 2024, 10:27 PM
ginsu added inline comments to D12581: [native] fix empty media gallery in thread settings.
Jul 7 2024, 10:20 PM
ginsu updated the diff for D12581: [native] fix empty media gallery in thread settings.

address comments

Jul 7 2024, 10:19 PM

Jul 5 2024

ginsu updated the diff for D12675: [native] update copy for thread notification settings.

update

Jul 5 2024, 12:59 PM
ginsu planned changes to D12675: [native] update copy for thread notification settings.

Found a bug with saving the thread notif settings

Jul 5 2024, 12:45 PM
ginsu requested review of D12675: [native] update copy for thread notification settings.
Jul 5 2024, 11:21 AM

Jul 4 2024

ginsu closed D12666: [native] deprecate ThreadSettingsHomeNotifs.
Jul 4 2024, 11:21 AM
ginsu closed D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.
Jul 4 2024, 11:21 AM
ginsu committed rCOMMd78ef501ea74: [native] update ThreadSettingsPushNotifs to use new thread notifs settings… (authored by ginsu).
[native] update ThreadSettingsPushNotifs to use new thread notifs settings…
Jul 4 2024, 11:21 AM
ginsu committed rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs (authored by ginsu).
[native] deprecate ThreadSettingsHomeNotifs
Jul 4 2024, 11:21 AM
ginsu closed D12663: [native] update thread notif settings ui to handle case when parent thread is in background.
Jul 4 2024, 11:21 AM
ginsu closed D12664: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.
Jul 4 2024, 11:21 AM
ginsu committed rCOMMe60d77284b98: [native] update thread notif settings ui to handle case when parent thread is… (authored by ginsu).
[native] update thread notif settings ui to handle case when parent thread is…
Jul 4 2024, 11:21 AM
ginsu committed rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT (authored by ginsu).
[lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT
Jul 4 2024, 11:21 AM
ginsu closed D12662: [native] introduce thread notif settings notice text.
Jul 4 2024, 11:21 AM
ginsu closed D12648: [native] introduce NotificationDescription.
Jul 4 2024, 11:21 AM
ginsu committed rCOMMeb5b3d8405ec: [native] introduce NotificationDescription (authored by ginsu).
[native] introduce NotificationDescription
Jul 4 2024, 11:21 AM
ginsu committed rCOMM0e0eeebb12fa: [native] introduce thread notif settings notice text (authored by ginsu).
[native] introduce thread notif settings notice text
Jul 4 2024, 11:21 AM
ginsu closed D12647: [native] introduce barebones UI for ThreadSettingsNotifications.
Jul 4 2024, 11:21 AM
ginsu closed D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
Jul 4 2024, 11:21 AM
ginsu committed rCOMM769fcab17eac: [native] introduce barebones UI for ThreadSettingsNotifications (authored by ginsu).
[native] introduce barebones UI for ThreadSettingsNotifications
Jul 4 2024, 11:21 AM
ginsu committed rCOMMd805cb6dbfba: [lib/native/web] factor out remaining shared logic + copy for thread… (authored by ginsu).
[lib/native/web] factor out remaining shared logic + copy for thread…
Jul 4 2024, 11:21 AM
ginsu closed D12654: [native] update EnumSettingsOption UI.
Jul 4 2024, 11:21 AM
ginsu closed D12653: [native] introduce disabled prop for EnumSettingsOption.
Jul 4 2024, 11:21 AM
ginsu committed rCOMM35a34d3e2ca4: [native] update EnumSettingsOption UI (authored by ginsu).
[native] update EnumSettingsOption UI
Jul 4 2024, 11:21 AM
ginsu committed rCOMMa9358077a210: [native] introduce disabled prop for EnumSettingsOption (authored by ginsu).
[native] introduce disabled prop for EnumSettingsOption
Jul 4 2024, 11:21 AM
ginsu closed D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 4 2024, 11:21 AM
ginsu committed rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration… (authored by ginsu).
[native] extend icon prop in EnumSettingsOption to handle illustration…
Jul 4 2024, 11:21 AM
ginsu closed D12643: [native] introduce type prop to EnumSettingsOption component.
Jul 4 2024, 11:21 AM
ginsu committed rCOMM8ec15fd60aa1: [native] introduce type prop to EnumSettingsOption component (authored by ginsu).
[native] introduce type prop to EnumSettingsOption component
Jul 4 2024, 11:21 AM
ginsu closed D12642: [native] introduce nav logic for ThreadSettingsNotifications.
Jul 4 2024, 11:21 AM
ginsu committed rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications (authored by ginsu).
[native] introduce nav logic for ThreadSettingsNotifications
Jul 4 2024, 11:21 AM
ginsu updated the diff for D12666: [native] deprecate ThreadSettingsHomeNotifs.

rebae before landing

Jul 4 2024, 11:16 AM
ginsu updated the diff for D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.

address comments + rebase before landing

Jul 4 2024, 11:15 AM
ginsu updated the diff for D12664: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.

address comments + rebase before landing

Jul 4 2024, 11:11 AM
ginsu updated the diff for D12663: [native] update thread notif settings ui to handle case when parent thread is in background.

rebase before landing

Jul 4 2024, 11:04 AM
ginsu updated the diff for D12662: [native] introduce thread notif settings notice text.

rebase before landing

Jul 4 2024, 11:03 AM
ginsu updated the diff for D12662: [native] introduce thread notif settings notice text.

rebase before landing

Jul 4 2024, 11:02 AM
ginsu updated the diff for D12648: [native] introduce NotificationDescription.

rebase before landing

Jul 4 2024, 11:01 AM
ginsu updated the diff for D12647: [native] introduce barebones UI for ThreadSettingsNotifications.

rebase before landing

Jul 4 2024, 10:59 AM
ginsu updated the diff for D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.

rebase before landing

Jul 4 2024, 10:58 AM
ginsu attached a referenced file: F2189691: Screen Recording 2024-07-04 at 1.56.02 PM.mov.
Jul 4 2024, 10:57 AM
ginsu updated the test plan for D12654: [native] update EnumSettingsOption UI.
Jul 4 2024, 10:57 AM
ginsu updated the diff for D12654: [native] update EnumSettingsOption UI.

address comments + rebase before landing

Jul 4 2024, 10:56 AM
ginsu updated the diff for D12653: [native] introduce disabled prop for EnumSettingsOption.

rebase before landing

Jul 4 2024, 10:49 AM
ginsu updated the diff for D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.

rebase before landing

Jul 4 2024, 10:48 AM
ginsu updated the diff for D12643: [native] introduce type prop to EnumSettingsOption component.

rebase before landing

Jul 4 2024, 10:47 AM
ginsu updated the diff for D12642: [native] introduce nav logic for ThreadSettingsNotifications.

rebase before landing

Jul 4 2024, 10:47 AM
ginsu requested review of D12666: [native] deprecate ThreadSettingsHomeNotifs.
Jul 4 2024, 12:43 AM
ginsu requested review of D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.
Jul 4 2024, 12:30 AM
ginsu updated the summary of D12663: [native] update thread notif settings ui to handle case when parent thread is in background.
Jul 4 2024, 12:24 AM

Jul 3 2024

ginsu requested review of D12664: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.
Jul 3 2024, 11:01 PM
ginsu requested review of D12663: [native] update thread notif settings ui to handle case when parent thread is in background.
Jul 3 2024, 10:59 PM
ginsu added inline comments to D12648: [native] introduce NotificationDescription.
Jul 3 2024, 10:47 PM
ginsu requested review of D12662: [native] introduce thread notif settings notice text.
Jul 3 2024, 10:18 PM
ginsu updated the diff for D12648: [native] introduce NotificationDescription.

update

Jul 3 2024, 10:17 PM
ginsu updated the summary of D12647: [native] introduce barebones UI for ThreadSettingsNotifications.
Jul 3 2024, 10:09 PM
ginsu updated the test plan for D12648: [native] introduce NotificationDescription.
Jul 3 2024, 9:59 PM
ginsu updated the diff for D12648: [native] introduce NotificationDescription.

update

Jul 3 2024, 9:42 PM
ginsu planned changes to D12648: [native] introduce NotificationDescription.

found a small ui regression

Jul 3 2024, 9:24 PM
ginsu updated the diff for D12648: [native] introduce NotificationDescription.

address comments

Jul 3 2024, 9:23 PM
ginsu requested review of D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
Jul 3 2024, 9:21 PM
ginsu attached a referenced file: F2184503: Screen Recording 2024-07-04 at 12.18.06 AM.mov.
Jul 3 2024, 9:20 PM
ginsu updated the test plan for D12647: [native] introduce barebones UI for ThreadSettingsNotifications.
Jul 3 2024, 9:20 PM
ginsu updated the diff for D12647: [native] introduce barebones UI for ThreadSettingsNotifications.

update

Jul 3 2024, 9:18 PM
ginsu requested review of D12654: [native] update EnumSettingsOption UI.
Jul 3 2024, 6:28 PM
ginsu requested review of D12643: [native] introduce type prop to EnumSettingsOption component.

Can we try to space it out more? I'd like more margin between option, and to balance the space on the right side. We can try to work through it together tomorrow in person if you're in the office

Jul 3 2024, 6:27 PM
ginsu requested review of D12653: [native] introduce disabled prop for EnumSettingsOption.
Jul 3 2024, 5:47 PM
ginsu updated the summary of D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 3 2024, 5:39 PM
ginsu updated the summary of D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 3 2024, 5:38 PM
ginsu updated the summary of D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 3 2024, 5:37 PM
ginsu closed D12646: [lib/web] introduce useThreadSettingsNotifications.
Jul 3 2024, 3:13 PM
ginsu closed D12644: [native] introduce new vector assets for new thread notification settings experience.
Jul 3 2024, 3:13 PM
ginsu closed D12600: [native] introduce loading logic to RelationshipPrompt.
Jul 3 2024, 3:13 PM
ginsu committed rCOMM4a83fa595d7c: [lib/web] introduce useThreadSettingsNotifications (authored by ginsu).
[lib/web] introduce useThreadSettingsNotifications
Jul 3 2024, 3:13 PM
ginsu committed rCOMMd3ab2492c51c: [native] introduce new vector assets for new thread notification settings… (authored by ginsu).
[native] introduce new vector assets for new thread notification settings…
Jul 3 2024, 3:13 PM
ginsu committed rCOMM058aeceb5690: [native] introduce loading logic to RelationshipPrompt (authored by ginsu).
[native] introduce loading logic to RelationshipPrompt
Jul 3 2024, 3:13 PM
ginsu closed D12595: [web] intorduce loading logic to relationship prompt button.
Jul 3 2024, 3:13 PM
ginsu closed D12596: [native] introduce loading logic to relationship prompt button.
Jul 3 2024, 3:13 PM
ginsu committed rCOMMca5304649f74: [web] intorduce loading logic to relationship prompt button (authored by ginsu).
[web] intorduce loading logic to relationship prompt button
Jul 3 2024, 3:13 PM
ginsu committed rCOMM27b3a634bfd3: [native] introduce loading logic to relationship prompt button (authored by ginsu).
[native] introduce loading logic to relationship prompt button
Jul 3 2024, 3:13 PM
ginsu closed D12593: [lib] introduce loading logic to useRelationshipPrompt.
Jul 3 2024, 3:13 PM
ginsu committed rCOMM0bb06f9eb4c7: [lib] introduce loading logic to useRelationshipPrompt (authored by ginsu).
[lib] introduce loading logic to useRelationshipPrompt
Jul 3 2024, 3:13 PM
ginsu closed D12651: [native] introduce LoadableButton.
Jul 3 2024, 3:13 PM
ginsu committed rCOMM4577aa80a243: [native] introduce LoadableButton (authored by ginsu).
[native] introduce LoadableButton
Jul 3 2024, 3:13 PM
ginsu updated the diff for D12646: [lib/web] introduce useThreadSettingsNotifications.

rebase before landing

Jul 3 2024, 3:11 PM
ginsu updated the diff for D12644: [native] introduce new vector assets for new thread notification settings experience.

rebase before landing

Jul 3 2024, 3:10 PM
ginsu updated the diff for D12600: [native] introduce loading logic to RelationshipPrompt.

rebase before landing

Jul 3 2024, 3:10 PM
ginsu updated the diff for D12596: [native] introduce loading logic to relationship prompt button.

rebase before landing

Jul 3 2024, 3:10 PM
ginsu updated the diff for D12595: [web] intorduce loading logic to relationship prompt button.

rebase before landing

Jul 3 2024, 3:09 PM
ginsu updated the diff for D12593: [lib] introduce loading logic to useRelationshipPrompt.

rebase before landing

Jul 3 2024, 3:09 PM
ginsu updated the diff for D12651: [native] introduce LoadableButton.

rebase before landing

Jul 3 2024, 3:08 PM
ginsu added a comment to D12646: [lib/web] introduce useThreadSettingsNotifications.

Removing this diff from the stack so I can land as is (locally rebased + confirmed that this is safe)

Jul 3 2024, 3:06 PM
ginsu updated the summary of D12646: [lib/web] introduce useThreadSettingsNotifications.
Jul 3 2024, 3:06 PM
ginsu added a comment to D12644: [native] introduce new vector assets for new thread notification settings experience.

Removing this diff from the stack so I can land as is (locally rebased + confirmed that this is safe)

Jul 3 2024, 3:05 PM