Could you update the spacing to match the rest of the file?

address review

rename

add code comment

rename

I think the usage of if and dmOpID can be improved and more descriptive, this might look confusing as we have plenty IDs all over the codebase - but I don't have idea about better ones

🤦‍♂️🙄
Thanks for fixing

I think this should be done at different level:

1. Use decrypt here: https://github.com/CommE2E/comm/blob/8b786f1788c01edce880256d4f5318ce54342f29/native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp#L1619
2. Rename decryptSequentialAndPersist -> decryptAndPersist

Right now two JS threads (shared worker and service worker) can concurrently modify the same key in IndexedDB. I think to make it safe we should use transactions to make sure this is safe.

I really don't like the idea (looking at this diff and the entire stack) of passing isKeyserverSession - notification crypto module should treat all devices the same regardless of whether this is a keyserver or client device, and we should only have senderID, because the current design makes it confusing. But given this is implemented and tested I believe we can proceed, you could create a follow-up task to improve it in future but for now LGTM.

We should also be able to get rid of the web-specific getOlmPersistAccountDataWeb and just use getOlmPersistAccountData on web. I'll create a follow-up task for this before landing.

Awesome!

In D12686#359268, @will wrote:

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

Nit: when you linking code it's better to use the latest commit from the master, not the master branch as after some changes link will start pointing to different lines, and if someone needs context after a while it might get lost.

use Some

address review

add link

fix docs length

rebase