Page MenuHomePhabricator
Feed Advanced Search

Jul 22 2024

inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Fix indentation

Jul 22 2024, 11:20 PM
inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Fix indentation

Jul 22 2024, 11:17 PM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Jul 22 2024, 8:17 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Jul 22 2024, 8:15 AM
inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Move code

Jul 22 2024, 8:11 AM
inka added a comment to D12806: [lib] DMOperationSpec for reaction operation.

On the keyserver, when reactionMessageCreationResponder is called, it calls createMessages which in turn calls updateRepliesCount. Do we need to do something like this for DMs?

Jul 22 2024, 6:44 AM
inka added a comment to D12764: [lib] Introduce useGetLatestMessageEdit.

This solution requires us to query for every message separately. This seems very inefficient. Is this necessary?

Jul 22 2024, 6:40 AM
inka accepted D12834: [web][native] Increase number of actions kept in Redux debugger.
Jul 22 2024, 5:24 AM
inka requested review of D12833: [lib][web][native] Create message search store ops.
Jul 22 2024, 3:12 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Jul 22 2024, 12:26 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Jul 22 2024, 12:25 AM
inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Rebase

Jul 22 2024, 12:00 AM

Jul 21 2024

inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Rebase

Jul 21 2024, 11:59 PM

Jul 19 2024

inka updated the diff for D12795: [native] Add message search store.

Add newline

Jul 19 2024, 8:06 AM
inka added inline comments to D12795: [native] Add message search store.
Jul 19 2024, 8:06 AM
inka updated the diff for D12795: [native] Add message search store.

Rename

Jul 19 2024, 8:03 AM
inka updated the diff for D12794: [native] Add MessageSearchStoreOperations.

Rename to UpdateMessageSearchIndexOperation

Jul 19 2024, 8:00 AM
inka added inline comments to D12801: [lib][web] Add worker logic for adding search messages.
Jul 19 2024, 4:06 AM
inka requested review of D12801: [lib][web] Add worker logic for adding search messages.
Jul 19 2024, 3:33 AM
inka added inline comments to D12795: [native] Add message search store.
Jul 19 2024, 2:59 AM
inka added inline comments to D12794: [native] Add MessageSearchStoreOperations.
Jul 19 2024, 2:58 AM

Jul 18 2024

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rename fix

Jul 18 2024, 8:36 AM
inka requested review of D12796: [native] Add CommCoreModule code for inserting into the search table.
Jul 18 2024, 8:30 AM
inka requested review of D12795: [native] Add message search store.
Jul 18 2024, 8:24 AM
inka accepted D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 18 2024, 8:23 AM
inka requested review of D12794: [native] Add MessageSearchStoreOperations.
Jul 18 2024, 8:21 AM
inka updated the test plan for D12793: [lib] Stop requesting device lists for users that don't have them.
Jul 18 2024, 7:56 AM
inka requested review of D12793: [lib] Stop requesting device lists for users that don't have them.
Jul 18 2024, 7:53 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Update wasm

Jul 18 2024, 5:59 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Update .lock files

Jul 18 2024, 5:52 AM
inka planned changes to D12693: [native][web] Add fts5 extension to SQLite.

I need to update podfile

Jul 18 2024, 5:19 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rename to updateMessageSearchIndex

Jul 18 2024, 5:07 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rename to updateMessageSearchIndex

Jul 18 2024, 5:06 AM
inka added a comment to D12694: [native](web) Add message_search fts5 table.

Heads-up that I landed a different migration 48 in D12759, so you'll have to rebase this one.

Jul 18 2024, 5:02 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Remove patch and update package.json

Jul 18 2024, 5:01 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Rebase

Jul 18 2024, 4:57 AM
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Jul 18 2024, 4:56 AM
inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Jul 18 2024, 4:55 AM
inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Rebase

Jul 18 2024, 4:54 AM

Jul 17 2024

inka requested review of D12783: [web] Add bindings for inserting into the search table.
Jul 17 2024, 5:07 AM
inka requested review of D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
Jul 17 2024, 3:43 AM

Jul 15 2024

inka requested review of D12694: [native](web) Add message_search fts5 table.
Jul 15 2024, 8:09 AM
inka closed D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 15 2024, 4:23 AM
inka committed rCOMM6583cde4a78d: [keyserver] Fix keyserver allowing adding unauthorized users to chats (authored by inka).
[keyserver] Fix keyserver allowing adding unauthorized users to chats
Jul 15 2024, 4:23 AM
inka updated the diff for D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.

Rename to containingThreadIDForPossibleMemberResolution

Jul 15 2024, 3:49 AM
inka added a comment to D12693: [native][web] Add fts5 extension to SQLite.

@ashoat I think we can make the release now. Should I do anything to make that possible?

Jul 15 2024, 3:46 AM

Jul 12 2024

inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Remove manual changes in XCode. I had to rever the changes in native/ios/Comm.xcodeproj/project.pbxproj for all of them to disappear.
I ran yarn cleaninstall and install pods and checked that removing and reinstalling the iOS app still doesn't throw

Jul 12 2024, 2:59 AM
inka closed D12726: [web] Allow creating subchannels with no other users.
Jul 12 2024, 2:31 AM
inka committed rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users (authored by inka).
[web] Allow creating subchannels with no other users
Jul 12 2024, 2:31 AM
inka updated the diff for D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.

Don't call determineThreadAncestry twice

Jul 12 2024, 2:28 AM
inka added inline comments to D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 12 2024, 2:21 AM

Jul 11 2024

inka planned changes to D12693: [native][web] Add fts5 extension to SQLite.
Jul 11 2024, 7:20 AM
inka requested review of D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 11 2024, 7:11 AM
inka requested review of D12726: [web] Allow creating subchannels with no other users.
Jul 11 2024, 5:50 AM
inka closed D12715: [web] Don't allow creating subchannels with users the user should not be able to add.
Jul 11 2024, 5:17 AM
inka committed rCOMM3acce0a16833: [web] Don't allow creating subchannels with users the user should not be able… (authored by inka).
[web] Don't allow creating subchannels with users the user should not be able…
Jul 11 2024, 5:17 AM
inka closed D12667: [web] Fix creating subchannels in chats in GENESIS.
Jul 11 2024, 5:17 AM
inka committed rCOMMe0aed78637dd: [web] Fix creating subchannels in chats in GENESIS (authored by inka).
[web] Fix creating subchannels in chats in GENESIS
Jul 11 2024, 5:17 AM
inka added inline comments to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 11 2024, 4:04 AM
inka added a comment to D12715: [web] Don't allow creating subchannels with users the user should not be able to add.

Sorry about this!

Jul 11 2024, 3:43 AM
inka updated the diff for D12715: [web] Don't allow creating subchannels with users the user should not be able to add.

Memozie

Jul 11 2024, 3:42 AM
inka added inline comments to D12667: [web] Fix creating subchannels in chats in GENESIS.
Jul 11 2024, 3:40 AM
inka updated the diff for D12667: [web] Fix creating subchannels in chats in GENESIS.

Address review

Jul 11 2024, 3:40 AM
inka accepted D12721: [web] Don't wrap usernames with dashes in ReactionTooltip.
Jul 11 2024, 3:28 AM
inka accepted D12720: [lib] Fix subchannels of subchannels in GENESIS not appearing in navigation side drawer.

The name getCommunityThreadIDForGenesisThreads seems to suggest that this function only returns values for GENESIS subchannels. Can you confirm this doesn't break for chats in other communities?

Jul 11 2024, 2:58 AM

Jul 10 2024

inka updated the diff for D12715: [web] Don't allow creating subchannels with users the user should not be able to add.

Rebase

Jul 10 2024, 8:57 AM
inka updated the diff for D12667: [web] Fix creating subchannels in chats in GENESIS.

Address review

Jul 10 2024, 7:50 AM
inka updated the test plan for D12667: [web] Fix creating subchannels in chats in GENESIS.
Jul 10 2024, 7:45 AM
inka requested review of D12715: [web] Don't allow creating subchannels with users the user should not be able to add.
Jul 10 2024, 2:12 AM
inka requested review of D12667: [web] Fix creating subchannels in chats in GENESIS.

For now it is possible to add any user that shows up in search results. On native we handle this in the UI by showing a popup if the user wants to add someone they cannot:

image.png (1×744 px, 306 KB)

On web we decided that for now we will just not display those users. This will be handled in the next diff

Jul 10 2024, 1:13 AM
inka updated the diff for D12667: [web] Fix creating subchannels in chats in GENESIS.

Use new approach - see the discussion in ENG-8710 - we want to unify web and native

Jul 10 2024, 1:04 AM

Jul 8 2024

inka requested review of D12693: [native][web] Add fts5 extension to SQLite.
Jul 8 2024, 8:56 AM
inka accepted D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app.
Jul 8 2024, 4:46 AM
inka added a comment to D12683: [native] update connect farcaster prompt to be less annyoying.

shouldSkipPushPermissionAlert should probably be updated - if I understand correctly this diff makes it impossible for totalAlerts to exceed 1, is that correct?

Jul 8 2024, 4:43 AM
inka accepted D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Jul 8 2024, 4:29 AM
inka accepted D12681: [lib] Don't query keyserver for empty string from useThreadListSearch.

Thank you for fixing this!

Jul 8 2024, 3:29 AM

Jul 5 2024

inka closed D12674: [lib] Fix missing usernames.
Jul 5 2024, 9:27 AM
inka committed rCOMM4f33a2424c1a: [lib] Fix missing usernames (authored by inka).
[lib] Fix missing usernames
Jul 5 2024, 9:27 AM
inka planned changes to D12667: [web] Fix creating subchannels in chats in GENESIS.

On Linear, you asked whether we should check the parent or the top ancestor under GENESIS for permissions. I suggested that the top ancestor made more sense, but I probably care more about consistency with native. What do we do there?

Jul 5 2024, 2:48 AM
inka accepted D12657: [lib] Permissions for thick threads.
Jul 5 2024, 1:49 AM

Jul 4 2024

inka requested review of D12667: [web] Fix creating subchannels in chats in GENESIS.
Jul 4 2024, 8:59 AM
inka accepted D12659: [lib] Fix accidental variable naming from D12495.
Jul 4 2024, 7:02 AM
inka accepted D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.

Thank you for explaining

Jul 4 2024, 7:01 AM
inka added a comment to D12657: [lib] Permissions for thick threads.

I see that there is no CREATE_AND_EDIT_CHANNELS permissions, which lead me to finding a bug in our current app ENG-8710. Should we be able to create a subchannel of a thick thread?

Jul 4 2024, 6:56 AM
inka accepted D12660: [keyserver] Update ServerThreadInfo to only cover ThinThreadType.
Jul 4 2024, 6:11 AM
inka accepted D12656: [lib] Make it possible to skip some thread/message properties.
Jul 4 2024, 6:09 AM
inka accepted D12652: [lib] Introduce DMOperations.
Jul 4 2024, 6:08 AM
inka added inline comments to D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.
Jul 4 2024, 6:07 AM
inka accepted D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
Jul 4 2024, 4:23 AM
inka requested changes to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 4 2024, 4:15 AM
inka accepted D12641: [keyserver][lib][native] Continue storing password hash in authoritative keyserver MariaDB.

That still doesn't explain why we need to wait for some users to be updated. But I'm guessing that we want old clients, who had their accounts setup with usingCSAT=false, to update to usingCSAT=true, and get their primary device registered (a mobile device). Is this correct? How will we know that all clients have been updated?

Jul 4 2024, 3:34 AM

Jul 3 2024

inka added inline comments to D12648: [native] introduce NotificationDescription.
Jul 3 2024, 6:43 AM
inka attached a referenced file: F2175838: image.png.
Jul 3 2024, 6:43 AM
inka attached a referenced file: F2175835: image.png.
Jul 3 2024, 6:43 AM
inka added a comment to D12641: [keyserver][lib][native] Continue storing password hash in authoritative keyserver MariaDB.

We want to make sure clients from before the rollout can still auth. We'll revert this soon after launch, once all of the clients have been confirmed to be updated. We don't need to keep it around longer than that because this only concerned brand new users, and brand new users can be expected to have the most recent version of the app.

Jul 3 2024, 6:41 AM
inka added inline comments to D12648: [native] introduce NotificationDescription.
Jul 3 2024, 3:28 AM
inka accepted D12647: [native] introduce barebones UI for ThreadSettingsNotifications.
Jul 3 2024, 2:49 AM
inka accepted D12646: [lib/web] introduce useThreadSettingsNotifications.
Jul 3 2024, 2:39 AM
inka accepted D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 3 2024, 2:26 AM

Jul 1 2024

inka accepted D12632: [landing] add hover effect to button.
Jul 1 2024, 11:29 PM