Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Mon, Dec 16

angelika committed rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component (authored by angelika).

[native] Move margin getter in Tooltip to functional component

Mon, Dec 16, 1:34 PM

angelika closed D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.

Mon, Dec 16, 1:34 PM

angelika committed rCOMMa5611d3ba62e: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API (authored by angelika).

[native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API

Mon, Dec 16, 1:34 PM

angelika closed D14102: [native] Introduce positionsV2 values in OverlayNavigator.

Mon, Dec 16, 1:34 PM

angelika closed D14099: [native] Add reanimated makeMutable function type.

Mon, Dec 16, 1:34 PM

angelika committed rCOMM78c5b78ee76d: [native] Add reanimated makeMutable function type (authored by angelika).

[native] Add reanimated makeMutable function type

Mon, Dec 16, 1:34 PM

angelika committed rCOMM51fd3ffa71d0: [native] Introduce positionsV2 values in OverlayNavigator (authored by angelika).

[native] Introduce positionsV2 values in OverlayNavigator

Mon, Dec 16, 1:34 PM

angelika closed D14098: [native] Fix reanimated cancelAnimation flow type.

Mon, Dec 16, 1:34 PM

angelika committed rCOMMe42de0724ee9: [native] Fix reanimated cancelAnimation flow type (authored by angelika).

[native] Fix reanimated cancelAnimation flow type

Mon, Dec 16, 1:34 PM

ashoat requested review of D14160: [lib] Add log and continue in getPushUserInfo when thread missing from ThreadStore.

Mon, Dec 16, 11:09 AM

kamil requested changes to D14148: [native] Handler for migrating to signed device lists.

Mon, Dec 16, 9:00 AM

kamil accepted D14088: [identity] Verify new flow migration device list update.

Mon, Dec 16, 8:33 AM

bartek closed D14147: [native][web] Merge logout buttons for old and new flows.

Mon, Dec 16, 6:48 AM

bartek committed rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows (authored by bartek).

[native][web] Merge logout buttons for old and new flows

Mon, Dec 16, 6:48 AM

bartek closed D14146: [native] Enable linked devices screen when using restore flow.

Mon, Dec 16, 6:48 AM

bartek committed rCOMMd0002b3eff79: [native] Enable linked devices screen when using restore flow (authored by bartek).

[native] Enable linked devices screen when using restore flow

Mon, Dec 16, 6:48 AM

bartek added inline comments to D14147: [native][web] Merge logout buttons for old and new flows.

Mon, Dec 16, 6:45 AM

Harbormaster failed remote builds in B33132: Diff 46473 for D14113: [native] Enable Flow types in Reanimated worklets!

Mon, Dec 16, 6:41 AM

ashoat added inline comments to D14148: [native] Handler for migrating to signed device lists.

Mon, Dec 16, 6:40 AM

angelika updated the diff for D14135: [native] Move render function in MultimediaMessageMultimedia to functional component.

Rebase

Mon, Dec 16, 6:26 AM

angelika updated the diff for D14135: [native] Move render function in MultimediaMessageMultimedia to functional component.

Rebase

Mon, Dec 16, 6:25 AM

angelika updated the diff for D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.

Rebase

Mon, Dec 16, 6:25 AM

angelika updated the diff for D14133: [native] Migrate opacity in MultimediaMessageMultimedia to Reanimated v2 API in functional component.

Rebase

Mon, Dec 16, 6:25 AM

angelika updated the diff for D14132: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to functional component.

Rebase

Mon, Dec 16, 6:25 AM

angelika updated the diff for D14131: [native] Move view ref in MultimediaMessageMultimedia to functional component.

Rebase

Mon, Dec 16, 6:24 AM

angelika updated the diff for D14130: [native] Migrate ActionResultModal component to Reanimated v2 API.

Rebase

Mon, Dec 16, 6:24 AM

angelika updated the diff for D14129: [native] Workarounds for bugs after reanimated migration.

Rebase

Mon, Dec 16, 6:24 AM

angelika updated the diff for D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:24 AM

angelika updated the diff for D14127: [native] Remove progress prop from tooltip buttons components.

Rebase

Mon, Dec 16, 6:24 AM

angelika updated the diff for D14126: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:23 AM

angelika updated the diff for D14125: [native] Migrate MultimediaMessageTooltipButton component to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:23 AM

angelika updated the diff for D14124: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:23 AM

angelika updated the diff for D14123: [native] Migrate TooltipInlineEngagement to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:23 AM

angelika updated the diff for D14122: [native] Migrate TextMessageTooltipButton to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:22 AM

angelika updated the diff for D14121: [native] Remove progress parameter from useAnimatedMessageTooltipButton.

Rebase

Mon, Dec 16, 6:22 AM

angelika updated the diff for D14120: [native] Migrate threadColorOverride in useAnimatedMessageTooltipButton to Reanimate V2 API.

Rebase

Mon, Dec 16, 6:22 AM

angelika updated the diff for D14119: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API.

Rebase

Mon, Dec 16, 6:22 AM

angelika updated the diff for D14118: [native] Add progressV2 field to tooltip button types.

Rebase

Mon, Dec 16, 6:22 AM

angelika updated the diff for D14117: [native] Migrate Tooltip component to Reanimated v2 API.

Rebase

Mon, Dec 16, 6:21 AM

angelika updated the diff for D14113: [native] Enable Flow types in Reanimated worklets.

Rebase

Mon, Dec 16, 6:21 AM

angelika updated the diff for D14112: [native] Move render function from Tooltip to functional component.

Rebase

Mon, Dec 16, 6:21 AM

angelika updated the diff for D14111: [native] Move methods from Tooltip to functional compononent.

Rebase

Mon, Dec 16, 6:21 AM

angelika updated the diff for D14110: [native] Move haptics in Tooltip to functional compononent.

Rebase

Mon, Dec 16, 6:20 AM

angelika updated the diff for D14109: [native] Move styles in Tooltip to functional component.

Rebase

Mon, Dec 16, 6:20 AM

angelika updated the diff for D14108: [native] Move Reanimated nodes in Tooltip to functional component.

Rebase

Mon, Dec 16, 6:20 AM

angelika updated the diff for D14107: [native] Move tooltip location getter in Tooltip to functional component.

Rebase

Mon, Dec 16, 6:20 AM

angelika updated the diff for D14106: [native] Move tooltip height getter in Tooltip to functional component.

Rebase

Mon, Dec 16, 6:19 AM

angelika updated the diff for D14104: [native] Move margin getter in Tooltip to functional component.

Rebase

Mon, Dec 16, 6:19 AM

tomek added a comment to D14149: [native] implement screen after secondary device is connected.

In D14149#394407, @ashoat wrote:

Thanks for the videos, @kamil. I guess I'm leaning towards the existing code now... the whitespace seems less confusing in the video. Curious for @kamil and @tomek's takes, but if you guys agree we can keep it as-is.

Mon, Dec 16, 6:19 AM

angelika updated the diff for D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.

Rebase

Mon, Dec 16, 6:19 AM

angelika updated the diff for D14102: [native] Introduce positionsV2 values in OverlayNavigator.

Rebase

Mon, Dec 16, 6:19 AM

angelika updated the diff for D14099: [native] Add reanimated makeMutable function type.

Rebase

Mon, Dec 16, 6:19 AM

angelika updated the diff for D14098: [native] Fix reanimated cancelAnimation flow type.

Rebase

Mon, Dec 16, 6:18 AM

bartek published D14148: [native] Handler for migrating to signed device lists for review.

Mon, Dec 16, 6:18 AM

ashoat accepted D14159: [native] replace back button with close button on the scanning QR code screen.

Mon, Dec 16, 6:10 AM

bartek updated the test plan for D14088: [identity] Verify new flow migration device list update.

Mon, Dec 16, 6:04 AM

ashoat accepted D14149: [native] implement screen after secondary device is connected.

Thanks for the videos, @kamil. I guess I'm leaning towards the existing code now... the whitespace seems less confusing in the video. Curious for @kamil and @tomek's takes, but if you guys agree we can keep it as-is.

Mon, Dec 16, 6:03 AM

kamil accepted D14147: [native][web] Merge logout buttons for old and new flows.

Mon, Dec 16, 6:02 AM

bartek published D14088: [identity] Verify new flow migration device list update for review.

Mon, Dec 16, 4:24 AM

kamil published D14159: [native] replace back button with close button on the scanning QR code screen for review.

Mon, Dec 16, 3:40 AM

kamil attached a referenced file: F3472480: IMG_4788 (1) (1).PNG.

Mon, Dec 16, 2:46 AM

kamil attached a referenced file: F3472484: ScreenRecording_12-16-2024 11-28-59_1.MP4.

Mon, Dec 16, 2:46 AM

kamil attached a referenced file: F3472503: IMG_4823.PNG.

Mon, Dec 16, 2:46 AM

kamil attached a referenced file: F3472504: ScreenRecording_12-16-2024 11-36-42_1.MP4.

Mon, Dec 16, 2:46 AM

kamil requested review of D14149: [native] implement screen after secondary device is connected.

Mon, Dec 16, 2:45 AM

kamil accepted D14146: [native] Enable linked devices screen when using restore flow.

Mon, Dec 16, 1:30 AM

Sat, Dec 14

GitHub <noreply@github.com> committed rCOMM1affa7c032ad: Update README.md (authored by ashoat).

Update README.md

Sat, Dec 14, 9:03 AM

GitHub <noreply@github.com> committed rCOMM9af35fc18d26: Update README.md (authored by ashoat).

Update README.md

Sat, Dec 14, 9:01 AM

Fri, Dec 13

ashoat added inline comments to D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.

Fri, Dec 13, 6:38 PM

ashoat added inline comments to D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.

Fri, Dec 13, 6:36 PM

ashoat added inline comments to D14111: [native] Move methods from Tooltip to functional compononent.

Fri, Dec 13, 6:35 PM

ashoat added a comment to D13994: [native] community list item component.

Talked about this offline – I was wrong in much of my assessment above. We paired after lunch, and afterwards Varun figured out a way forward to unblock the work

Fri, Dec 13, 6:33 PM

ashoat committed rCOMM9d08a8bc2f2a: [keyserver] Fix up get-community-ids.js script (authored by ashoat).

[keyserver] Fix up get-community-ids.js script

Fri, Dec 13, 6:19 PM

ashoat committed rCOMM7c243ccfcc62: [terraform] Bump keyserver image to 1.0.147 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.147

Fri, Dec 13, 6:19 PM

ashoat committed rCOMM319fbd03c8a1: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Fri, Dec 13, 5:31 PM

ashoat added a reverting change for rCOMM42ecbbea1546: [native] Temporary changes for staff release: rCOMM319fbd03c8a1: Revert "[native] Temporary changes for staff release".

Fri, Dec 13, 5:31 PM

ashoat committed rCOMMfe196394030f: [native] codeVersion -> 450 (authored by ashoat).

[native] codeVersion -> 450

Fri, Dec 13, 5:31 PM

ashoat committed rCOMM42ecbbea1546: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Fri, Dec 13, 5:31 PM

ashoat committed rCOMM23680c59afc2: [native] codeVersion -> 449 (authored by ashoat).

[native] codeVersion -> 449

Fri, Dec 13, 5:31 PM

ashoat committed rCOMM9ad082c5893a: [web][keyserver] codeVersion -> 147 (authored by ashoat).

[web][keyserver] codeVersion -> 147

Fri, Dec 13, 5:31 PM

ashoat committed rCOMM7ea5fde4254d: [lib] Minor optimizations to getCandidateSidebarItemsForThreadList (authored by ashoat).

[lib] Minor optimizations to getCandidateSidebarItemsForThreadList

Fri, Dec 13, 5:31 PM

ashoat closed D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.

Fri, Dec 13, 4:37 PM

ashoat closed D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.

Fri, Dec 13, 4:37 PM

ashoat committed rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList (authored by ashoat).

[lib] Deduplicate in getCandidateSidebarItemsForThreadList

Fri, Dec 13, 4:37 PM

ashoat committed rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars (authored by ashoat).

[lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars

Fri, Dec 13, 4:37 PM

ashoat closed D14156: [lib] Fix stack overflow from lastUpdatedTime.

Fri, Dec 13, 4:36 PM

ashoat committed rCOMM730c48dec5a5: [lib] Fix stack overflow from lastUpdatedTime (authored by ashoat).

[lib] Fix stack overflow from lastUpdatedTime

Fri, Dec 13, 4:36 PM

varun accepted D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.

Fri, Dec 13, 4:05 PM

varun accepted D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.

Fri, Dec 13, 4:05 PM

ashoat published D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:58 PM

ashoat published D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:57 PM

ashoat added inline comments to D13996: [native] community joiner modal.

Fri, Dec 13, 1:21 PM

ashoat accepted D14155: [native] Delete console log.

Fri, Dec 13, 11:56 AM

tomek requested review of D14155: [native] Delete console log.

Fri, Dec 13, 10:18 AM

will accepted D14156: [lib] Fix stack overflow from lastUpdatedTime.

Fri, Dec 13, 10:17 AM

ashoat published D14156: [lib] Fix stack overflow from lastUpdatedTime for review.

Will wait for relevant CI before landing

Fri, Dec 13, 9:09 AM

varun added inline comments to D13994: [native] community list item component.

Fri, Dec 13, 8:56 AM

ashoat added a comment to D13994: [native] community list item component.

Also: in the screenshot you shared, the vertical padding seems uneven between top / bottom

Fri, Dec 13, 8:30 AM

ashoat requested changes to D13994: [native] community list item component.

Can you share updated videos of how this looks in both dark mode and light mode?

Fri, Dec 13, 8:29 AM

varun added a comment to D13994: [native] community list item component.

Latest look at the modal with the redesigned CommunityListItem component

Fri, Dec 13, 8:29 AM