Page MenuHomePhorge
Feed Search

May 26 2025

bartek accepted D14742: [SQLite] move `getSyncedDatabaseVersion` to `SQLiteUtils`.
May 26 2025, 9:22 AM
bartek accepted D14741: [SQLite] extract method to copy content between databases.

👍 for the tests

May 26 2025, 9:19 AM
bartek accepted D14739: [SQLite] make `connectionManager` private and use abstract class.

I am also considering renaming:
NativeSQLiteConnectionManager -> EncryptedSQLiteConnectionManager
WebSQLiteConnectionManager -> NotEncryptedConnectionManager

This perhaps makes it even more readable and more platform-independent.

May 26 2025, 9:10 AM
bartek requested changes to D14734: [SQLite] make `connectionManager` to be local prop `SQLiteQueryExecutor` and move management to `DatabaseManager`.

Feel free to re-request if I'm wrong

May 26 2025, 9:08 AM
bartek accepted D14756: [lib] Broadcast account deletion message after verifying the password.
May 26 2025, 9:07 AM
bartek published D14757: [terraform] Deploy services to prod for review.
May 26 2025, 8:49 AM

May 23 2025

bartek accepted D14738: [SQLite] move starting log monitoring to `DatabaseManager`.
May 23 2025, 12:02 PM
bartek accepted D14735: [SQLite] move database path and keys to `SQLiteConnectionManager` and derived classes.

It feels like it's the correct place for sqliteFilePath, it's much cleaner now

May 23 2025, 11:58 AM
bartek accepted D14737: [SQLite] remove `initializeConnection` from `SQLiteQueryExecutor` constructor.
May 23 2025, 11:56 AM
bartek accepted D14736: [SQLite] make `getConnection` private.
May 23 2025, 11:55 AM
bartek accepted D14733: [SQLite] mark connection getters `const`.
May 23 2025, 9:32 AM
bartek accepted D14732: [SQLite] make `SQLiteQueryExecutor::getConnection` to be non-static.
May 23 2025, 9:31 AM
bartek requested changes to D14730: [SQLite] move `validateEncryption` to `SQLiteConnectionManager`.
May 23 2025, 9:23 AM
bartek accepted D14731: [SQLite] make `migrate` non-static.
May 23 2025, 9:22 AM

May 22 2025

bartek accepted D14728: [SQLite] move `createMainCompaction` to `DatabaseManager`.
May 22 2025, 10:57 AM
bartek accepted D14727: [SQLite] move `cleanupDatabaseExceptAllowlist` and `getAllTableNames` to a better places.
May 22 2025, 10:56 AM
bartek accepted D14726: [SQLite] move `triggerBackupFileUpload` to `DatabaseManager`.
May 22 2025, 10:51 AM
bartek accepted D14725: [SQLite] move `captureBackupLogs` to `DatabaseManager`.
May 22 2025, 10:50 AM
bartek accepted D14729: [SQLite] remove `initialize` method.
May 22 2025, 9:14 AM
bartek accepted D14724: [SQLite] move `clearSensitiveData` to `DatabaseManager`.

Generally, what do you think about renaming clearSensitiveData() to indicate it also creates a fresh, clean DB? E.g. something like clearDataAndRecreateDB()?

May 22 2025, 7:54 AM
bartek accepted D14723: [SQLite] move `setUserDataKeys` to `DatabaseManager`.
May 22 2025, 7:50 AM
bartek accepted D14721: [SQLite] make functions in `EntityQueryHelpers.h` inline.

Alternative is to move implementation to .cpp file, but not sure if this is worth it, I think the compiler will optimize it anyway, and I don't think this is worse in terms of readability.

May 22 2025, 7:49 AM
bartek accepted D14720: [SQLite] temporary make `SQLiteQueryExecutor` methods and fields public.

This is temporary to make refactoring possible, next diffs could either not build or have incorrect logic without this. Later in the stack, this is updated to be private again.

May 22 2025, 7:39 AM
bartek accepted D14719: [SQLite] remove old architecture comments.
May 22 2025, 7:37 AM
bartek accepted D14718: [SQLite] move key generation to `DatabaseManager`.

This slightly affects ENG-10519 but makes it easier. I'd still decouple plain key generation from storing it in SecureStore, but it makes more sense for me to do it when working on rekeying

May 22 2025, 7:36 AM
bartek accepted D14722: [SQLite] extract `rekeyDatabase` function.

Thanks, this makes ENG 10521 trivial

May 22 2025, 7:34 AM
bartek accepted D14740: [lib] Debounce new OTKs response.
May 22 2025, 7:26 AM

May 21 2025

bartek accepted D14717: [SQLite] fix and improve `generateBackupDataKey`.

I agree this was misleading, I was confused too when scoping rekeying the database.

May 21 2025, 8:19 AM
bartek accepted D14716: [native][DatabaseManager] rename `initialized` -> `queryExecutorCreationIndicated`.
May 21 2025, 8:14 AM

May 20 2025

bartek closed D14715: [comm-lib] Fix restore flow for non-deployed backup.
May 20 2025, 10:52 AM
bartek committed rCOMM3d1afa738a4d: [comm-lib] Fix restore flow for non-deployed backup.
May 20 2025, 10:52 AM
bartek published D14715: [comm-lib] Fix restore flow for non-deployed backup for review.

Perhaps I should revert this in D14675

May 20 2025, 10:37 AM

May 19 2025

bartek closed D14714: [terraform] Bump staging services.
May 19 2025, 2:32 PM
bartek committed rCOMMabcc00d0f933: [terraform] Bump staging services.
May 19 2025, 2:32 PM
bartek published D14714: [terraform] Bump staging services for review.
May 19 2025, 2:21 PM
bartek closed D14709: [backup] Make BadRequest errors meaningful.
May 19 2025, 1:52 PM
bartek closed D14708: [backup] Improve logging.
May 19 2025, 1:52 PM
bartek closed D14706: [native][backup] Pass version info with backup upload.
May 19 2025, 1:52 PM
bartek committed rCOMM13de950d76a5: [backup] Make BadRequest errors meaningful.
May 19 2025, 1:52 PM
bartek committed rCOMMb1231900383e: [backup] Improve logging.
May 19 2025, 1:52 PM
bartek committed rCOMMb768ae10ab7d: [native][backup] Pass version info with backup upload.
May 19 2025, 1:52 PM
bartek closed D14704: [backup][terraform] Add size and version info to OrderedBackupItem.
May 19 2025, 1:52 PM
bartek closed D14705: [backup] Refactor multipart to process multiple optional fields.
May 19 2025, 1:52 PM
bartek committed rCOMM3f6181152184: [backup] Refactor multipart to process multiple optional fields.
May 19 2025, 1:52 PM
bartek committed rCOMM2afe3286dacb: [backup][terraform] Add size and version info to OrderedBackupItem.
May 19 2025, 1:52 PM
bartek closed D14699: [comm-lib] Store backup size and version in DDB.
May 19 2025, 1:52 PM
bartek closed D14698: [comm-lib] Add size and version info fields to BackupItem.
May 19 2025, 1:52 PM
bartek committed rCOMMbad36a7ebc04: [comm-lib] Store backup size and version in DDB.
May 19 2025, 1:52 PM
bartek committed rCOMMca3685792c4c: [comm-lib] Add size and version info fields to BackupItem.
May 19 2025, 1:52 PM
bartek accepted D14713: [native] Respect the session overriding.
May 19 2025, 1:39 PM
bartek updated the test plan for D14675: [native] Pass backup size, timestamp and version info to JS.
May 19 2025, 1:31 PM
bartek updated the test plan for D14706: [native][backup] Pass version info with backup upload.
May 19 2025, 1:30 PM

May 16 2025

bartek closed D14687: [backup] Replace retrieved backups warn with cursor scan.
May 16 2025, 1:36 PM
bartek committed rCOMM6929d6039e97: [backup] Replace retrieved backups warn with cursor scan.
May 16 2025, 1:36 PM
bartek closed D14686: [backup] Add config option to keep old backups.
May 16 2025, 1:36 PM
bartek committed rCOMMacc11da1b817: [backup] Add config option to keep old backups.
May 16 2025, 1:35 PM
bartek closed D14684: [backup] Create function to copy logs between backups.
May 16 2025, 1:35 PM
bartek closed D14685: [backup] Copy logs during UserKeys backup.
May 16 2025, 1:35 PM
bartek closed D14683: [backup] Remove redundant blob client auth.
May 16 2025, 1:35 PM
bartek committed rCOMM3a73b0707b98: [backup] Copy logs during UserKeys backup.
May 16 2025, 1:35 PM
bartek committed rCOMMf99c0fb93647: [backup] Create function to copy logs between backups.
May 16 2025, 1:35 PM
bartek committed rCOMMb62017b8b437: [backup] Remove redundant blob client auth.
May 16 2025, 1:35 PM
bartek closed D14682: [backup] Refactor HTTP handler utility functions.
May 16 2025, 1:35 PM
bartek closed D14681: [blob-client] Add assign_multiple_holders_with_retries.
May 16 2025, 1:35 PM
bartek committed rCOMM9766bca6af07: [backup] Refactor HTTP handler utility functions.
May 16 2025, 1:35 PM
bartek committed rCOMMf8cf0691b6ee: [blob-client] Add assign_multiple_holders_with_retries.
May 16 2025, 1:35 PM
bartek closed D14680: [comm-lib] Move exponential backoff helper to a separate mod.
May 16 2025, 1:35 PM
bartek committed rCOMM2c9470498df6: [comm-lib] Move exponential backoff helper to a separate mod.
May 16 2025, 1:35 PM
bartek closed D14676: [blob-client] Add method to assign multiple holders.
May 16 2025, 1:35 PM
bartek committed rCOMMc36577e18164: [blob-client] Add method to assign multiple holders.
May 16 2025, 1:35 PM
bartek closed D14674: [backup] Return backup size and timestamp in LatestBackupInfo.
May 16 2025, 1:35 PM
bartek committed rCOMMeb8b73616e6d: [backup] Return backup size and timestamp in LatestBackupInfo.
May 16 2025, 1:35 PM
bartek closed D14673: [backup] Refactor DDB log fetch functions.
May 16 2025, 1:35 PM
bartek committed rCOMMde3e8ea25e2a: [backup] Refactor DDB log fetch functions.
May 16 2025, 1:35 PM
bartek closed D14672: [blob] Handle size for missing S3 objects.
May 16 2025, 1:35 PM
bartek committed rCOMM77823b87938d: [blob] Handle size for missing S3 objects.
May 16 2025, 1:35 PM
bartek published D14708: [backup] Improve logging for review.
May 16 2025, 9:28 AM
bartek published D14709: [backup] Make BadRequest errors meaningful for review.
May 16 2025, 9:28 AM
bartek published D14675: [native] Pass backup size, timestamp and version info to JS for review.
May 16 2025, 9:24 AM
bartek published D14706: [native][backup] Pass version info with backup upload for review.
May 16 2025, 8:56 AM
bartek published D14705: [backup] Refactor multipart to process multiple optional fields for review.

This only partially resolves issue with optional fields and their order, they still have to be processed after get_aux_data(), and get_aux_data() has to be called after any forward_field_to_blob() calls.
A proper solution requires redesigning multipart handling from scratch and is described in ENG-10773

May 16 2025, 8:50 AM
bartek published D14704: [backup][terraform] Add size and version info to OrderedBackupItem for review.
May 16 2025, 8:09 AM

May 15 2025

bartek updated the diff for D14698: [comm-lib] Add size and version info fields to BackupItem.

Use camel case for version info

May 15 2025, 3:37 PM
bartek updated the diff for D14699: [comm-lib] Store backup size and version in DDB.

Fix attrs

May 15 2025, 12:28 PM
bartek updated the diff for D14698: [comm-lib] Add size and version info fields to BackupItem.

Typo

May 15 2025, 12:27 PM
bartek updated the diff for D14684: [backup] Create function to copy logs between backups.

Typo

May 15 2025, 12:23 PM
bartek updated the diff for D14681: [blob-client] Add assign_multiple_holders_with_retries.

Apply fix

May 15 2025, 12:22 PM
bartek updated the diff for D14676: [blob-client] Add method to assign multiple holders.

Use alternative syntax

May 15 2025, 12:20 PM
bartek published D14699: [comm-lib] Store backup size and version in DDB for review.
May 15 2025, 8:02 AM
bartek published D14698: [comm-lib] Add size and version info fields to BackupItem for review.
May 15 2025, 8:02 AM

May 13 2025

bartek accepted D14671: [SQLite] remove web-specific code.

It's always satisfying to see this much of code being removed

May 13 2025, 6:57 AM
bartek accepted D14670: [web] deprecate using `getOlmPersistAccountDataWeb`.
May 13 2025, 6:54 AM
bartek accepted D14669: [web] deprecate using `*MessageWeb` methods and use shared implementation with native.
May 13 2025, 6:52 AM
bartek accepted D14668: [web][native] convert `MessageEntity` to struct.
May 13 2025, 6:50 AM
bartek accepted D14667: [web] deprecate using `*ThreadWeb` methods and use shared implementation with native.
May 13 2025, 6:43 AM

May 12 2025

bartek closed D14592: [keyserver] Bump min client version to match Identity Service.
May 12 2025, 2:41 PM
bartek committed rCOMM21d612af49dc: [keyserver] Bump min client version to match Identity Service.
May 12 2025, 2:40 PM
bartek published D14687: [backup] Replace retrieved backups warn with cursor scan for review.
May 12 2025, 1:14 PM
bartek published D14686: [backup] Add config option to keep old backups for review.
May 12 2025, 1:13 PM
bartek accepted D14666: [SQLite] convert smart pointers to `std::optional` to represent nullable value in entities.

Nice!

May 12 2025, 12:50 PM