👍 for the tests
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
May 26 2025
I am also considering renaming:
NativeSQLiteConnectionManager -> EncryptedSQLiteConnectionManager
WebSQLiteConnectionManager -> NotEncryptedConnectionManagerThis perhaps makes it even more readable and more platform-independent.
Feel free to re-request if I'm wrong
May 23 2025
It feels like it's the correct place for sqliteFilePath, it's much cleaner now
May 22 2025
Generally, what do you think about renaming clearSensitiveData() to indicate it also creates a fresh, clean DB? E.g. something like clearDataAndRecreateDB()?
Alternative is to move implementation to .cpp file, but not sure if this is worth it, I think the compiler will optimize it anyway, and I don't think this is worse in terms of readability.
This is temporary to make refactoring possible, next diffs could either not build or have incorrect logic without this. Later in the stack, this is updated to be private again.
This slightly affects ENG-10519 but makes it easier. I'd still decouple plain key generation from storing it in SecureStore, but it makes more sense for me to do it when working on rekeying
Thanks, this makes ENG 10521 trivial
May 21 2025
I agree this was misleading, I was confused too when scoping rekeying the database.
May 20 2025
Perhaps I should revert this in D14675
May 19 2025
May 16 2025
This only partially resolves issue with optional fields and their order, they still have to be processed after get_aux_data(), and get_aux_data() has to be called after any forward_field_to_blob() calls.
A proper solution requires redesigning multipart handling from scratch and is described in ENG-10773
May 15 2025
Use camel case for version info
Fix attrs
Typo
Typo
Apply fix
Use alternative syntax
May 13 2025
It's always satisfying to see this much of code being removed