wondering if we should also update the type to avoid things like this

I will be extending this to handle backup service in the near future, do you think we should have a separate configuration json file per service?

docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"

Much better with the naming change

Could you also quickly test if everything works if someone is using an older version of the desktop app, one that doesn't advertise its version (you can just comment out the desktop version line in registerConfig)?

You can just run yarn dev and open the hosted website on http://localhost:80. I checked your typo fix and the website correctly shows our repository and displays the newest desktop version (9).

Fix mistake during rebase

Rebase

Rebase

Rebase

I'm starting to consider the global static CONFIG as an anti-pattern.

Remove cryptoThread from restore function and return restored olm account information.

Overall LGTM, just a few questions

There are a few issues with this (but they should be easily fixable):

1. You are registering a callback on ipcMain everytime a window is loaded. This wouldn't be a problem in Windows but on macOS you can close the window without closing the app. Then if you would open a window again you would register another callback.
2. The callbacks themselves use the main window variable which will stop being valid after the window is closed. So the previously registered callbacks will probably throw an error after re-opening the window.

Update for flow 202

Update for flow 202

Rebase

Rebase

Rebase

Fix position of the variable, it was a mistake - I extracted the handler function but didn't move the variable declaration with it.

An issue with with non-static methods calling the static methods is that the ByteBuffer -> SecretKeySpec conversion must go through ByteArray (with a copy). So that means that we would have ByteArray -no-copy-> ByteBuffer -with-copy-> ByteArray -> SecretKeySpec. As the static methods are very minimal and most of the code is in encryptAES/ decryptAES functions I don't it's worth it.

Fix naming

Rebase after a new approach to error handling

Improve error handling

Accepting, but please fix the issues in inline comments.

Fix line lengths

Some suggestions in inline comments, but looks good to me either way