land
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Dec 14 2023
Dec 14 2023
atul updated the diff for D10284: [native] Update `updateRolesAndPermissions` to only handle `LegacyRawThreadInfos`.
Looks like @inka is giving this a thorough review, so resigning to remove from queue. Feel free to re-assign me as reviewer if there's something specific I can be useful with.
atul added a comment to D10280: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`.
In D10280#299275, @ashoat wrote:Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)
atul added a comment to D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.
In D10274#299272, @ashoat wrote:Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)
atul published D10340: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners for review.
atul added inline comments to D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
maintain previous order w/ unshift/push
This does mean that we wouldn't catch it if eg. there was some new non-Cargo dependency in the blob service that wasn't in the Nix environment
Dec 13 2023
Dec 13 2023
atul updated the diff for D10297: [native] Redux migration to support minimally encoded permissions.
final rebase pass
atul updated the diff for D10295: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.
final rebase pass
atul updated the diff for D10294: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`.
last rebase pass
atul updated the diff for D10286: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option.
last rebase pass
atul updated the diff for D10285: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument.
address feedback
atul added inline comments to D10285: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument.
atul updated the diff for D10284: [native] Update `updateRolesAndPermissions` to only handle `LegacyRawThreadInfos`.
final rebase pass
atul updated the diff for D10283: [lib] Update `convertThreadStoreThreadInfosToNewIDSchema` migration to ensure `rawThreadInfos` are NOT minimally encoded.
address feedback: more specific invariant message
atul updated the diff for D10281: [native] Introduce `assertAllThreadInfosAreLegacy` to address migration 29 `flow` issues.
address feedback
atul updated the diff for D10280: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`.
last rebase pass
last rebase pass
atul updated the diff for D10277: [web] Update `validateStateAndProcessDBOperations` to handle `RawThreadInfos`.
last rebase pass
atul updated the diff for D10275: [lib] Update remaining places in `lib` to support `RawThreadInfos`.
last rebase pass
atul updated the diff for D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.
will address these flow refactors at the end of the stack.
atul updated the diff for D10271: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease `flow`.
address feedback
atul added inline comments to D10271: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease `flow`.
atul updated the diff for D10270: [lib] Add ridiculous branching to `delete-account-spec` to appease `flow`.
final rebase pass
atul updated the diff for D10268: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`.
final rebase pass
final rebase pass
atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
preemptively fix flow issue that pops up later in stack because of changes to this diff
atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
final rebase pass
atul updated the diff for D10195: [lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo`.
final rebase pass
atul abandoned D10272: [lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`.
No longer needed.
atul added inline comments to D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
atul retitled D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants from [lib] Introduce separate `Legacy` and `MinimallyEncoded` variants of `getRelativeMemberInfos`
atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.
Use @ashoat's implementation of getRelativeMemberInfos instead of splitting into two
atul updated the diff for D10295: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.
land
atul updated the diff for D10314: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `ThreadCurrentUserInfo`.
land
atul updated the diff for D10313: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s.
shorter invariant message
atul updated the diff for D10298: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `MemberInfo`s.
shorter invariant message
atul updated the diff for D10313: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s.
collapse loops
atul updated the diff for D10298: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `MemberInfo`s.
address feedback: merge loops
atul updated the diff for D10210: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.
land what's easy/safe to land to reduce stack
atul updated the diff for D10223: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.
fix and re-land
atul updated the diff for D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.
re-land
atul updated the diff for D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.
fix up and re-land