In D11099#321944, @atul wrote:In D11099#320649, @tomek wrote:What is the downside of making this diff a draft instead of marking its title with a label?
Would that still make the diff viewable to reviewers?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 23 2024
Feb 23 2024
tomek added inline comments to D11100: [native] call identity wallet login from ExistingEthereumAccount.
Feb 22 2024
Feb 22 2024
Fix tests by introducing a jest mock
tomek committed rCOMM2dbf61f82bd9: [lib] Add a keyserverID to an action payload (authored by tomek).
[lib] Add a keyserverID to an action payload
tomek committed rCOMMd4354fe394cb: [lib] Filter out calendar filters that use threads from a different keyserver (authored by tomek).
[lib] Filter out calendar filters that use threads from a different keyserver
tomek committed rCOMMa113da46cf5b: [lib] Add a keyserverID prop to calendar-query-handler (authored by tomek).
[lib] Add a keyserverID prop to calendar-query-handler
tomek committed rCOMMe7e0ab0d4326: [lib] Modify update calendar query so that it can update a subset of keyservers (authored by tomek).
[lib] Modify update calendar query so that it can update a subset of keyservers
tomek committed rCOMM923b18209893: [lib] Make update-handler keyserver-specific (authored by tomek).
[lib] Make update-handler keyserver-specific
tomek committed rCOMM96972d4180cf: [lib] Make activity-handler keyserver-specific (authored by tomek).
[lib] Make activity-handler keyserver-specific
tomek committed rCOMMf5e11bdfcd79: [lib] Make api-request-handler keyserver-specific (authored by tomek).
[lib] Make api-request-handler keyserver-specific
Feb 21 2024
Feb 21 2024
[native] Don't dispatch an undefined token
I think that keeping the solution as symmetrical as possible is a good idea. In this case, we should probably add it to IdentityServiceClient. If we can expose it also on native, it would be even better. And we should determine why there's an asymmetry of how the keys are uploaded and ideally make it consistent.
tomek added inline comments to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
tomek added inline comments to D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 20 2024
Feb 20 2024
Move map to a context
Feb 19 2024
Feb 19 2024
tomek committed rCOMM139f31894526: Add an ESLint rule that check filename format (authored by tomek).
Add an ESLint rule that check filename format
Rebase
Feb 16 2024
Feb 16 2024
What is the downside of making this diff a draft instead of marking its title with a label?
Could you link to the code that you're reintroducing?
Feb 15 2024
Feb 15 2024
tomek added a comment to D11088: [keyserver] Log the exception when failing to synchronize links with blobs.
In D11088#320294, @ashoat wrote:The synchronizeInviteLinksWithBlobs.js filename does not follow conventions in our codebase. We should maintain consistent file naming conventions. @tomek, can you do an audit of the invite links code to make sure we match file naming conventions with the rest of the codebase? Would be great if you could create a task to track
It wasn't intentional. Thanks for fixing it!
tomek committed rCOMMe3478a83cfbb: [keyserver] Log the exception when failing to synchronize links with blobs (authored by tomek).
[keyserver] Log the exception when failing to synchronize links with blobs
tomek requested review of D11088: [keyserver] Log the exception when failing to synchronize links with blobs.
Feb 14 2024
Feb 14 2024
Wondering if we can perform the init logic in C++ instead so that it can be shared between platforms.
tomek committed rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration (authored by tomek).
[keyserver] Create invite link blobs in a migration
tomek committed rCOMM6ca2c4c7d692: [blob] Block reserved and offensive links from being created (authored by tomek).
[blob] Block reserved and offensive links from being created
tomek committed rCOMMa9789dfca6ae: [services] Move reserved_usernames to `shared` (authored by tomek).
[services] Move reserved_usernames to `shared`
tomek committed rCOMMac08dc316650: [lib] Join a community on an overridden keyserver (authored by tomek).
[lib] Join a community on an overridden keyserver
tomek committed rCOMMfd4b74535fd1: [web][native] Download invite link blob and use it as an override (authored by tomek).
[web][native] Download invite link blob and use it as an override
tomek committed rCOMM097836906978: [native][web][lib] Extract common invite link logic (authored by tomek).
[native][web][lib] Extract common invite link logic
tomek committed rCOMMf8c21d9c0755: [keyserver] Modify link verification so that it works with users that aren't… (authored by tomek).
[keyserver] Modify link verification so that it works with users that aren't…
tomek committed rCOMM5b19e0d189b7: [lib] Do not provide overrides when we already know a keyserver (authored by tomek).
[lib] Do not provide overrides when we already know a keyserver
tomek committed rCOMM3437898f7c90: [lib] Modify link verification to call the proper keyserver (authored by tomek).
[lib] Modify link verification to call the proper keyserver
tomek committed rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs (authored by tomek).
[keyserver] Set a job that synchronizes links with blobs
tomek committed rCOMM1131d2bb421a: [keyserver] Add a function that synchronizes keyserver's invite links with blobs (authored by tomek).
[keyserver] Add a function that synchronizes keyserver's invite links with blobs
tomek committed rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links (authored by tomek).
[keyserver] Introduce a function that allows fetching all the primary links