Page MenuHomePhabricator
Feed Advanced Search

Wed, Jun 12

varun requested review of D12401: [identity] dedup "unexpected message data" tonic message.
Wed, Jun 12, 8:28 AM

Mon, Jun 10

varun closed D12385: [native] add autoCapitalize="none".
Mon, Jun 10, 2:05 PM
varun committed rCOMMa936d5f5ebac: [native] add autoCapitalize="none" (authored by varun).
[native] add autoCapitalize="none"
Mon, Jun 10, 2:05 PM
varun updated the test plan for D12385: [native] add autoCapitalize="none".
Mon, Jun 10, 2:00 PM
varun updated the diff for D12385: [native] add autoCapitalize="none".

messed up test plan update

Mon, Jun 10, 1:59 PM
varun removed 1 blocking reviewer(s) for D12385: [native] add autoCapitalize="none": ashoat.
Mon, Jun 10, 1:58 PM
varun updated the diff for D12385: [native] add autoCapitalize="none".

update test plan

Mon, Jun 10, 1:58 PM
varun closed D12356: [web] introduce component to ping identity.
Mon, Jun 10, 1:51 PM
varun committed rCOMMc82807eb9cb6: [web] introduce component to ping identity (authored by varun).
[web] introduce component to ping identity
Mon, Jun 10, 1:51 PM
varun updated the test plan for D12385: [native] add autoCapitalize="none".
Mon, Jun 10, 1:44 PM
varun updated the diff for D12356: [web] introduce component to ping identity.

undo change to ping method

Mon, Jun 10, 1:37 PM
varun requested review of D12385: [native] add autoCapitalize="none".
Mon, Jun 10, 1:33 PM
varun added inline comments to D12356: [web] introduce component to ping identity.
Mon, Jun 10, 1:31 PM
varun updated the diff for D12356: [web] introduce component to ping identity.

I should've clarified that the purpose of this diff is to make sure that identity can be reached via gRPC-web in production

Mon, Jun 10, 1:08 PM

Fri, Jun 7

varun attached a referenced file: F1968729: Simulator Screenshot - iPhone 15 Pro Max - 2024-06-07 at 12.06.10.png.
Fri, Jun 7, 8:51 PM
varun requested review of D12356: [web] introduce component to ping identity.
Fri, Jun 7, 2:51 PM
varun closed D12353: [native][lib] update useDeleteDiscardedIdentityAccount to throw.
Fri, Jun 7, 11:47 AM
varun committed rCOMM008d75b22080: [native][lib] update useDeleteDiscardedIdentityAccount to throw (authored by varun).
[native][lib] update useDeleteDiscardedIdentityAccount to throw
Fri, Jun 7, 11:47 AM
varun closed D12335: [identity] reintroduce check to make sure only wallet users can call deleteWalletUser RPC.
Fri, Jun 7, 11:47 AM
varun closed D12326: [native] add back password input for account deletion.
Fri, Jun 7, 11:47 AM
varun committed rCOMMd08a0d0edfbb: [identity] reintroduce check to make sure only wallet users can call… (authored by varun).
[identity] reintroduce check to make sure only wallet users can call…
Fri, Jun 7, 11:47 AM
varun committed rCOMM32894cf32ae3: [native] add back password input for account deletion (authored by varun).
[native] add back password input for account deletion
Fri, Jun 7, 11:47 AM
varun closed D12325: [lib][native] update useDeleteDiscardedIdentityAccount to call deletePasswordUser when appropriate.
Fri, Jun 7, 11:47 AM
varun committed rCOMMa812d2e99185: [lib][native] update useDeleteDiscardedIdentityAccount to call… (authored by varun).
[lib][native] update useDeleteDiscardedIdentityAccount to call…
Fri, Jun 7, 11:47 AM
varun added inline comments to D12353: [native][lib] update useDeleteDiscardedIdentityAccount to throw.
Fri, Jun 7, 11:45 AM
varun added inline comments to D12326: [native] add back password input for account deletion.
Fri, Jun 7, 10:58 AM
varun updated the test plan for D12353: [native][lib] update useDeleteDiscardedIdentityAccount to throw.
Fri, Jun 7, 9:12 AM
varun published D12353: [native][lib] update useDeleteDiscardedIdentityAccount to throw for review.
Fri, Jun 7, 9:12 AM

Thu, Jun 6

varun requested review of D12335: [identity] reintroduce check to make sure only wallet users can call deleteWalletUser RPC.
Thu, Jun 6, 1:41 PM
varun added 1 blocking reviewer(s) for D12326: [native] add back password input for account deletion: ashoat.
Thu, Jun 6, 1:17 PM
varun updated the test plan for D12326: [native] add back password input for account deletion.
Thu, Jun 6, 1:10 PM
varun added inline comments to D12326: [native] add back password input for account deletion.
Thu, Jun 6, 1:08 PM
varun added a reviewer for D12326: [native] add back password input for account deletion: inka.

adding @inka as a blocking reviewer

Thu, Jun 6, 12:54 PM
varun updated the diff for D12326: [native] add back password input for account deletion.

fix regression when usingCSAT is false

Thu, Jun 6, 12:44 PM
varun updated the diff for D12326: [native] add back password input for account deletion.

fix error handling and ordering in useDeleteAccount

Thu, Jun 6, 12:32 PM
varun accepted D12304: [identity] Add /inbound_keys HTTP handler.
Thu, Jun 6, 3:31 AM
varun added inline comments to D12303: [identity] Add HTTP function to verify CSAT.
Thu, Jun 6, 3:19 AM
varun accepted D12303: [identity] Add HTTP function to verify CSAT.
Thu, Jun 6, 3:14 AM
varun accepted D12301: [identity] Create module for HTTP handler.
Thu, Jun 6, 3:13 AM

Wed, Jun 5

varun planned changes to D12326: [native] add back password input for account deletion.

improve UX if identity account deletion fails

Wed, Jun 5, 10:09 PM
varun published D12326: [native] add back password input for account deletion for review.
Wed, Jun 5, 10:08 PM
varun requested review of D12325: [lib][native] update useDeleteDiscardedIdentityAccount to call deletePasswordUser when appropriate.
Wed, Jun 5, 9:22 PM
varun accepted D12222: [native] Add dev-only button to log out secondary device.
Wed, Jun 5, 7:01 AM

Tue, Jun 4

varun closed D12291: [web] hide danger zone if usingCommServicesAccessToken.
Tue, Jun 4, 9:08 AM
varun committed rCOMMf526ba2287ef: [web] hide danger zone if usingCommServicesAccessToken (authored by varun).
[web] hide danger zone if usingCommServicesAccessToken
Tue, Jun 4, 9:07 AM

Mon, Jun 3

varun requested review of D12291: [web] hide danger zone if usingCommServicesAccessToken.
Mon, Jun 3, 1:52 PM
varun closed D12128: [native] try to log in if native user is missing CSAT.
Mon, Jun 3, 12:24 PM
varun committed rCOMM79827e1baff4: [native] try to log in if native user is missing CSAT (authored by varun).
[native] try to log in if native user is missing CSAT
Mon, Jun 3, 12:24 PM
varun added inline comments to D12128: [native] try to log in if native user is missing CSAT.
Mon, Jun 3, 12:06 PM
varun updated the diff for D12128: [native] try to log in if native user is missing CSAT.

address feedback

Mon, Jun 3, 12:04 PM
varun updated the test plan for D12128: [native] try to log in if native user is missing CSAT.
Mon, Jun 3, 11:52 AM
varun added inline comments to D12128: [native] try to log in if native user is missing CSAT.
Mon, Jun 3, 11:26 AM
varun closed D11912: [lib] add reserved username workflow to identity login actions.
Mon, Jun 3, 7:02 AM
varun committed rCOMM4c53d769d115: [lib] add reserved username workflow to identity login actions (authored by varun).
[lib] add reserved username workflow to identity login actions
Mon, Jun 3, 7:02 AM
varun closed D12258: [keyserver] update claim username responder to take username and password.
Mon, Jun 3, 6:50 AM
varun committed rCOMM1f76626f6f40: [keyserver] update claim username responder to take username and password (authored by varun).
[keyserver] update claim username responder to take username and password
Mon, Jun 3, 6:50 AM
varun added inline comments to D12258: [keyserver] update claim username responder to take username and password.
Mon, Jun 3, 6:37 AM
varun updated the diff for D11912: [lib] add reserved username workflow to identity login actions.

rebase

Mon, Jun 3, 6:30 AM
varun updated the diff for D12258: [keyserver] update claim username responder to take username and password.

rebase

Mon, Jun 3, 6:30 AM

Fri, May 31

varun published D12258: [keyserver] update claim username responder to take username and password for review.
Fri, May 31, 2:12 PM
varun updated the test plan for D12128: [native] try to log in if native user is missing CSAT.
Fri, May 31, 2:10 PM
varun updated the summary of D11912: [lib] add reserved username workflow to identity login actions.
Fri, May 31, 2:09 PM
varun updated the test plan for D11912: [lib] add reserved username workflow to identity login actions.
Fri, May 31, 2:09 PM
varun updated the diff for D12128: [native] try to log in if native user is missing CSAT.

rebase

Fri, May 31, 2:02 PM
varun updated the diff for D11912: [lib] add reserved username workflow to identity login actions.

rebase

Fri, May 31, 2:02 PM
varun abandoned D11911: [lib] hooks for reserved registration.

we dont need these

Fri, May 31, 12:55 PM

Thu, May 30

varun accepted D12244: [native] Fix LoggedOutModal buttons not appearing on load in release build.
Thu, May 30, 5:45 AM

Tue, May 28

varun closed D12212: [native_rust_library] fix serialization of BackupKeysResult.
Tue, May 28, 1:03 PM
varun committed rCOMM0179df617f89: [native_rust_library] fix serialization of BackupKeysResult (authored by varun).
[native_rust_library] fix serialization of BackupKeysResult
Tue, May 28, 1:03 PM
varun closed D12211: [keyserver] refactor identity.js.
Tue, May 28, 1:03 PM
varun committed rCOMMe41b3f34ec5d: [keyserver] refactor identity.js (authored by varun).
[keyserver] refactor identity.js
Tue, May 28, 1:03 PM
varun added a comment to D12231: Update native_rust_library Cargo.lock.

landed this because my IDE kept complaining

Tue, May 28, 1:01 PM
varun closed D12231: Update native_rust_library Cargo.lock.
Tue, May 28, 1:00 PM
varun committed rCOMMc91886c2bbb4: Update native_rust_library Cargo.lock (authored by bartek).
Update native_rust_library Cargo.lock
Tue, May 28, 1:00 PM

May 24 2024

varun accepted D12172: Inherit crate dependencies from workspace root.

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

May 24 2024, 10:16 AM
varun accepted D12171: Inherit package metadata from workspace.
May 24 2024, 10:14 AM
varun accepted D12140: Introduce Cargo workspace and update Dockerfiles.

nice!

May 24 2024, 10:13 AM
varun updated the diff for D12213: [keyserver] finish secondary login via qr code.

rebase

May 24 2024, 9:40 AM
varun added inline comments to D12161: [keyserver] call uploadSecondaryDeviceKeysAndLogIn.
May 24 2024, 9:39 AM
varun updated the diff for D12212: [native_rust_library] fix serialization of BackupKeysResult.

rebase

May 24 2024, 9:38 AM
varun added inline comments to D12146: [keyserver][lib][web] set up anonymous connection with tunnelbroker on keyserver and handle DEVICE_LIST_UPDATE_SUCCESS.
May 24 2024, 9:37 AM
varun updated the diff for D12211: [keyserver] refactor identity.js.

rebase

May 24 2024, 9:35 AM
varun closed D12161: [keyserver] call uploadSecondaryDeviceKeysAndLogIn.
May 24 2024, 9:31 AM
varun committed rCOMMaa859aa231e3: [keyserver] call uploadSecondaryDeviceKeysAndLogIn (authored by varun).
[keyserver] call uploadSecondaryDeviceKeysAndLogIn
May 24 2024, 9:31 AM
varun closed D12151: [rust-node-addon] generate_nonce client method.
May 24 2024, 9:31 AM
varun closed D12155: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method.
May 24 2024, 9:31 AM
varun committed rCOMMdeb9bb36d19d: [rust-node-addon] generate_nonce client method (authored by varun).
[rust-node-addon] generate_nonce client method
May 24 2024, 9:31 AM
varun committed rCOMM97447f13c288: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method (authored by varun).
[keyserver] uploadSecondaryDeviceKeysAndLogIn client method
May 24 2024, 9:31 AM
varun closed D12146: [keyserver][lib][web] set up anonymous connection with tunnelbroker on keyserver and handle DEVICE_LIST_UPDATE_SUCCESS.
May 24 2024, 9:31 AM
varun committed rCOMM9f890eef35d0: [keyserver][lib][web] set up anonymous connection with tunnelbroker on… (authored by varun).
[keyserver][lib][web] set up anonymous connection with tunnelbroker on…
May 24 2024, 9:31 AM
varun requested review of D12213: [keyserver] finish secondary login via qr code.
May 24 2024, 9:19 AM
varun requested review of D12211: [keyserver] refactor identity.js.
May 24 2024, 9:16 AM
varun requested review of D12212: [native_rust_library] fix serialization of BackupKeysResult.
May 24 2024, 9:15 AM

May 23 2024

varun accepted D12206: [terraform] Bump staging identity to 0.19.
May 23 2024, 11:23 PM
varun accepted D12091: [identity] Save initial device list to DDB.
May 23 2024, 7:11 AM
varun accepted D12090: [identity] Get and verify initial device list from registration requests.
May 23 2024, 7:03 AM
varun accepted D12089: [identity] Add function to verify initial device list.
May 23 2024, 6:52 AM

May 22 2024

varun accepted D12174: [feature-flags] Remove aws_types dependency.
May 22 2024, 7:48 AM
varun accepted D12173: [backup] Remove unnecessary aws_types dependency.
May 22 2024, 7:47 AM
varun accepted D12179: [rust] Fix Clippy warnings.
May 22 2024, 7:47 AM