Page MenuHomePhabricator
Feed Advanced Search

Jun 19 2024

varun closed D12474: [terraform] bump staging identity to 0.25-staging.
Jun 19 2024, 12:06 PM
varun committed rCOMM99578e599296: [terraform] bump staging identity to 0.25-staging (authored by varun).
[terraform] bump staging identity to 0.25-staging
Jun 19 2024, 12:06 PM
varun requested review of D12474: [terraform] bump staging identity to 0.25-staging.
Jun 19 2024, 7:22 AM
varun closed D12471: [web] fix uncaught exception bug.
Jun 19 2024, 6:39 AM
varun committed rCOMMfd8be14a14af: [web] fix uncaught exception bug (authored by varun).
[web] fix uncaught exception bug
Jun 19 2024, 6:39 AM
varun closed D12467: [web] mark otks as published before attempting to upload keys to identity.
Jun 19 2024, 6:39 AM
varun closed D12466: [keyserver] mark OTKs as published before calling registerUser RPC.
Jun 19 2024, 6:39 AM
varun closed D12468: [web] allow password users registered with identity to change their password from web.
Jun 19 2024, 6:39 AM
varun committed rCOMM6104bba4b556: [keyserver] mark OTKs as published before calling registerUser RPC (authored by varun).
[keyserver] mark OTKs as published before calling registerUser RPC
Jun 19 2024, 6:39 AM
varun committed rCOMMeaef1fac6184: [web] mark otks as published before attempting to upload keys to identity (authored by varun).
[web] mark otks as published before attempting to upload keys to identity
Jun 19 2024, 6:39 AM
varun committed rCOMM97e637fd353a: [web] allow password users registered with identity to change their password… (authored by varun).
[web] allow password users registered with identity to change their password…
Jun 19 2024, 6:39 AM
varun closed D10616: [lib][native][web] add new changeIdentityUserPassword action.
Jun 19 2024, 6:39 AM
varun closed D10623: [native] use useChangeIdentityUserPassword.
Jun 19 2024, 6:39 AM
varun committed rCOMMa6a35763be95: [lib][native][web] add new changeIdentityUserPassword action (authored by varun).
[lib][native][web] add new changeIdentityUserPassword action
Jun 19 2024, 6:39 AM
varun committed rCOMMe0aceb05b71e: [native] use useChangeIdentityUserPassword (authored by varun).
[native] use useChangeIdentityUserPassword
Jun 19 2024, 6:39 AM
varun closed D12465: [identity] update change password RPCs to match whitepaper.
Jun 19 2024, 6:39 AM
varun committed rCOMMa0954eecab3e: [identity] update change password RPCs to match whitepaper (authored by varun).
[identity] update change password RPCs to match whitepaper
Jun 19 2024, 6:39 AM

Jun 18 2024

varun requested review of D12471: [web] fix uncaught exception bug.
Jun 18 2024, 8:36 PM
varun published D12468: [web] allow password users registered with identity to change their password from web for review.

adding @ginsu because @ashoat may not be available

Jun 18 2024, 8:09 PM
varun updated the diff for D10623: [native] use useChangeIdentityUserPassword.

improve error handling

Jun 18 2024, 1:50 PM
varun added inline comments to D12465: [identity] update change password RPCs to match whitepaper.
Jun 18 2024, 1:50 PM
varun added inline comments to D12465: [identity] update change password RPCs to match whitepaper.
Jun 18 2024, 1:47 PM
varun updated the diff for D12465: [identity] update change password RPCs to match whitepaper.

use username as credential identifier

Jun 18 2024, 1:46 PM
varun requested review of D12467: [web] mark otks as published before attempting to upload keys to identity.
Jun 18 2024, 11:07 AM
varun requested review of D12466: [keyserver] mark OTKs as published before calling registerUser RPC.
Jun 18 2024, 10:52 AM
varun updated the diff for D10623: [native] use useChangeIdentityUserPassword.

fix logic

Jun 18 2024, 10:14 AM
varun updated the diff for D10623: [native] use useChangeIdentityUserPassword.

match whitepaper

Jun 18 2024, 10:09 AM
varun updated the diff for D10616: [lib][native][web] add new changeIdentityUserPassword action.

add the action types to redux-types.js

Jun 18 2024, 10:00 AM
varun requested review of D12465: [identity] update change password RPCs to match whitepaper.
Jun 18 2024, 9:58 AM
varun added inline comments to D10616: [lib][native][web] add new changeIdentityUserPassword action.
Jun 18 2024, 9:52 AM
varun updated the diff for D10616: [lib][native][web] add new changeIdentityUserPassword action.

update to match whitepaper

Jun 18 2024, 9:41 AM

Jun 17 2024

varun accepted D12416: [reports] Require auth for viewing reports.
Jun 17 2024, 9:01 PM
varun accepted D12415: [blob] Hide endpoints behind auth middleware.
Jun 17 2024, 9:00 PM
varun accepted D12414: [comm-lib] Verify CSAT in HTTP middleware.
Jun 17 2024, 8:59 PM
varun added a comment to D12441: Rename new_content_prekeys and new_notif_prekeys.

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

Jun 17 2024, 11:10 AM
varun closed D12456: [terraform] bump staging identity to 0.24-staging.
Jun 17 2024, 10:27 AM
varun committed rCOMMfb4e8fe802ab: [terraform] bump staging identity to 0.24-staging (authored by varun).
[terraform] bump staging identity to 0.24-staging
Jun 17 2024, 10:27 AM
varun accepted D12350: [identity] Forbid registering multiple devices with the same ID.
Jun 17 2024, 10:26 AM
varun published D12456: [terraform] bump staging identity to 0.24-staging for review.
Jun 17 2024, 10:18 AM
varun closed D12443: [keyserver] move mark_prekey_as_published calls inside of publishPrekeysToIdentity.
Jun 17 2024, 9:47 AM
varun committed rCOMMb7ba804bc704: [keyserver] move mark_prekey_as_published calls inside of… (authored by varun).
[keyserver] move mark_prekey_as_published calls inside of…
Jun 17 2024, 9:47 AM
varun closed D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation.
Jun 17 2024, 9:47 AM
varun closed D12441: Rename new_content_prekeys and new_notif_prekeys.
Jun 17 2024, 9:47 AM
varun committed rCOMMd0eda0b726ee: [keyserver] check if there are any unpublished prekeys and publish them during… (authored by varun).
[keyserver] check if there are any unpublished prekeys and publish them during…
Jun 17 2024, 9:47 AM
varun committed rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys (authored by varun).
Rename new_content_prekeys and new_notif_prekeys
Jun 17 2024, 9:47 AM
varun closed D12436: [web] update opaque-ke-wasm lockfile.
Jun 17 2024, 9:47 AM
varun committed rCOMM90fa6933a85d: [web] update opaque-ke-wasm lockfile (authored by varun).
[web] update opaque-ke-wasm lockfile
Jun 17 2024, 9:47 AM
varun closed D12435: [identity] last tonic status message conversions.
Jun 17 2024, 9:47 AM
varun closed D12434: [identity] convert/dedup more tonic status messages.
Jun 17 2024, 9:47 AM
varun closed D12433: [identity] continue converting/deduping tonic status messages.
Jun 17 2024, 9:47 AM
varun committed rCOMMa3512b23fe43: [identity] last tonic status message conversions (authored by varun).
[identity] last tonic status message conversions
Jun 17 2024, 9:47 AM
varun committed rCOMMaa9d2de90cc1: [identity] continue converting/deduping tonic status messages (authored by varun).
[identity] continue converting/deduping tonic status messages
Jun 17 2024, 9:47 AM
varun committed rCOMMce2c439b3059: [identity] convert/dedup more tonic status messages (authored by varun).
[identity] convert/dedup more tonic status messages
Jun 17 2024, 9:47 AM
varun closed D12432: [identity] more tonic status conversions.
Jun 17 2024, 9:47 AM
varun closed D12407: [web] check if version is supported by identity service.
Jun 17 2024, 9:47 AM
varun committed rCOMMca53cc98ef66: [web] check if version is supported by identity service (authored by varun).
[web] check if version is supported by identity service
Jun 17 2024, 9:47 AM
varun closed D12408: [web] remove ping component.
Jun 17 2024, 9:47 AM
varun committed rCOMM3ef4099f2016: [identity] more tonic status conversions (authored by varun).
[identity] more tonic status conversions
Jun 17 2024, 9:47 AM
varun committed rCOMMc6d5f53a58a5: [web] remove ping component (authored by varun).
[web] remove ping component
Jun 17 2024, 9:47 AM
varun closed D12406: [lib][native] add useVersionSupportedByIdentity hook and use it on native.
Jun 17 2024, 9:47 AM
varun committed rCOMM62c362d0a861: [lib][native] add useVersionSupportedByIdentity hook and use it on native (authored by varun).
[lib][native] add useVersionSupportedByIdentity hook and use it on native
Jun 17 2024, 9:47 AM
varun closed D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Jun 17 2024, 9:47 AM
varun closed D12404: [services] convert more tonic status messages to snake_case and dedup.
Jun 17 2024, 9:47 AM
varun committed rCOMM1351324c3760: [native][web][lib] add versionSupported method to IdentityServiceClient (authored by varun).
[native][web][lib] add versionSupported method to IdentityServiceClient
Jun 17 2024, 9:47 AM
varun committed rCOMMbbc994dad36d: [services] convert more tonic status messages to snake_case and dedup (authored by varun).
[services] convert more tonic status messages to snake_case and dedup
Jun 17 2024, 9:47 AM
varun closed D12402: [identity] rename and dedup more tonic Status messages.
Jun 17 2024, 9:47 AM
varun closed D12403: [identity] convert and dedup more tonic status messages.
Jun 17 2024, 9:47 AM
varun committed rCOMMca3a810bed68: [identity] rename and dedup more tonic Status messages (authored by varun).
[identity] rename and dedup more tonic Status messages
Jun 17 2024, 9:47 AM
varun committed rCOMM57dd79851329: [identity] convert and dedup more tonic status messages (authored by varun).
[identity] convert and dedup more tonic status messages
Jun 17 2024, 9:47 AM
varun closed D12401: [identity] dedup "unexpected message data" tonic message.
Jun 17 2024, 9:47 AM
varun committed rCOMMf040950485cc: [identity] dedup "unexpected message data" tonic message (authored by varun).
[identity] dedup "unexpected message data" tonic message
Jun 17 2024, 9:47 AM
varun added a comment to D12441: Rename new_content_prekeys and new_notif_prekeys.

Proto changes won't break compatibility, right?

Jun 17 2024, 9:38 AM
varun added inline comments to D12350: [identity] Forbid registering multiple devices with the same ID.
Jun 17 2024, 7:56 AM

Jun 14 2024

varun requested review of D12443: [keyserver] move mark_prekey_as_published calls inside of publishPrekeysToIdentity.
Jun 14 2024, 11:46 AM
varun added a reviewer for D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation: ashoat.
Jun 14 2024, 11:29 AM
varun requested review of D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation.
Jun 14 2024, 9:56 AM
varun requested review of D12441: Rename new_content_prekeys and new_notif_prekeys.
Jun 14 2024, 9:13 AM
varun updated the diff for D12407: [web] check if version is supported by identity service.

address feedback

Jun 14 2024, 8:01 AM
varun updated the diff for D12406: [lib][native] add useVersionSupportedByIdentity hook and use it on native.

make success payload an object

Jun 14 2024, 8:00 AM
varun accepted D12348: [identity][terraform] Create DDB index for deviceID.

smart solution!

Jun 14 2024, 6:40 AM
varun accepted D12349: [identity] Add function to query device by ID.
Jun 14 2024, 6:36 AM
varun accepted D12413: [backup] Add AuthService to HTTP server.
Jun 14 2024, 6:26 AM
varun accepted D12412: [comm-lib] Add env var to disable CSAT verification.
Jun 14 2024, 6:26 AM
varun accepted D12411: [comm-lib] Use futures_util::Ready to simplify code.
Jun 14 2024, 6:10 AM

Jun 13 2024

varun requested review of D12436: [web] update opaque-ke-wasm lockfile.
Jun 13 2024, 2:10 PM
varun requested review of D12435: [identity] last tonic status message conversions.
Jun 13 2024, 1:57 PM
varun requested review of D12434: [identity] convert/dedup more tonic status messages.
Jun 13 2024, 1:57 PM
varun requested review of D12432: [identity] more tonic status conversions.
Jun 13 2024, 1:50 PM
varun requested review of D12433: [identity] continue converting/deduping tonic status messages.
Jun 13 2024, 1:50 PM

Jun 12 2024

varun requested review of D12407: [web] check if version is supported by identity service.
Jun 12 2024, 12:47 PM
varun requested review of D12408: [web] remove ping component.
Jun 12 2024, 12:45 PM
varun requested review of D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Jun 12 2024, 12:37 PM
varun requested changes to D12350: [identity] Forbid registering multiple devices with the same ID.
Jun 12 2024, 9:05 AM
varun added a comment to D12350: [identity] Forbid registering multiple devices with the same ID.

in the login RPCs, don't we need to check that the device ID doesn't belong to a different user if it already exists?

Jun 12 2024, 9:04 AM
varun accepted D12350: [identity] Forbid registering multiple devices with the same ID.
Jun 12 2024, 8:56 AM
varun requested review of D12406: [lib][native] add useVersionSupportedByIdentity hook and use it on native.
Jun 12 2024, 8:46 AM
varun requested review of D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Jun 12 2024, 8:41 AM
varun requested review of D12404: [services] convert more tonic status messages to snake_case and dedup.
Jun 12 2024, 8:34 AM
varun requested review of D12403: [identity] convert and dedup more tonic status messages.
Jun 12 2024, 8:31 AM
varun requested review of D12402: [identity] rename and dedup more tonic Status messages.
Jun 12 2024, 8:31 AM