Page MenuHomePhabricator
Feed Advanced Search

Jul 3 2024

ginsu updated the summary of D12644: [native] introduce new vector assets for new thread notification settings experience.
Jul 3 2024, 3:04 PM
ginsu updated the diff for D12646: [lib/web] introduce useThreadSettingsNotifications.

address comments

Jul 3 2024, 12:25 PM
ginsu updated the diff for D12600: [native] introduce loading logic to RelationshipPrompt.

finish address comments

Jul 3 2024, 12:16 PM
ginsu added inline comments to D12600: [native] introduce loading logic to RelationshipPrompt.
Jul 3 2024, 12:10 PM
ginsu updated the diff for D12600: [native] introduce loading logic to RelationshipPrompt.

address comments

Jul 3 2024, 12:09 PM
ginsu updated the diff for D12596: [native] introduce loading logic to relationship prompt button.

update

Jul 3 2024, 12:03 PM
ginsu updated the diff for D12596: [native] introduce loading logic to relationship prompt button.

address comments

Jul 3 2024, 12:01 PM
ginsu updated the diff for D12595: [web] intorduce loading logic to relationship prompt button.

address comments

Jul 3 2024, 11:57 AM
ginsu requested review of D12651: [native] introduce LoadableButton.
Jul 3 2024, 10:31 AM
ginsu added inline comments to D12600: [native] introduce loading logic to RelationshipPrompt.
Jul 3 2024, 10:16 AM
ginsu updated the test plan for D12593: [lib] introduce loading logic to useRelationshipPrompt.
Jul 3 2024, 10:15 AM
ginsu added inline comments to D12646: [lib/web] introduce useThreadSettingsNotifications.
Jul 3 2024, 1:37 AM
ginsu requested review of D12648: [native] introduce NotificationDescription.
Jul 3 2024, 1:34 AM
ginsu requested review of D12647: [native] introduce barebones UI for ThreadSettingsNotifications.
Jul 3 2024, 1:27 AM
ginsu requested review of D12646: [lib/web] introduce useThreadSettingsNotifications.
Jul 3 2024, 1:23 AM
ginsu requested review of D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
Jul 3 2024, 1:18 AM

Jul 2 2024

ginsu updated the summary of D12596: [native] introduce loading logic to relationship prompt button.
Jul 2 2024, 9:45 PM
ginsu attached a referenced file: F2173150: Screenshot 2024-07-03 at 12.33.34 AM.png.
Jul 2 2024, 9:43 PM
ginsu attached a referenced file: F2173153: Screenshot 2024-07-03 at 12.33.49 AM.png.
Jul 2 2024, 9:42 PM
ginsu attached a referenced file: F2173155: Screenshot 2024-07-03 at 12.33.37 AM.png.
Jul 2 2024, 9:42 PM
ginsu attached a referenced file: F2173156: Screenshot 2024-07-03 at 12.33.54 AM.png.
Jul 2 2024, 9:42 PM
ginsu added a comment to D12600: [native] introduce loading logic to RelationshipPrompt.

Using RelationshipButton everywhere seems like a good idea, but we should be thoughtful about the complexity if we end up having to render different things in different surfaces

Jul 2 2024, 9:42 PM
ginsu retitled D12600: [native] introduce loading logic to RelationshipPrompt from [native] use RelationshipButton in RelationshipPrompt to [native] introduce loading logic to RelationshipPrompt.
Jul 2 2024, 9:38 PM
ginsu updated the diff for D12600: [native] introduce loading logic to RelationshipPrompt.

address comments

Jul 2 2024, 9:35 PM
ginsu attached a referenced file: F2172908: Screenshot 2024-07-02 at 11.50.42 PM.png.
Jul 2 2024, 8:56 PM
ginsu attached a referenced file: F2172907: Screenshot 2024-07-02 at 11.50.21 PM.png.
Jul 2 2024, 8:56 PM
ginsu attached a referenced file: F2172912: Screenshot 2024-07-02 at 11.55.27 PM.png.
Jul 2 2024, 8:56 PM
ginsu attached a referenced file: F2172911: Screenshot 2024-07-02 at 11.55.20 PM.png.
Jul 2 2024, 8:56 PM
ginsu updated the test plan for D12596: [native] introduce loading logic to relationship prompt button.
Jul 2 2024, 8:56 PM
ginsu updated the test plan for D12596: [native] introduce loading logic to relationship prompt button.
Jul 2 2024, 8:55 PM
ginsu updated the diff for D12596: [native] introduce loading logic to relationship prompt button.

address comments

Jul 2 2024, 8:53 PM
ginsu attached a referenced file: F2172636: Screenshot 2024-07-02 at 11.18.05 PM.png.
Jul 2 2024, 8:22 PM
ginsu added inline comments to D12595: [web] intorduce loading logic to relationship prompt button.
Jul 2 2024, 8:22 PM
ginsu updated the summary of D12644: [native] introduce new vector assets for new thread notification settings experience.
Jul 2 2024, 7:16 PM
ginsu requested review of D12644: [native] introduce new vector assets for new thread notification settings experience.
Jul 2 2024, 7:00 PM
ginsu requested review of D12643: [native] introduce type prop to EnumSettingsOption component.
Jul 2 2024, 6:55 PM
ginsu requested review of D12642: [native] introduce nav logic for ThreadSettingsNotifications.
Jul 2 2024, 6:52 PM
ginsu closed D12602: [web] fix colors in calendar history modal.
Jul 2 2024, 1:46 PM
ginsu committed rCOMMfc09fb873d01: [web] fix colors in calendar history modal (authored by ginsu).
[web] fix colors in calendar history modal
Jul 2 2024, 1:46 PM
ginsu closed D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.
Jul 2 2024, 1:44 PM
ginsu committed rCOMMd5fc6c85644a: [web] add Tag Farcaster channel option to CommunityActionsMenu (authored by ginsu).
[web] add Tag Farcaster channel option to CommunityActionsMenu
Jul 2 2024, 1:44 PM
ginsu closed D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.
Jul 2 2024, 1:44 PM
ginsu committed rCOMM697f38cc7c35: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal (authored by ginsu).
[web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal
Jul 2 2024, 1:44 PM
ginsu closed D12566: [web] introduce CreateFarcasterChannelTagModal.
Jul 2 2024, 1:44 PM
ginsu committed rCOMM406620819a1b: [web] introduce CreateFarcasterChannelTagModal (authored by ginsu).
[web] introduce CreateFarcasterChannelTagModal
Jul 2 2024, 1:44 PM
ginsu closed D12534: [lib/native/web] introduce RemoveTagButton.
Jul 2 2024, 1:44 PM
ginsu committed rCOMM27d7212e41e4: [lib/native/web] introduce RemoveTagButton (authored by ginsu).
[lib/native/web] introduce RemoveTagButton
Jul 2 2024, 1:44 PM
ginsu updated the diff for D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.

rebase before landing

Jul 2 2024, 1:41 PM
ginsu updated the diff for D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.

rebase before landing

Jul 2 2024, 1:40 PM
ginsu updated the diff for D12566: [web] introduce CreateFarcasterChannelTagModal.

rebase before landing

Jul 2 2024, 1:40 PM
ginsu updated the diff for D12534: [lib/native/web] introduce RemoveTagButton.

rebase before landing

Jul 2 2024, 1:39 PM
ginsu closed D12633: [landing] make footer flush with the bottom of the screen.
Jul 2 2024, 1:36 PM
ginsu committed rCOMMdde2391c9409: [landing] make footer flush with the bottom of the screen (authored by ginsu).
[landing] make footer flush with the bottom of the screen
Jul 2 2024, 1:36 PM
ginsu closed D12632: [landing] add hover effect to button.
Jul 2 2024, 1:36 PM
ginsu committed rCOMM2060717ee625: [landing] add hover effect to button (authored by ginsu).
[landing] add hover effect to button
Jul 2 2024, 1:36 PM
ginsu closed D12631: [landing] introduce differenation section.
Jul 2 2024, 1:36 PM
ginsu committed rCOMMfedfb7ebdb27: [landing] introduce differenation section (authored by ginsu).
[landing] introduce differenation section
Jul 2 2024, 1:36 PM
ginsu updated the diff for D12633: [landing] make footer flush with the bottom of the screen.

rebase before landing

Jul 2 2024, 1:35 PM
ginsu updated the diff for D12632: [landing] add hover effect to button.

rebase before landing

Jul 2 2024, 1:34 PM
ginsu updated the diff for D12631: [landing] introduce differenation section.

rebase before landing

Jul 2 2024, 1:33 PM
ginsu added a comment to D12631: [landing] introduce differenation section.

I mean less like an icon, and more like a graphic of the functionality. Eg. for the tree structure piece we could include a screenshot of the navigation side drawer

Jul 2 2024, 1:31 PM
ginsu attached a referenced file: F2168564: Screenshot 2024-07-02 at 12.20.18 PM.png.
Jul 2 2024, 9:21 AM
ginsu attached a referenced file: F2168563: Screenshot 2024-07-02 at 12.20.14 PM.png.
Jul 2 2024, 9:21 AM
ginsu updated the test plan for D12534: [lib/native/web] introduce RemoveTagButton.
Jul 2 2024, 9:20 AM
ginsu updated the diff for D12534: [lib/native/web] introduce RemoveTagButton.

address comments

Jul 2 2024, 9:18 AM

Jul 1 2024

ginsu attached a referenced file: F2163971: Screenshot 2024-07-02 at 1.00.31 AM.png.
Jul 1 2024, 10:05 PM
ginsu updated the test plan for D12602: [web] fix colors in calendar history modal.
Jul 1 2024, 10:05 PM
ginsu updated the diff for D12593: [lib] introduce loading logic to useRelationshipPrompt.

address comments

Jul 1 2024, 10:05 PM
ginsu updated the diff for D12602: [web] fix colors in calendar history modal.

address comments

Jul 1 2024, 10:01 PM
ginsu added reviewers for D12633: [landing] make footer flush with the bottom of the screen: ashoat, inka.
Jul 1 2024, 9:51 PM
ginsu requested review of D12633: [landing] make footer flush with the bottom of the screen.
Jul 1 2024, 8:47 PM
ginsu requested review of D12632: [landing] add hover effect to button.
Jul 1 2024, 8:40 PM
ginsu closed D12582: [web] fix leave channel modal for long thread names.
Jul 1 2024, 8:39 PM
ginsu committed rCOMM1e78a6e4f88a: [web] fix leave channel modal for long thread names (authored by ginsu).
[web] fix leave channel modal for long thread names
Jul 1 2024, 8:39 PM
ginsu added a comment to D12631: [landing] introduce differenation section.

Wondering, if we wanted to include a graphic how would we do it here?

Jul 1 2024, 8:22 PM
ginsu added inline comments to D12631: [landing] introduce differenation section.
Jul 1 2024, 8:06 PM
ginsu updated the diff for D12631: [landing] introduce differenation section.

fix feature flag

Jul 1 2024, 8:05 PM
ginsu updated the diff for D12631: [landing] introduce differenation section.

address comments

Jul 1 2024, 8:00 PM
ginsu closed D12630: [landing] switch comparison order in CompetitorFeature.
Jul 1 2024, 7:28 PM
ginsu committed rCOMM2b33c26be1c2: [landing] switch comparison order in CompetitorFeature (authored by ginsu).
[landing] switch comparison order in CompetitorFeature
Jul 1 2024, 7:28 PM
ginsu closed D12629: [landing] extend exiting competitor comparison code to handle new differentiation section.
Jul 1 2024, 7:28 PM
ginsu committed rCOMMf5f890054d4f: [landing] extend exiting competitor comparison code to handle new… (authored by ginsu).
[landing] extend exiting competitor comparison code to handle new…
Jul 1 2024, 7:28 PM
ginsu added a comment to D12630: [landing] switch comparison order in CompetitorFeature.

Does this also change the order in the pop-up cards with the long descriptions? If not, can you flip the order there too?

Jul 1 2024, 7:26 PM
ginsu updated the diff for D12593: [lib] introduce loading logic to useRelationshipPrompt.

address comments

Jul 1 2024, 1:26 PM
ginsu updated the diff for D12582: [web] fix leave channel modal for long thread names.

address comments + rebase before landing

Jul 1 2024, 1:07 PM
ginsu closed D12592: [landing] add download icon to mobile nav.
Jul 1 2024, 12:31 PM
ginsu closed D12591: [landing] add link to download page in the header.
Jul 1 2024, 12:31 PM
ginsu committed rCOMM1ca7214148fa: [landing] add link to download page in the header (authored by ginsu).
[landing] add link to download page in the header
Jul 1 2024, 12:31 PM
ginsu committed rCOMMa738036b200a: [landing] add download icon to mobile nav (authored by ginsu).
[landing] add download icon to mobile nav
Jul 1 2024, 12:31 PM
ginsu closed D12583: [landing] introduce download page.
Jul 1 2024, 12:31 PM
ginsu committed rCOMMb73cf51e75c8: [landing] introduce download page (authored by ginsu).
[landing] introduce download page
Jul 1 2024, 12:31 PM
ginsu updated the diff for D12592: [landing] add download icon to mobile nav.

rebase before landing

Jul 1 2024, 12:29 PM
ginsu updated the diff for D12591: [landing] add link to download page in the header.

rebase before landing

Jul 1 2024, 12:28 PM
ginsu updated the diff for D12583: [landing] introduce download page.

address comments

Jul 1 2024, 12:26 PM
ginsu updated the summary of D12631: [landing] introduce differenation section.
Jul 1 2024, 8:00 AM
ginsu requested review of D12631: [landing] introduce differenation section.
Jul 1 2024, 7:44 AM
ginsu updated the summary of D12630: [landing] switch comparison order in CompetitorFeature.
Jul 1 2024, 7:43 AM
ginsu requested review of D12630: [landing] switch comparison order in CompetitorFeature.
Jul 1 2024, 7:41 AM
ginsu requested review of D12629: [landing] extend exiting competitor comparison code to handle new differentiation section.
Jul 1 2024, 7:33 AM

Jun 30 2024

ginsu updated the diff for D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.

update

Jun 30 2024, 8:13 PM