Page MenuHomePhabricator
Feed Advanced Search

Mar 22 2024

varun committed rCOMM2f2c103a8228: [terraform] use farcaster image on staging (authored by varun).
[terraform] use farcaster image on staging
Mar 22 2024, 12:02 PM

Mar 21 2024

varun requested review of D11371: [terraform] use farcaster image on staging.
Mar 21 2024, 6:47 PM
varun added a reviewer for D11363: [web] don't generate or send one time keys on login: michal.
Mar 21 2024, 9:06 AM
varun updated the diff for D11363: [web] don't generate or send one time keys on login.

dedup

Mar 21 2024, 9:06 AM

Mar 20 2024

varun closed D11356: [native] improve error handling in parseOLMPrekeys.
Mar 20 2024, 2:33 PM
varun committed rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys (authored by varun).
[native] improve error handling in parseOLMPrekeys
Mar 20 2024, 2:33 PM
varun closed D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Mar 20 2024, 2:33 PM
varun committed rCOMM05d0a3892342: [native][lib][web] update IdentityServiceClient implementations and useLogOut… (authored by varun).
[native][lib][web] update IdentityServiceClient implementations and useLogOut…
Mar 20 2024, 2:33 PM
varun added a comment to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

Looks good on the identity-service-client-proxy part.

Short explanation is -> we are moving the identity client to worker so that multiple tabs can synchronize the identity calls between them and not conflict. identity-service-client-wrapper.js will run on web worker and identity-service-client-proxy.js will run in the tab JS context and pass the method calls to the worker (we didn't "flip the switch" yet so for now the identity-service-client-wrapper.js is still running in the tab JS context though).

Mar 20 2024, 2:31 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Mar 20 2024, 2:30 PM

Mar 19 2024

varun requested review of D11364: [native] don't generate or send one time keys on login.
Mar 19 2024, 6:44 PM
varun planned changes to D11363: [web] don't generate or send one time keys on login.

need to dedup a little

Mar 19 2024, 6:40 PM
varun published D11363: [web] don't generate or send one time keys on login for review.
Mar 19 2024, 6:39 PM
varun requested review of D11362: [web] factor out common code in authNewDeviceKeyUpload.
Mar 19 2024, 6:38 PM
varun requested review of D11361: [lib][web] deviceKeyUpload -> newDeviceKeyUpload.
Mar 19 2024, 6:37 PM
varun requested review of D11360: [keyserver][lib] don't generate one time keys on identity login.
Mar 19 2024, 6:36 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Mar 19 2024, 5:57 PM
varun requested review of D11356: [native] improve error handling in parseOLMPrekeys.
Mar 19 2024, 12:08 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Mar 19 2024, 8:26 AM

Mar 18 2024

varun closed D11321: [native] update userAlreadyExists in ConnectEthereum component.
Mar 18 2024, 10:32 PM
varun closed D11334: [native] add logOut to CommRustModule.
Mar 18 2024, 10:32 PM
varun committed rCOMM428986bd7ab1: [native] add logOut to CommRustModule (authored by varun).
[native] add logOut to CommRustModule
Mar 18 2024, 10:32 PM
varun committed rCOMM8251ee8e892a: [native] update userAlreadyExists in ConnectEthereum component (authored by varun).
[native] update userAlreadyExists in ConnectEthereum component
Mar 18 2024, 10:32 PM
varun closed D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Mar 18 2024, 10:32 PM
varun closed D11320: [native] use findUserID RPC in UsernameSelection component.
Mar 18 2024, 10:32 PM
varun committed rCOMMe76b8a89a463: [native] use findUserID RPC in UsernameSelection component (authored by varun).
[native] use findUserID RPC in UsernameSelection component
Mar 18 2024, 10:32 PM
varun committed rCOMM0390a90e6730: [crypto] make sure short format of prekey is expected when creating an outbound… (authored by varun).
[crypto] make sure short format of prekey is expected when creating an outbound…
Mar 18 2024, 10:32 PM
varun closed D11312: [native] use short form for prekeys.
Mar 18 2024, 10:32 PM
varun committed rCOMM3d1844eb73a8: [native] use short form for prekeys (authored by varun).
[native] use short form for prekeys
Mar 18 2024, 10:32 PM
varun added inline comments to D11312: [native] use short form for prekeys.
Mar 18 2024, 10:28 PM
varun added a reviewer for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js: michal.
Mar 18 2024, 10:13 PM
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

address feedback on previous revision

Mar 18 2024, 7:40 PM
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

after rebasing i started getting a flow error. updated web/grpc/identity-service-client-proxy.js to resolve it, but not really sure what this code does... going to add @michal as a reviewer

Mar 18 2024, 7:36 PM
varun closed D11305: [terraform] use identity 0.12 on prod.
Mar 18 2024, 7:44 AM
varun committed rCOMM503fd514a397: [terraform] use identity 0.12 on prod (authored by varun).
[terraform] use identity 0.12 on prod
Mar 18 2024, 7:44 AM

Mar 16 2024

varun added inline comments to D11320: [native] use findUserID RPC in UsernameSelection component.
Mar 16 2024, 4:37 PM

Mar 15 2024

varun added 1 blocking reviewer(s) for D11305: [terraform] use identity 0.12 on prod: ashoat.

setting @ashoat as blocking

Mar 15 2024, 12:47 PM
varun updated the diff for D11334: [native] add logOut to CommRustModule.

rebase

Mar 15 2024, 12:46 PM
varun updated the diff for D11334: [native] add logOut to CommRustModule.

rebase on top of prekey format diffs

Mar 15 2024, 12:44 PM
varun published D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js for review.
Mar 15 2024, 12:43 PM

Mar 14 2024

varun requested review of D11334: [native] add logOut to CommRustModule.
Mar 14 2024, 9:34 PM
varun requested review of D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Mar 14 2024, 9:30 PM
varun closed D11329: [identity] Update invalid username check on Identity service.
Mar 14 2024, 3:02 PM
varun committed rCOMMf3c665ffa54b: [identity] Update invalid username check on Identity service (authored by varun).
[identity] Update invalid username check on Identity service
Mar 14 2024, 3:02 PM
varun requested review of D11329: [identity] Update invalid username check on Identity service.
Mar 14 2024, 9:03 AM

Mar 13 2024

varun requested review of D11321: [native] update userAlreadyExists in ConnectEthereum component.
Mar 13 2024, 7:15 PM
varun requested review of D11320: [native] use findUserID RPC in UsernameSelection component.
Mar 13 2024, 7:11 PM
varun requested review of D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Mar 13 2024, 5:38 PM
varun requested review of D11305: [terraform] use identity 0.12 on prod.
Mar 13 2024, 12:51 PM
varun added a comment to D11305: [terraform] use identity 0.12 on prod.
  1. What's "retagging" mean and why was it necessary here?
Mar 13 2024, 12:51 PM

Mar 12 2024

varun closed D11285: [keyserver] make force login configurable.
Mar 12 2024, 11:26 PM
varun committed rCOMMe7c687014447: [keyserver] make force login configurable (authored by varun).
[keyserver] make force login configurable
Mar 12 2024, 11:26 PM
varun closed D11278: [identity] add optional force param to password login RPC.
Mar 12 2024, 11:26 PM
varun committed rCOMM913012d3c753: [identity] add optional force param to password login RPC (authored by varun).
[identity] add optional force param to password login RPC
Mar 12 2024, 11:26 PM
varun added inline comments to D11278: [identity] add optional force param to password login RPC.
Mar 12 2024, 11:08 PM
varun requested review of D11312: [native] use short form for prekeys.
Mar 12 2024, 1:15 PM

Mar 11 2024

varun removed a reviewer for D11278: [identity] add optional force param to password login RPC: ashoat. varun added 1 blocking reviewer(s) for D11278: [identity] add optional force param to password login RPC: bartek.
Mar 11 2024, 12:18 PM
varun requested review of D11305: [terraform] use identity 0.12 on prod.
Mar 11 2024, 12:04 PM
varun added a reviewer for D11278: [identity] add optional force param to password login RPC: ashoat.
Mar 11 2024, 6:26 AM

Mar 10 2024

varun added inline comments to D11285: [keyserver] make force login configurable.
Mar 10 2024, 2:51 PM

Mar 8 2024

varun requested review of D11285: [keyserver] make force login configurable.
Mar 8 2024, 8:41 PM
varun requested review of D11278: [identity] add optional force param to password login RPC.
Mar 8 2024, 1:19 AM

Mar 6 2024

varun closed D11260: [terraform] return to 2 identical identity service instances.
Mar 6 2024, 7:18 PM
varun committed rCOMM6d31a0c7ab90: [terraform] return to 2 identical identity service instances (authored by varun).
[terraform] return to 2 identical identity service instances
Mar 6 2024, 7:18 PM
varun updated the diff for D11260: [terraform] return to 2 identical identity service instances.

fix typo in allow origin list

Mar 6 2024, 7:00 PM
varun added a reviewer for D11260: [terraform] return to 2 identical identity service instances: bartek.
Mar 6 2024, 3:19 PM
varun updated the diff for D11260: [terraform] return to 2 identical identity service instances.

set image tag conditionally so that we can use different images for staging and production

Mar 6 2024, 3:18 PM
varun closed D11257: [keyserver][native] remove cookie logic.
Mar 6 2024, 3:02 PM
varun committed rCOMM9a5a6b5507ba: [keyserver][native] remove cookie logic (authored by varun).
[keyserver][native] remove cookie logic
Mar 6 2024, 3:02 PM
varun closed D11255: [identity] db client methods to interact with workflows table.
Mar 6 2024, 3:02 PM
varun closed D11256: [identity] replace cache calls with DB client method calls.
Mar 6 2024, 3:02 PM
varun committed rCOMMf860982d2c3c: [identity] replace cache calls with DB client method calls (authored by varun).
[identity] replace cache calls with DB client method calls
Mar 6 2024, 3:02 PM
varun committed rCOMM66fb97a36bf4: [identity] db client methods to interact with workflows table (authored by varun).
[identity] db client methods to interact with workflows table
Mar 6 2024, 3:02 PM
varun closed D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.
Mar 6 2024, 3:02 PM
varun committed rCOMM9e266a65d4a0: [services] derive serialize/deserialize for WorkflowInProgress enum (authored by varun).
[services] derive serialize/deserialize for WorkflowInProgress enum
Mar 6 2024, 3:02 PM
varun planned changes to D11260: [terraform] return to 2 identical identity service instances.

ah remembered why i didn't do this right away... i need to first land the rest of the stack and cut a new release

Mar 6 2024, 2:42 PM
varun added inline comments to D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.
Mar 6 2024, 2:40 PM
varun requested review of D11260: [terraform] return to 2 identical identity service instances.
Mar 6 2024, 2:21 PM
varun added a comment to D11257: [keyserver][native] remove cookie logic.

Should this stack include a diff to bring us back to having two parallel identity instances in production?

Mar 6 2024, 1:53 PM
varun added a comment to D11256: [identity] replace cache calls with DB client method calls.
In D11256#325184, @will wrote:

Looks good to me. We're removing the cache to support stateless sessions correct?

Mar 6 2024, 1:36 PM
varun closed D11251: [identity] let clap handle parsing env var to vec.
Mar 6 2024, 10:45 AM
varun committed rCOMM1319a7577335: [identity] let clap handle parsing env var to vec (authored by varun).
[identity] let clap handle parsing env var to vec
Mar 6 2024, 10:45 AM
varun closed D11250: [identity] validate origins provided through env var.
Mar 6 2024, 10:45 AM
varun committed rCOMM03122bd87293: [identity] validate origins provided through env var (authored by varun).
[identity] validate origins provided through env var
Mar 6 2024, 10:45 AM
varun added a comment to D11256: [identity] replace cache calls with DB client method calls.

i've updated D11255 to use DeleteItem in get_workflow(). Now the function retrieves and removes the workflow, so we don't run the risk of retrieving it multiple times

Mar 6 2024, 10:15 AM
varun updated the diff for D11255: [identity] db client methods to interact with workflows table.

use DeleteItem instead of GetItem

Mar 6 2024, 10:13 AM
varun added a comment to D11256: [identity] replace cache calls with DB client method calls.
  1. We no longer invalidate the cache. What happens if a client calls _finish method a second time?
Mar 6 2024, 10:07 AM

Mar 5 2024

varun requested review of D11257: [keyserver][native] remove cookie logic.
Mar 5 2024, 11:49 PM
varun requested review of D11256: [identity] replace cache calls with DB client method calls.
Mar 5 2024, 11:28 PM
varun added a reviewer for D11160: [services] derive serialize/deserialize for WorkflowInProgress enum: bartek.
Mar 5 2024, 11:24 PM
varun requested review of D11255: [identity] db client methods to interact with workflows table.
Mar 5 2024, 11:13 PM
varun updated the diff for D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.

fix serialization/deserialization of Login struct

Mar 5 2024, 10:02 PM
varun requested review of D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.
Mar 5 2024, 9:16 PM
varun requested review of D11251: [identity] let clap handle parsing env var to vec.
Mar 5 2024, 3:52 PM
varun requested review of D11250: [identity] validate origins provided through env var.
Mar 5 2024, 3:50 PM
varun accepted D11232: Introduce notifications crypto module to CommCoreModule.

agree with @kamil 's suggestions, but lgtm otherwise

Mar 5 2024, 12:47 PM
varun closed D11207: [web] fix regression in error handling.
Mar 5 2024, 12:46 PM
varun closed D11194: [identity] add allow origin list to config struct.
Mar 5 2024, 12:46 PM
varun committed rCOMMdadf56db5def: [web] fix regression in error handling (authored by varun).
[web] fix regression in error handling
Mar 5 2024, 12:46 PM
varun committed rCOMMf17f04eb263d: [identity] add allow origin list to config struct (authored by varun).
[identity] add allow origin list to config struct
Mar 5 2024, 12:46 PM